Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ParseUint to test for overflow directly #961

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Use ParseUint to test for overflow directly #961

merged 2 commits into from
Dec 2, 2024

Conversation

dcarbone
Copy link
Contributor

@dcarbone dcarbone commented Dec 2, 2024

No description provided.

nathanejohnson
nathanejohnson previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@nathanejohnson nathanejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tristanmorgan
tristanmorgan approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@tristanmorgan tristanmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clear and concise.

@dcarbone dcarbone merged commit c2e0c36 into master Dec 2, 2024
4 checks passed
@dcarbone dcarbone deleted the dcarbone/parse-uint16 branch December 2, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanmorgan tristanmorgan tristanmorgan approved these changes

@aaronhurt aaronhurt Awaiting requested review from aaronhurt

@nathanejohnson nathanejohnson Awaiting requested review from nathanejohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcarbone @nathanejohnson @tristanmorgan