Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async tranformers in test utils #646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaquitoSoft
Copy link

Currently the available test utilities exposed by the library helps a lot when developers need to test their custom transformation but they only support synchronous transformations.

I've seen others also asking about this feature (reference1, reference 2) so I've decided to give it a try and update those utilities to be able to manage both sync and async transformations.

Please let me know if this is something that could potentially be adopted by jscodeshift.

Thanks.

Copy link

changeset-bot bot commented Dec 21, 2024

🦋 Changeset detected

Latest commit: 71f1439

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jscodeshift Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jscodeshift ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:26pm

@facebook-github-bot
Copy link

Hi @PaquitoSoft!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link

pkg-pr-new bot commented Dec 27, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/[email protected]

commit: b3ff200

@Daniel15
Copy link
Member

Daniel15 commented Dec 27, 2024

Thanks for this!

Can you please add a changeset as per the second comment? We're trying to start using changesets to manage versioning/releases.

@PaquitoSoft
Copy link
Author

@Daniel15 Sorry I forgot about it.

I've just added it in this commit: 71f1439

Is it enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants