-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable async tranformers in test utils #646
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 71f1439 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @PaquitoSoft! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
commit: |
Thanks for this! Can you please add a changeset as per the second comment? We're trying to start using changesets to manage versioning/releases. |
Currently the available test utilities exposed by the library helps a lot when developers need to test their custom transformation but they only support synchronous transformations.
I've seen others also asking about this feature (reference1, reference 2) so I've decided to give it a try and update those utilities to be able to manage both sync and async transformations.
Please let me know if this is something that could potentially be adopted by
jscodeshift
.Thanks.