Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix some cases where we override setBackgroundColor on View-level ins…
…tead of VM level (#46846) Summary: Pull Request resolved: #46846 As of D61658739, BaseViewManager setting color now goes through BackgroundStyleApplicator, which gives a default implementation of setting a background color, while storing information in a way where we can impement things like border radii and shadows on background for out of the box views. I knew this could lead to breaks where we previously overrode view-level `setBackgroundColor` to do something custom, but didn't override on VM level, but didn't see any external usages so I assumed it should be relatively safe. Turns out we have some internal usages which run into this pattern (D63913128 already fixed one), including a usage in RN itself! Let's override the view managers in these to delegate to the view's custom drawing. Changelog: [Android][Fixed] - Fix some cases where we override setBackgroundColor on View-level instead of VM level Reviewed By: Abbondanzo Differential Revision: D63922722 fbshipit-source-id: af988d1436c790be97b2be1325541aa418bf43a3
- Loading branch information