Skip to content

Commit

Permalink
Starlark needs hg instead of sl
Browse files Browse the repository at this point in the history
Summary:
We can only specify `hg` as a dependency, so have to use it in our shell script.

Changelog: [Internal]

Differential Revision: D67718641
  • Loading branch information
blakef authored and facebook-github-bot committed Jan 2, 2025
1 parent d050163 commit 436023e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/api/check-api.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ EOF
)

function check_if_mentions_breaking_change() {
IN_COMMIT_MESSAGE=$(sl log -r . -T '{desc}' | grep -iE '\[(android|ios|general|internal)\]\s*\[breaking\]' || true)
IN_COMMIT_MESSAGE=$(hg log -r . -T '{desc}' | grep -iE '\[(android|ios|general|internal)\]\s*\[breaking\]' || true)
if [ -z "$IN_COMMIT_MESSAGE" ]; then
echo "$ERROR_MENTION_BREAKING_CHANGE"
exit $ERR_CODE_BAD_COMMIT
fi
}

FBSOURCE_ROOT="$(sl root)"
FBSOURCE_ROOT="$(hg root)"

# shellcheck source=xplat/js/env-utils/setup_env_base.sh
source "$FBSOURCE_ROOT/xplat/js/env-utils/setup_env_base.sh"
Expand Down Expand Up @@ -77,7 +77,7 @@ echo

API_FILE=$(grep -oP '(?<=output=)[^ \n]+' tools/api/public-api.conf)

API_STATUS=$(sl status --no-status "$API_FILE")
API_STATUS=$(hg status --no-status "$API_FILE")
if [ -z "$API_STATUS" ]; then
echo "🎉 No public API changes, happy days!"
exit 0
Expand Down

0 comments on commit 436023e

Please sign in to comment.