-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Separate component array types and command array types (#48474)
Summary: The previous definition said that you could put prop types into commands, which definitely isn't allowed. For example, the schema would have allowed `WithDefault` types. ``` interface NativeCommands { +methodInt: (viewRef: React.ElementRef<NativeType>, a: WithDefault<string, 'hi'>) => void; } ``` This change separates out the things that are allowed in commands from what's allowed in props. Commands should be very similar to what's allowed in native modules, but it isn't exact enough to be able to merge those. Differential Revision: D67806818
- Loading branch information
1 parent
5c269f5
commit 8b2f4e3
Showing
2 changed files
with
26 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters