Skip to content

Commit

Permalink
Demonstrate bug in differentiator where reparented nodes reference no…
Browse files Browse the repository at this point in the history
…n-existent nodes (#48002)

Summary:
Pull Request resolved: #48002

Demonstrates the issue identified in #47960 and a crash we've been seeing internally around `getViewState` referencing a view that does not exist.

When reparenting unflattened nodes, Differentiator may emit an `update` with a `parentShadowView` that does not exist on the native side yet, thereby crashing Android.

Landing the test-case first (with some test cleanup), so the diff for the actual fix is clearer.

Changelog: [Internal]

Reviewed By: lenaic

Differential Revision: D66557919

fbshipit-source-id: 5428c32e5f0200a8e98568cabeedb0c61aafbe23
  • Loading branch information
javache authored and facebook-github-bot committed Nov 28, 2024
1 parent 24fee29 commit bc9e4db
Showing 1 changed file with 117 additions and 184 deletions.
Loading

0 comments on commit bc9e4db

Please sign in to comment.