-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starlark needs hg instead of sl #48460
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 2, 2025
This pull request was exported from Phabricator. Differential Revision: D67718641 |
blakef
force-pushed
the
export-D67718641
branch
from
January 2, 2025 22:22
436023e
to
c7bf285
Compare
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Jan 2, 2025
Summary: We can only specify `hg` as a dependency, so have to use it in our shell script. Changelog: [Internal] Differential Revision: D67718641
This pull request was exported from Phabricator. Differential Revision: D67718641 |
Summary: This is the current output of running the api snapshotting tool. I've also shown some test examples that show how trivial changes affect the API file. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D67713415
Summary: Adding CI support will require executing through buck. Sandboxing means the package has to be well-formed to work, so this cleans up some earlier mess. - yarn workspace - check-api.sh to configure the environment correctly when running form sandcastle - explicity dependencies in our package.json This is the first step Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D67726588
Summary: We can only specify `hg` as a dependency, so have to use it in our shell script. Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D67718641
blakef
force-pushed
the
export-D67718641
branch
from
January 3, 2025 15:23
c7bf285
to
de31aaa
Compare
This pull request was exported from Phabricator. Differential Revision: D67718641 |
This pull request has been merged in 9542b1a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can only specify
hg
as a dependency, so have to use it in our shell script.Changelog: [Internal]
Differential Revision: D67718641