Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Tuist in the Template #37952

Closed
wants to merge 1 commit into from
Closed

Introduce Tuist in the Template #37952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions packages/react-native/template/ios/Derived/Sources/TuistAssets+HelloWorld.swift
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be put into .gitignore. It's automatically generated and not something users should commit. Projects created with tuist init the whole Derived folder in .gitignore

Copy link
Contributor Author

@cipolleschi cipolleschi Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, as I said in the Next Steps above:

Next Steps:

update the CLI so that it can use tuist
Remove the generated files from the template and add them to the .gitignore.
update RN Doctor so that it knows about tuist

The reason why they are not ignored now is to allow users to use the Xcodeproj without the need of installing tuist. The plan is to ignore them and remove the xcodeproj as soon as the CLI can handle Tuist properly.

Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// swiftlint:disable all
// swift-format-ignore-file
// swiftformat:disable all
// Generated using tuist — https://github.com/tuist/tuist

#if os(macOS)
import AppKit
#elseif os(iOS)
import UIKit
#elseif os(tvOS) || os(watchOS)
import UIKit
#endif
#if canImport(SwiftUI)
import SwiftUI
#endif

// swiftlint:disable superfluous_disable_command file_length implicit_return

// MARK: - Asset Catalogs

// swiftlint:disable identifier_name line_length nesting type_body_length type_name
public enum HelloWorldAsset {
}
// swiftlint:enable identifier_name line_length nesting type_body_length type_name

// MARK: - Implementation Details

// swiftlint:enable all
// swiftformat:enable all
24 changes: 24 additions & 0 deletions packages/react-native/template/ios/Derived/Sources/TuistBundle+HelloWorld.swift
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be gitignored, too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// swiftlint:disable all
// swift-format-ignore-file
// swiftformat:disable all
import Foundation

// MARK: - Swift Bundle Accessor

private class BundleFinder {}

extension Foundation.Bundle {
/// Since HelloWorld is a application, the bundle for classes within this module can be used directly.
static let module = Bundle(for: BundleFinder.self)
}

// MARK: - Objective-C Bundle Accessor

@objc
public class HelloWorldResources: NSObject {
@objc public class var bundle: Bundle {
return .module
}
}
// swiftlint:enable all
// swiftformat:enable all
Loading