Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][GHA] Add Android Helloworld test on PR #45019

Closed
wants to merge 1 commit into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jun 18, 2024

Summary:

Will run test_android_helloworld when users create a PR, to provide
coverage while we figure out what's going on with our CircleCI tests /
deprecate them.

Changelog:

[Internal]

Test Plan:

Does GHA run for this PR?

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 18, 2024
@blakef blakef force-pushed the feat/add-android-gha-pr-ci branch 10 times, most recently from bf559b1 to 12997cd Compare June 18, 2024 12:53
@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@blakef blakef force-pushed the feat/add-android-gha-pr-ci branch 2 times, most recently from 609afc6 to 3b7fa05 Compare June 18, 2024 13:08
@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Will run test_android_helloworld when users create a PR, to provide
coverage while we figure out what's going on with our CircleCI tests /
deprecate them.

Changelog: [Internal]
@blakef blakef force-pushed the feat/add-android-gha-pr-ci branch from 3b7fa05 to c05f532 Compare June 18, 2024 13:19
@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 18, 2024
@facebook-github-bot
Copy link
Contributor

@blakef merged this pull request in 64d5de7.

Copy link

This pull request was successfully merged by @blakef in 64d5de7.

When will my fix make it into a release? | How to file a pick request?

@blakef blakef deleted the feat/add-android-gha-pr-ci branch June 18, 2024 14:07
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,778 -16,454
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,462 -16,440
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 01f7ab8
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants