Add unit tests for CompositeBackgroundDrawable layer ordering optimization
#47913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66381515 |
jorge-cab
force-pushed
the
export-D66381515
branch
from
ebf47d4 to
390d5b1
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Nov 22, 2024
…ization (facebook#47913) Summary: CompositeBackgroundDrawable has some logic for inserting the layers that are not set through the constructor. This unit test makes sure they are being properly ordered. Differential Revision: D66381515
|
This pull request was exported from Phabricator. Differential Revision: D66381515 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Nov 25, 2024
…ization (facebook#47913) Summary: CompositeBackgroundDrawable has some logic for inserting the layers that are not set through the constructor. This unit test makes sure they are being properly ordered. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66381515
jorge-cab
force-pushed
the
export-D66381515
branch
from
390d5b1 to
39f5226
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66381515 |
…ization (facebook#47913) Summary: CompositeBackgroundDrawable has some logic for inserting the layers that are not set through the constructor. This unit test makes sure they are being properly ordered. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66381515
jorge-cab
force-pushed
the
export-D66381515
branch
from
39f5226 to
82da38a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66381515 |
|
This pull request has been merged in 96e66e7. |
|
This pull request was successfully merged by @jorge-cab in 96e66e7 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: CompositeBackgroundDrawable has some logic for inserting the layers that are not set through the constructor. This unit test makes sure they are being properly ordered.
Differential Revision: D66381515