Refactor utility to run buck2 commands as a method to run arbitrary commands #48370
+184
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 23, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
789ef76 to
4f47991
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 23, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
4f47991 to
bf596ee
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 27, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
bf596ee to
9d84329
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 27, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
9d84329 to
74c9652
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 1, 2025
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
74c9652 to
9ef9f6f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 2, 2025
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
9ef9f6f to
4516edb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
Differential Revision: D67549203
Differential Revision: D67759729
Differential Revision: D67602299
Differential Revision: D67600610
Differential Revision: D67600616
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
4516edb to
3c90667
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
|
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
force-pushed
the
export-D67600611
branch
from
3c90667 to
94d763b
Compare
|
This pull request has been merged in 8f096ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Small refactor in preparation for async commands with streaming.
Differential Revision: D67600611