Further optimizations for event dispatching #48426
Open
+1,946
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
rubennorte
force-pushed
the
export-D67751821
branch
from
f4d024a to
07d8776
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
rubennorte
force-pushed
the
export-D67751821
branch
from
07d8776 to
8bde8c3
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
rubennorte
force-pushed
the
export-D67751821
branch
from
8bde8c3 to
db06b82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
rubennorte
force-pushed
the
export-D67751821
branch
from
db06b82 to
587cc1e
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 4, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
rubennorte
force-pushed
the
export-D67751821
branch
from
587cc1e to
a683051
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 4, 2025
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
Summary: Changelog: [internal] This implements a (mostly) spec-compliant version of the [`Event`](https://dom.spec.whatwg.org/#interface-event) and [`EventTarget`](https://dom.spec.whatwg.org/#interface-eventtarget) Web interfaces. It does not implement legacy methods in either of the interfaces, and ignores the parts of the spec that are related to Web-specific quirks (shadow roots, re-mapping of animation events with webkit prefixes, etc.). IMPORTANT: This only creates the interfaces and does not expose them externally yet (no `Event` or `EventTarget` in the global scope). Differential Revision: D67738145
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
…n of ReadOnlyNode (facebook#48427) Summary: Changelog: [internal] The `ReactNativeElement` class was refactored for performance reasons, and the current implementation does **NOT** call `super()`, and it inlines the parent constructor instead. When it eventually extends `EventTarget`, things won't work as expected because the existing `EventTarget` implementation has constructor dependencies. This refactors the current implementation of `EventTarget` to eliminate those constructor side-effects, and eliminates the constructor altogether. This breaks encapsulation, but it has some positive side-effects on performance: 1. Creating `EventTarget` instances is faster because it has no constructor logic. 2. Improves memory by not creating maps to hold the event listeners if no event listeners are ever added to the target (which is very common). 3. Improves the overall runtime performance of the methods in the class by migrating away from private methods (which are known to be slow on the babel transpiled version we're currently using). Extra: it also simplifies making window/the global scope implement the EventTarget interface :) Differential Revision: D67758408
Summary: Changelog: [internal] This improves the performance of DOM `Event` interface implementation by migrating away from private fields. Differential Revision: D67751821
rubennorte
force-pushed
the
export-D67751821
branch
from
a683051 to
7d02cd5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67751821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This improves the performance of DOM
Eventinterface implementation by migrating away from private fields.Differential Revision: D67751821