Add a few more tests to ReactNativeElement #48428
Open
+1,921
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
force-pushed
the
export-D67738147
branch
from
1a904c4 to
a4fb987
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
force-pushed
the
export-D67738147
branch
from
a4fb987 to
95e7a8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
force-pushed
the
export-D67738147
branch
from
95e7a8b to
dc6dc8c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 4, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
force-pushed
the
export-D67738147
branch
from
dc6dc8c to
55e8407
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 4, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 4, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 5, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
Summary: Changelog: [internal] This implements a (mostly) spec-compliant version of the [`Event`](https://dom.spec.whatwg.org/#interface-event) and [`EventTarget`](https://dom.spec.whatwg.org/#interface-eventtarget) Web interfaces. It does not implement legacy methods in either of the interfaces, and ignores the parts of the spec that are related to Web-specific quirks (shadow roots, re-mapping of animation events with webkit prefixes, etc.). IMPORTANT: This only creates the interfaces and does not expose them externally yet (no `Event` or `EventTarget` in the global scope). Differential Revision: D67738145
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
rubennorte
force-pushed
the
export-D67738147
branch
from
55e8407 to
251c487
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67738147 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 5, 2025
Summary: Changelog: [internal] Adding a few more tests for `ReactNativeElement` for symmetry with future tests for when it implements `EventTarget`. Differential Revision: D67738147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Adding a few more tests for
ReactNativeElementfor symmetry with future tests for when it implementsEventTarget.Differential Revision: D67738147