Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding stdlib #48468

Closed
wants to merge 4 commits into from
Closed

Avoid adding stdlib #48468

wants to merge 4 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Jan 3, 2025

Summary:
Clang will add this code by default at the preprocessor phase. I'd observed a difference in output on sandcastle where it didn't include stdlib by default.

This stops stdlib being included locally. It isn't important wrt tracking user API changes.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D67793848

blakef and others added 4 commits January 3, 2025 02:12
Summary: This is the current output of running the api snapshotting tool.  I've also shown some test examples that show how trivial changes affect the API file.

Differential Revision: D67713415
Summary:
Adding CI support will require executing through buck.  Sandboxing means the package has to be well-formed to work, so this cleans up some earlier mess.

- yarn workspace
- check-api.sh to configure the environment correctly when running form sandcastle
- explicity dependencies in our package.json

This is the first step

Changelog: [Internal]

Differential Revision: D67726588
Summary:
We can only specify `hg` as a dependency, so have to use it in our shell script.

Changelog: [Internal]

Differential Revision: D67718641
Summary:
Clang will add this code by default at the preprocessor phase. I'd observed a difference in output on sandcastle where it didn't include `stdlib` by default.

This stops `stdlib` being included locally.  **It isn't important wrt tracking user API changes.**

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D67793848
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67793848

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6d85c7c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants