-
Notifications
You must be signed in to change notification settings - Fork 47.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[compiler] Switch to esbuild (#31963)
This migrates the compiler's bundler to esbuild instead of rollup. Unlike React, our bundling use cases are far simpler since the majority of our packages are meant to be run on node. Rollup was adding considerable build time overhead whereas esbuild remains fast and has all the functionality we need out of the box. ### Before ``` time yarn workspaces run build yarn workspaces v1.22.22 > babel-plugin-react-compiler yarn run v1.22.22 $ rimraf dist && rollup --config --bundleConfigAsCjs src/index.ts → dist/index.js... (!) Circular dependencies # ... created dist/index.js in 15.5s ✨ Done in 16.45s. > eslint-plugin-react-compiler yarn run v1.22.22 $ rimraf dist && rollup --config --bundleConfigAsCjs src/index.ts → dist/index.js... (!) Circular dependencies # ... created dist/index.js in 9.1s ✨ Done in 10.11s. > make-read-only-util yarn run v1.22.22 warning package.json: No license field $ tsc ✨ Done in 1.81s. > react-compiler-healthcheck yarn run v1.22.22 $ rimraf dist && rollup --config --bundleConfigAsCjs src/index.ts → dist/index.js... (!) Circular dependencies # ... created dist/index.js in 8.7s ✨ Done in 10.43s. > react-compiler-runtime yarn run v1.22.22 $ rimraf dist && rollup --config --bundleConfigAsCjs src/index.ts → dist/index.js... (!) src/index.ts (1:0): Module level directives cause errors when bundled, "use no memo" in "src/index.ts" was ignored. # ... created dist/index.js in 1.1s ✨ Done in 1.82s. > snap yarn run v1.22.22 $ rimraf dist && concurrently -n snap,runtime "tsc --build" "yarn --silent workspace react-compiler-runtime build --silent" $ rimraf dist && rollup --config --bundleConfigAsCjs --silent [runtime] yarn --silent workspace react-compiler-runtime build --silent exited with code 0 [snap] tsc --build exited with code 0 ✨ Done in 5.73s. ✨ Done in 47.30s. yarn workspaces run build 75.92s user 5.48s system 170% cpu 47.821 total ``` ### After ``` time yarn workspaces run build yarn workspaces v1.22.22 > babel-plugin-react-compiler yarn run v1.22.22 $ rimraf dist && scripts/build.js ✨ Done in 1.02s. > eslint-plugin-react-compiler yarn run v1.22.22 $ rimraf dist && scripts/build.js ✨ Done in 0.93s. > make-read-only-util yarn run v1.22.22 warning package.json: No license field $ rimraf dist && scripts/build.js ✨ Done in 0.89s. > react-compiler-healthcheck yarn run v1.22.22 $ rimraf dist && scripts/build.js ✨ Done in 0.58s. > react-compiler-runtime yarn run v1.22.22 $ rimraf dist && scripts/build.js ✨ Done in 0.48s. > snap yarn run v1.22.22 $ rimraf dist && concurrently -n snap,runtime "tsc --build" "yarn --silent workspace react-compiler-runtime build" $ rimraf dist && scripts/build.js [runtime] yarn --silent workspace react-compiler-runtime build exited with code 0 [snap] tsc --build exited with code 0 ✨ Done in 4.69s. ✨ Done in 9.46s. yarn workspaces run build 9.70s user 0.99s system 103% cpu 10.329 total ``` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31963). * #31964 * __->__ #31963 * #31962
- Loading branch information
Showing
20 changed files
with
515 additions
and
654 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 0 additions & 72 deletions
72
compiler/packages/babel-plugin-react-compiler/rollup.config.js
This file was deleted.
Oops, something went wrong.
61 changes: 61 additions & 0 deletions
61
compiler/packages/babel-plugin-react-compiler/scripts/build.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| const esbuild = require('esbuild'); | ||
| const yargs = require('yargs'); | ||
| const path = require('path'); | ||
|
|
||
| const argv = yargs(process.argv.slice(2)) | ||
| .options('w', { | ||
| alias: 'watch', | ||
| default: false, | ||
| type: 'boolean', | ||
| }) | ||
| .parse(); | ||
|
|
||
| const config = { | ||
| entryPoints: [path.join(__dirname, '../src/index.ts')], | ||
| outfile: path.join(__dirname, '../dist/index.js'), | ||
| bundle: true, | ||
| external: ['@babel/types'], | ||
| format: 'cjs', | ||
| platform: 'node', | ||
| banner: { | ||
| js: `/** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @lightSyntaxTransform | ||
| * @noflow | ||
| * @nolint | ||
| * @preventMunge | ||
| * @preserve-invariant-messages | ||
| */ | ||
| "use no memo";`, | ||
| }, | ||
| }; | ||
|
|
||
| async function main() { | ||
| if (argv.w) { | ||
| const ctx = await esbuild.context(config); | ||
| await ctx.watch(); | ||
| console.log('watching for changes...'); | ||
| } else { | ||
| await esbuild.build({ | ||
| sourcemap: true, | ||
| minify: false, | ||
| ...config, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| main(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 0 additions & 78 deletions
78
compiler/packages/eslint-plugin-react-compiler/rollup.config.js
This file was deleted.
Oops, something went wrong.
67 changes: 67 additions & 0 deletions
67
compiler/packages/eslint-plugin-react-compiler/scripts/build.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| const esbuild = require('esbuild'); | ||
| const yargs = require('yargs'); | ||
| const path = require('path'); | ||
|
|
||
| const argv = yargs(process.argv.slice(2)) | ||
| .options('w', { | ||
| alias: 'watch', | ||
| default: false, | ||
| type: 'boolean', | ||
| }) | ||
| .parse(); | ||
|
|
||
| const config = { | ||
| entryPoints: [path.join(__dirname, '../src/index.ts')], | ||
| outfile: path.join(__dirname, '../dist/index.js'), | ||
| bundle: true, | ||
| external: [ | ||
| '@babel/core', | ||
| '@babel/plugin-proposal-private-methods', | ||
| 'hermes-parser', | ||
| 'zod', | ||
| 'zod-validation-error', | ||
| ], | ||
| format: 'cjs', | ||
| platform: 'node', | ||
| banner: { | ||
| js: `/** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @lightSyntaxTransform | ||
| * @noflow | ||
| * @nolint | ||
| * @preventMunge | ||
| * @preserve-invariant-messages | ||
| */ | ||
| "use no memo";`, | ||
| }, | ||
| }; | ||
|
|
||
| async function main() { | ||
| if (argv.w) { | ||
| const ctx = await esbuild.context(config); | ||
| await ctx.watch(); | ||
| console.log('watching for changes...'); | ||
| } else { | ||
| await esbuild.build({ | ||
| sourcemap: true, | ||
| minify: false, | ||
| ...config, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| main(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.