Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure passive effects are flushed after a suspended commit resolves #31858

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure passive effects are flushed after a suspended commit resolves #31858

wants to merge 3 commits into from
+43 −0

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 19, 2024 •
edited
Loading

Summary

ensureRootIsScheduled will bail out of flushing passive effects if it thinks the commit is suspended. So we need to make sure we clear the cancelPendingcommit callback since we use that to check if a commit is suspended.

How did you test this change?

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:27pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 19, 2024
@react-sizebot
Copy link

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against d94334a

@eps1lon eps1lon changed the title Turn off enableYieldingBeforePassive Ensure passive effects are flushed after a suspended commit resolves Dec 19, 2024
@eps1lon eps1lon mentioned this pull request Dec 19, 2024
Merged
@eps1lon eps1lon requested a review from sebmarkbage December 19, 2024 15:35
@eps1lon eps1lon marked this pull request as ready for review December 19, 2024 15:35
sebmarkbage
sebmarkbage approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sketchy but ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @react-sizebot @sebmarkbage @facebook-github-bot