DevTools: fix initial host instance selection #31892
Open
+37
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
force-pushed
the
react-devtools/fix-initial-element-selection
branch
from
6c8eb72 to
7bb5c80
Compare
|
Do we know why/when this regressed? |
hoxyq
force-pushed
the
react-devtools/fix-initial-element-selection
branch
from
7bb5c80 to
be4a4cc
Compare
Probably in #27215, by looking at a difference around |
|
I will double-check if we can relatively easily add some Playwright test for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #31342
This fixes RDT behaviour when some DOM element was pre-selected in built-in browser's Elements panel, and then Components panel of React DevTools was opened for the first time. With this change, React DevTools will correctly display the initial state of the Components Tree with the corresponding React Element (if possible) pre-selected.
Previously, we would only subscribe listener when
TreeContextis mounted, but this only happens when user opens one of React DevTools panels for the first time. With this change, we keep state insideStore, which is created when Browser DevTools are opened. Later,TreeContextwill use it for initial state value.Planned next changes:
inspectedElementIDandselectedElementID, I have no idea why we need both.AutoSizerrendering a blank container.