Fix missing import for performance from perf_hooks in runner.ts

[DrHazemAli]

Summary

I stumbled upon a critical issue in the runner.ts file within the React compiler's snap package. The performance object was being used in the onChange function to track how long certain operations take, but it wasn't imported from Node.js's perf_hooks module. This small oversight caused a ReferenceError, which messed up our performance measurements and led to some unexpected runtime crashes.

Motivation

Accurate performance tracking is super important for ensuring our compiler runs efficiently and reliably. Without importing performance from perf_hooks, every call to performance.now() throws a ReferenceError, making it impossible to measure execution times. This not only hampers our ability to debug and optimize but also affects the overall stability of the test runner.

Changes Made

• Added Import Statement: Introduced import { performance } from 'perf_hooks'; at the top of runner.ts to ensure the performance object is correctly referenced.

 import { performance } from 'perf_hooks';

By implementing the import, performance.now() works as intended, accurately measuring execution time.

Feel free to reach out to me for further details.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2024 9:20am

[facebook-github-bot]

Hi @DrHazemAli!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!