[Fiber] Refactor Commit Phase into Separate Functions for Before Mutation/Mutation/Layout #31930
+178
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an unusual flag that doesn't serve a special return value. We can just use the global flag and reset it before the next mutation phase. Unlike focusedInstanceHandle this doesn't leak any memory in the meantime.
We're already setting the update priority around user space code.
The execution scope of the commit isn't as useful for profiling information.
This aligns it with passive effects. We can cancel these using the timeoutHandle or cancelPendingCommit. We should never run a commit function that was cancelled. We can check these to determine whether there are any pending commits.
Because ReactFiberLane is imported for its constants it cannot depend on the config.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Dec 28, 2024
| @@ -744,6 +744,7 @@ describe('ReactDeferredValue', () => { | |||
| </Container>, | |||
| ); | |||
| // We should switch to pre-rendering the new preview. | |||
| await waitForPaint([]); | |||
There was a problem hiding this comment.
This happens because the requestPaint() is now unconditional even if there weren't any effects. Which doesn't really hurt anything since it's actually a noop in anything but tests and should probably go away.
sebmarkbage
commented
Dec 29, 2024
| @@ -3460,7 +3471,8 @@ function commitRootImpl( | |||
| } | |||
| } | |||
|
|
|||
| onCommitRootDevTools(finishedWork.stateNode, renderPriorityLevel); | |||
There was a problem hiding this comment.
This one is a bit strange because the profiler in devtools tracks the priority level that the commit phase is running in rather than what priority was rendered and then committed. I think the idea is that it would be running in the scheduler priority of the render but that's not necessarily the case for the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #31922.
This is doing some general clean up to be able to split the commit root three phases into three separate async steps.