Add index_select AIT converter #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50119460 |
Summary: Previously with the `permute` ops, we could have run into an edge case when the input to the permute op is a model input. Apparently, zero-size PT tensors return `nullptr` as `.data_ptr()`. This has led to an error in the permute ops' back-end which validates the input pointers to be non-NULL. In this diff, an early exit condition is added to all permute ops' back-end before the input pointer validation. This remediates the error from the edge case described above. Differential Revision: https://internalfb.com/D50118462 fbshipit-source-id: c68a5e84ab046856cde0c698c32aa8475acae90e
Summary: ATT Differential Revision: D50120201 fbshipit-source-id: 5d893dfad346418f274a28a638193aa2bd2fe848
Summary: Pull Request resolved: facebookincubator#947 `index_select` op has been [available](https://github.com/facebookincubator/AITemplate/blob/main/python/aitemplate/compiler/ops/tensor/index_select.py) in AIT for a while, but we never had an fx2ait converter for it. This diff adds one. Differential Revision: D50119460 fbshipit-source-id: ba4331ce124a08fe46b7c90b90aa58c412da4981
|
This pull request was exported from Phabricator. Differential Revision: D50119460 |
aakhundov
force-pushed
the
export-D50119460
branch
from
0333b5e to
3d8841b
Compare
|
This pull request has been merged in 9452d5c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
index_selectop has been available in AIT for a while, but we never had an fx2ait converter for it. This diff adds one.Differential Revision: D50119460