docs: Adding async data cache configs and ssd cache documentation #11429
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
minhancao
changed the title
minhancao
force-pushed
the
ssd_cache_doc
branch
from
a4cfbd1 to
be3fa99
Compare
|
@majetideepak Can you review this PR when you can? Thanks! |
minhancao
force-pushed
the
ssd_cache_doc
branch
from
524893b to
a1de59d
Compare
| - Min SSD savable (in-memory) cache space to start writing SSD savable cache entries into SSD cache. NOTE: we only write to SSD cache when both above conditions are satisfied. | ||
| * - async-cache-persistence-interval | ||
| - string | ||
| - 0s |
There was a problem hiding this comment.
In the explanation do we need to add the allowed units to be specified? Is this mentioned in other configs that use duration units?
There was a problem hiding this comment.
Will add units has to be in seconds here.
There was a problem hiding this comment.
The unit is part of the string and we can see it is in seconds. But we would allow time based units like hour, day etc to be used as well. Not just seconds and we want to mention this in the description what they are.
There was a problem hiding this comment.
Added
The following time units are supported: ns, us, ms, s, m, h, d.
Reference: https://github.com/facebookincubator/velox/blob/main/velox/common/config/Config.cpp#L82
minhancao
changed the title
minhancao
force-pushed
the
ssd_cache_doc
branch
from
d703bb3 to
dd244bf
Compare
|
@czentgr to re-review |
Add async data cache configs and ssd cache documentation.
Add instructions on how to setup btrfs filesystem for SSD usage on AWS worker machines of Linux OS.