refactor: TopNRowNumber::getOutputFromMemory loop #11440
+49
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
aditi-pandit
force-pushed
the
topn_output
branch
3 times, most recently
from
6d65173 to
af1d2b1
Compare
aditi-pandit
changed the title
aditi-pandit
force-pushed
the
topn_output
branch
from
af1d2b1 to
12b66d3
Compare
aditi-pandit
force-pushed
the
topn_output
branch
from
12b66d3 to
de1daba
Compare
|
It would be nice to get @mbasmanova or @xiaoxmeng review on this (I'm not very familiar with this operator). |
aditi-pandit
changed the title
aditi-pandit
changed the title
aditi-pandit
force-pushed
the
topn_output
branch
from
de1daba to
fa14cfc
Compare
aditi-pandit
force-pushed
the
topn_output
branch
from
fa14cfc to
9e32bd0
Compare
|
@xiaoxmeng : Hi Meng, Pinging for review. Please let me know if you have any questions about this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getOutputFromMemory loop first output the remainder of rows (if any) from the current partition. If there was still space on the output buffer, then it went into a loop trying to add as many partitions (some with all rows in entirety and a last partial one possibly). The code is simplified to just a loop that carries forward from the current partition to fill output rows.
The priority queue in the TopNRowNumber partitions pops rows in reverse order of row number. The old code maintained a remainingRowsInPartition_ variable that was used in some odd ways to compute the 'start' rowNumber for each output block from a partition. This is not needed. The partition.rows.size() can be used simply to get the correct row numbers.
Remove the un-necessary currentPartition() function as a result.