feat: Add query trace TaskRunner #11927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
duanmeng
force-pushed
the
task_runner
branch
2 times, most recently
from
6d0fbe2 to
ce18de9
Compare
duanmeng
requested review from
xiaoxmeng
and removed request for
majetideepak and
assignUser
duanmeng
force-pushed
the
task_runner
branch
2 times, most recently
from
d418eb8 to
56befee
Compare
xiaoxmeng
reviewed
Dec 30, 2024
xiaoxmeng
reviewed
Dec 30, 2024
| @@ -325,6 +327,89 @@ TEST_F(HashJoinReplayerTest, partialDriverIds) { | |||
| faultyFs->clearFileFaultInjections(); | |||
| } | |||
|
|
|||
| TEST_F(HashJoinReplayerTest, runner) { | |||
There was a problem hiding this comment.
Add runner test case for all the other operator types in followup? Thanks!
velox/tool/trace/TraceTaskRunner.h
Outdated
| static std::shared_ptr<RowVector> copy( | ||
| const std::vector<RowVectorPtr>& results); | ||
|
|
||
| inline static std::atomic<uint64_t> cursorQueryId_ = 0; |
There was a problem hiding this comment.
s/cursorQueryId_/traceReplayQueryId_/
There was a problem hiding this comment.
It is unused, I've removed it.
duanmeng
force-pushed
the
task_runner
branch
from
56befee to
f67fa34
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 7fdb321. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a query trace TaskRunner to execute the replay task replacing
AssertQueryBuilder.Use a flag named
copy_resultsto control whether to copy the replay result (used in UT).