fix: Avoid running the fuzzer if there are no functions to fuzz #11933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67153128 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 22, 2024
…bookincubator#11933) Summary: There are edge cases when the input to the fuzzer results in no signatures to fuzz due to combination of skipped functions and skipped input types. This causes the fuzzer to fail when it tries to generate an expression, specifically failing in `ExpressionFuzzer::fuzzReturnType()`, at VELOX_CHECK(!signatures_.empty(), "No function signature available.");. Instead of failing the fuzzer at fuzzing time, let's exit the fuzzer with a warning that there were no functions to even fuzz. Differential Revision: D67153128
xiaoxmeng
approved these changes
Jan 2, 2025
…bookincubator#11933) Summary: There are edge cases when the input to the fuzzer results in no signatures to fuzz due to combination of skipped functions and skipped input types. This causes the fuzzer to fail when it tries to generate an expression, specifically failing in `ExpressionFuzzer::fuzzReturnType()`, at VELOX_CHECK(!signatures_.empty(), "No function signature available.");. Instead of failing the fuzzer at fuzzing time, let's exit the fuzzer with a warning that there were no functions to even fuzz. Reviewed By: xiaoxmeng Differential Revision: D67153128
yuandagits
force-pushed
the
export-D67153128
branch
from
02a3349 to
abb8bf3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67153128 |
|
This pull request has been merged in fa95c4e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are edge cases when the input to the fuzzer results in no signatures to fuzz due to combination of skipped functions and skipped input types. This causes the fuzzer to fail when it tries to generate an expression, specifically failing in
ExpressionFuzzer::fuzzReturnType(), at VELOX_CHECK(!signatures_.empty(), "No function signature available.");.Instead of failing the fuzzer at fuzzing time, let's exit the fuzzer with a warning that there were no functions to even fuzz.
Differential Revision: D67153128