feat: Support Spark explode outer #11954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@pedroerp @rui-mo @jinchengchenghh @PHILO-HE Can you please help review this? |
rui-mo
reviewed
Dec 27, 2024
| @@ -106,6 +107,9 @@ class Unnest : public Operator { | |||
| const RowRange& rowRange, | |||
| std::vector<VectorPtr>& outputs); | |||
|
|
|||
| template <bool isOuter> | |||
| void countMaxNumElementsPerRow(int32_t size); | |||
There was a problem hiding this comment.
Perhaps document this function and the 'isOuter' template parameter.
| // is_outer = false | ||
| auto op1 = PlanBuilder().values({vector}).unnest({"c0"}, {"c1"}, std::nullopt, false /* is_outer */).planNode(); | ||
| auto params1 = makeCursorParameters(op1); | ||
| auto expected1 = makeRowVector({ |
There was a problem hiding this comment.
nit: can we have 'op', 'params', 'expected' and reuse them in the other test cases?
| UnnestNode( | ||
| const PlanNodeId& id, | ||
| std::vector<FieldAccessTypedExprPtr> replicateVariables, | ||
| std::vector<FieldAccessTypedExprPtr> unnestVariables, | ||
| const std::vector<std::string>& unnestNames, | ||
| const std::optional<std::string>& ordinalityName, | ||
| const PlanNodePtr& source); | ||
| const PlanNodePtr& source, | ||
| const bool isOuter); |
There was a problem hiding this comment.
nit: drop const when passing by value.
|
|
||
| createDuckDbTable({vector}); | ||
|
|
||
| // is_outer = false |
| createDuckDbTable({vector}); | ||
|
|
||
| // is_outer = false | ||
| auto op1 = PlanBuilder().values({vector}).unnest({"c0"}, {"c1"}, std::nullopt, false /* is_outer */).planNode(); |
There was a problem hiding this comment.
ditto, perhaps use the style like below.
/*isOuter=*/false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the explode/posexplode with outer semantic. Unlike explode/posexplode, if the array/map is null or empty then null is produced.
Spark doc: https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.explode_outer.html