-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Register write filesink for abfs connector #11973
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for meta-velox canceled.
|
When creating an instance of |
UT failure is not related to this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhli1142015 Thanks for adding the tests. A couple of comments.
@@ -23,6 +23,43 @@ | |||
|
|||
namespace facebook::velox::filesystems { | |||
|
|||
std::unique_ptr<AzureDataLakeFileClient> AbfsConfig::fakeWriteClient_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use test
instead of fake
here and elsewhere.
@@ -92,6 +93,12 @@ class AbfsConfig { | |||
return authorityHost_; | |||
} | |||
|
|||
/// Test only. | |||
static void registerFakeWriteFileClient( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say createTestWriteFileClient
?
/// Test only. | ||
static void registerFakeWriteFileClient( | ||
std::unique_ptr<AzureDataLakeFileClient> fakeClient) { | ||
fakeWriteClient_ = std::move(fakeClient); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For safety and simplicity, let's check and initialize the singleton testWriteClient_
here.
No description provided.