fix: Fix arbitration fuzzer failure #12005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67770533 |
tanjialiang
pushed a commit
to tanjialiang/velox-1
that referenced
this pull request
Jan 2, 2025
Summary: Arbitration fuzzer fails because concurrent access of the rng_ member variable from multiple threads. This change fixes it by protecting rng_ with a mutex lock. Differential Revision: D67770533
tanjialiang
force-pushed
the
export-D67770533
branch
from
5f94233 to
755ecbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67770533 |
Summary: Arbitration fuzzer fails because concurrent access of the rng_ member variable from multiple threads. This change fixes it by protecting rng_ with a mutex lock. Differential Revision: D67770533
tanjialiang
force-pushed
the
export-D67770533
branch
from
755ecbc to
75528f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67770533 |
xiaoxmeng
approved these changes
Jan 2, 2025
zation99
approved these changes
Jan 2, 2025
|
This pull request has been merged in cd6431a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Arbitration fuzzer fails because concurrent access of the rng_ member variable from multiple threads. This change fixes it by protecting rng_ with a mutex lock.
Differential Revision: D67770533