fix mypy issues

facebookresearch · Feb 22, 2024 · b0d3138 · b0d3138
1 parent cd55e17
commit b0d3138
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/hydra/_internal/core_plugins/importlib_resources_config_source.py b/hydra/_internal/core_plugins/importlib_resources_config_source.py
@@ -38,8 +38,10 @@ def _read_config(self, res: Any) -> ConfigResult:
             header_text = f.read(512)
             if isinstance(header_text, bytes):
                 # if header is bytes, utf-8 decode (zipfile path)
-                header_text = header_text.decode("utf-8")
-            header = ConfigSource._get_header_dict(header_text)
+                header_text_str = header_text.decode("utf-8")
+            else:
+                header_text_str = header_text
+            header = ConfigSource._get_header_dict(header_text_str)
             f.seek(0)
             cfg = OmegaConf.load(f)
             return ConfigResult(

diff --git a/tests/test_config_repository.py b/tests/test_config_repository.py
@@ -201,10 +201,7 @@ def test_restore_singleton_state_hack() -> None:
 def test_importlib_resource_load_zip_path() -> None:
     config_source = ImportlibResourcesConfigSource(provider="foo", path="pkg://bar")
     conf = config_source._read_config(
-        zipfile.Path(  # type: ignore
-            "hydra/test_utils/configs/conf.zip",
-            "config.yaml",
-        )
+        zipfile.Path("hydra/test_utils/configs/conf.zip", "config.yaml")
     )
     assert conf.config == {"foo": "bar"}
     assert conf.header == {"package": None}