Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose installed binaries under PATH for custom packages #45

Conversation

isidentical
Copy link
Collaborator

@isidentical isidentical commented Nov 14, 2022

Requires #44 first!

@isidentical isidentical marked this pull request as ready for review November 14, 2022 16:10
@isidentical isidentical requested a review from a team November 14, 2022 16:10
@isidentical isidentical force-pushed the batuhan/fea-543-re-calculate-path-variable-for-binaries branch 2 times, most recently from dec4b1b to 74f7018 Compare November 14, 2022 17:45
@isidentical isidentical force-pushed the batuhan/fea-543-re-calculate-path-variable-for-binaries branch from 74f7018 to d244c43 Compare November 15, 2022 17:01
Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATL: So this is to enable users to have access to any system package in the environments created? Normally added through conda

src/isolate/connections/_local/_base.py Show resolved Hide resolved
@isidentical
Copy link
Collaborator Author

So this is to enable users to have access to any system package in the environments created? Normally added through conda

Yep! More like any binary package they have in particular environments, since they already did have access for system packages (the PATH was inherited from the parent process's session in the past, which would mean they had access to everything that the initial shell does). One example is fal, e.g. if we install fal in an isolate environment (not just conda, but virtualenv too) and try to do a subprocess.run(["fal"]) it now works (i don't think it did work in the past, since there were no fal executable in your PATH) since we expose it to your session.

@isidentical isidentical merged commit a9200d1 into fal-ai:main Nov 21, 2022
@isidentical isidentical deleted the batuhan/fea-543-re-calculate-path-variable-for-binaries branch November 21, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants