Use a different process for each device's grpc connection #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag6
reviewed
Jun 29, 2021
forch/device_report_client.py
Outdated
| break | ||
| try: | ||
| if not progress or self._convert_and_handle(mac, progress): | ||
| print('Progress complete for %s' % mac) |
There was a problem hiding this comment.
Debug prints left by mistake?
anurag6
approved these changes
Jun 29, 2021
grafnu
approved these changes
Jul 7, 2021
| @@ -50,30 +55,48 @@ def __init__(self, result_handler, target, unauth_vlan, tunnel_ip): | |||
|
|
|||
| def start(self): | |||
| """Start the client handler""" | |||
| grpc.channel_ready_future(self._channel).result(timeout=CONNECT_TIMEOUT_SEC) | |||
| self._stub = SessionServerStub(self._channel) | |||
| # Context may be set already | |||
There was a problem hiding this comment.
I'm not sure what to make of this comment. Can you expand it a bit or position it better? Is this to say that if the context is already set then this will throw a RuntimeError? If so, I'd either clarify that in the comment or move to the except clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC only maintains 1 single channel (connection to the k8s IBL) in each process so LB across all testing devices can't happen. This PR, with no functional change, ensures each device can have its own connection to the IBL for proper LB.