Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace onPopPage with onDidRemovePage in Navigator #125

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

refactor: replace onPopPage with onDidRemovePage in Navigator #125

wants to merge 6 commits into from

Conversation

yuruyuri16
Copy link

@yuruyuri16 yuruyuri16 commented Nov 22, 2024 •
edited
Loading

In Navigator, onPopPage method was deprecated after v3.16.0-17.0.pre. The suggested method is onDidRemovePage.

Status

READY

Breaking Changes

NO

Description

Change deprecated method to the new one.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Testing

@yuruyuri16 yuruyuri16 requested a review from felangel as a code owner November 22, 2024 17:31
@felangel felangel added the refactor Refactor an existing implementation label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel Awaiting requested review from felangel felangel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@yuruyuri16 yuruyuri16

Labels
refactor Refactor an existing implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuruyuri16 @felangel