Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved Hebrew stopwords #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TonySlon
Copy link

@TonySlon TonySlon commented Feb 1, 2024

improved and corrected Hebrew stopwords

@eklem
Copy link
Collaborator

eklem commented Feb 1, 2024

Hi @TonySlon, can you tell a little about the changes? What is wrong and what is it changed to?

@TonySlon
Copy link
Author

TonySlon commented Feb 1, 2024

Hi @eklem some words were written wrong, and I also added more stopwords which I think could be used

@eklem
Copy link
Collaborator

eklem commented Feb 1, 2024

Thanks! I was mostly wondering about those words that was written wrong. It seems they are two words (merged wrongly). But I don't think they will ever be removed from a text if that is true, because you add one and one word to the stopword library through and arrray and remove a word if it equals a stopword.

@TonySlon
Copy link
Author

TonySlon commented Feb 1, 2024

@eklem ok, I changed it to be one word in new commit

@eklem
Copy link
Collaborator

eklem commented Feb 2, 2024

Do you have a translation/meaning for the words (what they are changed to)?

@TonySlon
Copy link
Author

TonySlon commented Feb 5, 2024

'באיזומידה', - this one is never used like that, it has to be two separate words 'באיזו', 'מידה', . this is one example, but there are several words which are written not correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants