Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invert control of chat controls upstream #1902

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Dec 17, 2024

this PR improves the ergonomics of defining the chat component and binding it with the useChat hook, and in the process improve some UX glitches:

  1. align the radix versions across all packages to fix bugs related to popover/dialog focus scopes. (TODO: This needs to continuously be monitored, because it keeps breaking— causing autofocus problems)
  2. when typing, always scroll to the selected cmdk-item. this fixes a bug with the cmdk-item today where it doesn't scroll because it doesn't know that its children has been updated.
  3. wrapping the useChat inside of the component feels convoluted; in this PR i'm moving the useChat hook upstream (inverted) so that this can be refined/hot-swapped as needed— which better aligns with the goal of multiplexing across different llm providers and backend (i.e. trieve and vellum).

@abvthecity abvthecity marked this pull request as ready for review December 17, 2024 00:52
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 17, 2024 0:52am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 17, 2024 0:52am

@abvthecity abvthecity requested a review from dsinghvi as a code owner December 17, 2024 00:52
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 17, 2024 00:52 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 17, 2024 00:52 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 17, 2024 00:54 — with GitHub Actions Failure
Copy link

github-actions bot commented Dec 18, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 18, 2024

PR Preview

Copy link

github-actions bot commented Dec 18, 2024

Playwright test results

passed  95 passed
flaky  4 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  1 minute, 42 seconds
commit  d467f60

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.boundaryml.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cable.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.givechariot.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant