Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel tests and faster runners #499

Merged
merged 1 commit into from
Nov 20, 2024
Merged

parallel tests and faster runners #499

merged 1 commit into from
Nov 20, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Nov 7, 2024

fixes #498

@Stebalien
Copy link
Member Author

Ok, so... faster. But we don't have a 4x arm64 runner.

@Stebalien Stebalien marked this pull request as ready for review November 20, 2024 18:06
@Stebalien
Copy link
Member Author

The Linux x86 tests are down from 40m to 20m and the arm64 tests are down from 40m to 30m. Both should be faster but that requires improved caching (#505 #506).

@Stebalien Stebalien requested a review from BigLep November 20, 2024 18:39
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me?

I assume we're good to no longer have

--test-threads 1 and -p 1

?

Do we know what changed to allow us to not need this anymore (great that we don't). (No need to slow down to explain to me - I was just curious).

@Stebalien
Copy link
Member Author

I assume we're good to no longer have
--test-threads 1 and -p 1

Looking through history, that was added way back in 2019 (possibly before, it could have been ported from rust-fil-proofs-ffi). See 3de4c15. I'm guessing we may have been testing with GPUs at that point and couldn't use the same GPU from multiple threads? I'm not sure, but it doesn't seem necessary now and removing it makes everything faster.

@Stebalien Stebalien merged commit ea3143f into master Nov 20, 2024
5 checks passed
@Stebalien Stebalien deleted the steb/faster-ci branch November 20, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Build and test CGO bindings" unified CI run takes an hour+ on Linux
2 participants