Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local storage reservations fixes #11866

Merged
merged 10 commits into from
Apr 15, 2024
Merged

fix: local storage reservations fixes #11866

merged 10 commits into from
Apr 15, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 10, 2024

Related Issues

Proposed Changes

More debugging of accounting issues in the storage reservation mechanism in Curio.

  • This PR adds a lot more debug logging to storage reservation code
  • Fixes a bug in curio task storage where in some cases we'd release storage multiple times
    • Fixed with sync.once as other ways of fixing it would be either very complicated or would trade robustness in favour of sometimes maybe not releasing storage
  • Also a small drive-by fix which drops existing SDR layers on sdr restart - seems like this was one of the causes of corrupted sectors

Currently testing on my mainnet setup, seems to work very well so far

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k changed the title [wip] fix: local storage reservations fixes fix: local storage reservations fixes Apr 10, 2024
@magik6k magik6k marked this pull request as ready for review April 10, 2024 20:48
storage/paths/local.go Outdated Show resolved Hide resolved
storage/paths/local.go Show resolved Hide resolved
@magik6k magik6k requested a review from snadrus April 11, 2024 22:09
storage/paths/local.go Show resolved Hide resolved
@magik6k magik6k force-pushed the fix/storage-resv-debug branch from c89bd76 to 818910c Compare April 15, 2024 17:15
@magik6k magik6k requested a review from snadrus April 15, 2024 17:15
@snadrus snadrus merged commit bc43bd6 into master Apr 15, 2024
186 checks passed
@snadrus snadrus deleted the fix/storage-resv-debug branch April 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants