-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update text selection when toggling checkbox #441
Conversation
df73bcb
to
ce001ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 62 62
Lines 10630 10640 +10
=======================================
+ Hits 9380 9389 +9
- Misses 1250 1251 +1 ☔ View full report in Codecov by Sentry. |
b41905f
to
a044bb1
Compare
@Amir-P can you please review? |
c9fd3eb
to
ad0f7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like not notifying listeners is causing issues with undoing.
Steps to reproduce:
- Create a checklist
- Toggle it
- Press Cmd+Z
- Press Cmd +Z
Expected Behavior: After pressing Cmd +Z for the first time checklist should be unchecked and pressing Cmd +Z one more time reverts checklist creation.
Actual Behavior: After pressing Cmd +Z for the first time nothing happens and pressing Cmd +Z one more time reverts checklist creation.
Screen.Recording.2025-01-01.at.11.09.36.mov
Nice catch! |
ad0f7c3
to
aad38c6
Compare
aad38c6
to
f987e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
When toggling a checkbox the cursor is set at the offset of the checkbox's line start
Fixes issues addressed by PR #400