Fix: AutoExitBlockRule should escape indented blocks #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChizobaAmadi
changed the title
ChizobaAmadi
changed the title
Amir-P
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Hey @ChizobaAmadi , Thanks for contributing to Fleather!
Looks like you've based this branch on the fix/multi_level_different_list_type and brought those changes here too. Can you please fix that so that we can only review the changes regarding AutoExitBlockRule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
AutoExitBlockRuleunsets a block when the when the user enters two consecutive new line characters. This works for a single-level list but is not consistent with the behaviour of other editors for multi-level list. For example, the default IOS notes app unindents all blocks consecutively when new lines are inserted.What
AutoExitBlockRuleto check if we are in a nested level before and unindent else unset the block.Testing