-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update welcome message for A380X #90
Merged
benw202
merged 8 commits into
flybywiresim:staging
from
ExampleWasTaken:feat/380-welcome-msg
Nov 9, 2024
Merged
feat: update welcome message for A380X #90
benw202
merged 8 commits into
flybywiresim:staging
from
ExampleWasTaken:feat/380-welcome-msg
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Valastiri - Can you check how this reads? Thought I would loop you in to give this a check from a marketing point of view |
benw202
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of ideas. Feel free to reject!
Co-authored-by: BenW <[email protected]>
Awesome suggestions, thank you! |
pdellaert
approved these changes
Nov 5, 2024
benw202
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the A380X has been released, I think the server welcome-message should reflect that.
I pretty much just exchanged "A32NX" for "aircraft" but marketing may want to have a quick check. :)
Also, there is no
#a380x-support
channel on the staging server so the staging config, currently has no channel set for that.Test Results
Note that emojis are hardcoded to the FBW server so they don't show on my testing server.
Discord Username
examplewastaken