Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Import HAR API Requests into Workspace #158

Closed
wants to merge 8 commits into from

Conversation

opxdelwin
Copy link
Contributor

@opxdelwin opxdelwin commented Feb 23, 2024

This PR addresses the issue #122.

The developed code allows parsing of HAR files, enabling users to choose the requests they want to import via a dialog. Upon selection, the corresponding requests are created in the API Dash collection within the workspace.

Key Changes:

  • Added support for parsing HAR files.
  • Implemented a dialog interface for users to select requests for import.
  • Created functionality to generate corresponding requests in the API Dash collection.
  • Respective Tests
Video Demo
2024-02-23.12-36-32.mp4

This PR lays the foundation for seamlessly importing API requests from HAR files, enhancing the usability and flexibility of the application.

Tests will be added in subsequent commits to ensure the robustness and reliability of the newly introduced features.

Please review and provide feedback.

@opxdelwin
Copy link
Contributor Author

Regarding the tests, I'm planning to create a dir tests/dialogs/import and test HAR implementation there. Looking for alternative suggestions...

test/widget_test.dart Outdated Show resolved Hide resolved
@animator
Copy link
Member

Definitely a good start. I will review the PR and add my feedback.
Thanks!

@opxdelwin
Copy link
Contributor Author

Update
Split business logic into separate files, to improve project structure.
This means easy integration of future import/export file features.

2024-02-25.16-09-23.mp4

@opxdelwin opxdelwin requested a review from animator February 25, 2024 10:43
To fix tests, as they doesn't support File() implementation
@opxdelwin opxdelwin marked this pull request as ready for review February 25, 2024 12:27
@animator animator linked an issue Feb 25, 2024 that may be closed by this pull request
@opxdelwin opxdelwin mentioned this pull request Mar 9, 2024
4 tasks
@animator
Copy link
Member

On running the application and clicking Import, I am getting an error.
Platform: macOS

Screenshot 2024-03-15 at 8 36 40 PM

@opxdelwin
Copy link
Contributor Author

Will have a look

@animator
Copy link
Member

Any Updates?

@opxdelwin
Copy link
Contributor Author

Sorry @animator I haven't been working lately as the semester end is approaching.

I'll be on limited work force till April 23. I'm looking to work on my open issues during gsoc community bonding period.

Feel free to ping me if anything arises!

@animator
Copy link
Member

@opxdelwin no worries. Good luck for your exams!

@animator
Copy link
Member

The architecture needs to be improved as there is currently no separation between presentation layer, services, utilities, etc. Also, there are already existing reported issues.
A new PR can be raised after the approach & design is discussed in detail on the issue thread.

@animator animator closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing Requests from HAR file
2 participants