Introduce experimental fetchComposerDepsImpure
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fetchComposerDeps` works okay but since the fetching runs at evaluation time, it grinds Nix evaluator to a halt. As a bonus, we have a finer control over what is fetched so we can limit it to a shallow fetch. This patch adds an alternative implementation that moves the work to build time based on the experimental `impure-derivations` feature. Unfortunately, the feature needs to be enabled **in the daemon** and can only be used by other impure derivations. The repo derivation also will not be cached by Nix so everything will need to be re-fetched for every build.
jtojnar
commented
May 20, 2023
| @@ -84,6 +84,14 @@ This is a function that, for given source, returns a derivation with a Composer | |||
|
|
|||
| - Either `lockFile` containing an explicit path to `composer.lock` file, or `src`, which is the source directory/derivation containing the file. | |||
|
|
|||
| ### `c4.fetchComposerDepsImpure` | |||
There was a problem hiding this comment.
Maybe we should just re-use c4.fetchComposerDeps and change the implementation when passed __impure argument. We could even pass hash to get FOD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchComposerDepsworks okay but since the fetching runs at evaluation time, it grinds Nix evaluator to a halt.As a bonus, we have a finer control over what is fetched so we can limit it to a shallow fetch.
This patch adds an alternative implementation that moves the work to build time based on the experimental
impure-derivationsfeature.Unfortunately, the feature needs to be enabled in the daemon and can only be used by other impure derivations.
The repo derivation also will not be cached by Nix so everything will need to be re-fetched for every build.