Fixed crash due to selection of deleted entry in other pane #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you and sorry for taking so long to respond! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the bug:
If the same directory and the same file entry are selected in both panes, then the file entry in one of the two panes is deleted, the file entry in the other pane is still selected, which leads to a crash.
WadGadget crashes in the browser/browser.c function DrawInfoPane() line 512 with a segmentation fault (Due to directory_entry *ent = NULL).
Fix for the bug:
In the browser/actions.c function PerformDeleteNoConfirm(), the call to the function B_DirectoryPaneReselect(other_pane) is added to prevent the deleted entry from continuing to be selected in the other pane.