Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current time, grid and bars changes. #428

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

vipperxvr
Copy link

Ghaph shows current time as a vertical red line in hour, quarter day and half day view modes.
Grid tick position changed to match labels.
Bars start position now is calculated using minutes instead hours, giving more precision.
Changed the start position when scroll position is set as 'today'.

@agritheory
Copy link

@vipperxvr Can I help you get this merged by removing the conflicts?

@safwansamsudeen
Copy link
Collaborator

Yeah, if you can do that, that would be great. There's been a ton of changes since, though, which might make it hard.

@agritheory
Copy link

@safwansamsudeen I'd like to add a story / specimen to the index page that highlights that has data with minute-level precision, so that we can better understand and demonstrate those features. The current data being spread over many days doesn't help illustrate the feature.

@safwansamsudeen
Copy link
Collaborator

We're rebuilding the index page to be an interactive demo. You can wait for it to come out and then work, or push to the current version.

Anyway, fix the merge conflicts first, maybe?

(I'll check it, but I'm wondering if this PR is even necessary - you can just change the format string and do this, I think.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants