loongarch: add loongarch support #225
Conversation
CMakeLists.txt
Outdated
| message( STATUS "LoongArch64 lasx intrinsics disabled" ) | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Please only add the -mlasx -mlsx flags to the SSE41 SIMD files (same way as -mavx2 is handled). This can be done in source/Lib/vvdec/CMakeLists.txt
There was a problem hiding this comment.
I have made the modifications.
There was a problem hiding this comment.
Sorry to go back on it, but a colleagues had a good comment on this. Does longaarch64 mandate LASX and LSX? If so, yoru first solution was actually the better option. Could you let me know, and if it does mandate the vector extension, revert back to the first option? Thanks for the patch and sorry for the confusion
There was a problem hiding this comment.
When compiling 128-bit simd code, you need to add mlsx, and when compiling 256-bit simd code, you need to add mlasx. Based on the first solution, the relevant information regarding lasx has been removed.
HecaiYuan
force-pushed
the
master
branch
2 times, most recently
from
24e099f to
efef492
Compare
CMakeLists.txt
Outdated
| if( VVDEC_TARGET_ARCH STREQUAL "LOONGARCH64" ) | ||
| if( VVDEC_ENABLE_LOONGARCH64_LSX_SIMD ) | ||
| set_if_compiler_supports_flag( FLAG_mlsx -mlsx ) | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mlsx") |
There was a problem hiding this comment.
Did you mean to use the variable FLAG_mlsx? As in:
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${FLAG_mlsx}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${FLAG_mlsx}")There was a problem hiding this comment.
Other than that looks good to me. @K-os what do you think?
There was a problem hiding this comment.
Excuse me. I made a mistake here. It should be ${FLAG_mlsx}. @adamjw24
hi! @adamjw24 This patch provides support for Loongarch.