Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(dashtable_v2.test.jsx.snap): fix error #414

Closed
wants to merge 3 commits into from
Closed

ci(dashtable_v2.test.jsx.snap): fix error #414

wants to merge 3 commits into from

Conversation

lloydchang
Copy link
Contributor

Checklist:

Closes #413

@lloydchang lloydchang requested a review from a team as a code owner July 31, 2023 06:45
@lloydchang
Copy link
Contributor Author

lloydchang commented Jul 31, 2023 •
edited
Loading

@GuillermoFloresV @utsab @ngillux @sihambyte

Please review when your time permits.

This fixes the error that keeps appearing in npm run test via GitHub CI, even after #401 was merged.

Backstory is in #413

Thank you!

Expected behavior
No error.

Screenshots of no error — Expected behavior

Screen Shot 2023-07-30 at 11 53 25 PM Screen Shot 2023-07-30 at 11 53 29 PM

@lloydchang lloydchang closed this Aug 1, 2023
@lloydchang lloydchang deleted the patch-2 branch August 1, 2023 03:39
@lloydchang lloydchang mentioned this pull request Aug 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsab utsab utsab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error continues to happen in npm run test via GitHub CI
2 participants
@lloydchang @utsab