Migrate staging job to GitHub Actions; remove CircleCI #7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are officially at the end of the road for the CircleCI to GitHub Actions migration! This migrates the final job over and removes the manifest entirely. The staging credentials have already been configured by infra, all that was needed was adjusting some of the `$CIRCLE_` environment variables. I added a bit of output to aid future debugging. Fixes #6886.
leee
approved these changes
Aug 15, 2024
|
There are still some other places doing conditional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
We are officially at the end of the road for the CircleCI to GitHub Actions migration! This migrates the final job over and removes the manifest entirely.
The staging credentials have already been configured by infra, all that was needed was adjusting some of the
$CIRCLE_environment variables. I added a bit of output to aid future debugging.Fixes #6886.
Testing
Deployment
Any special considerations for deployment? n/a