Translations update from Hosted Weblate #809
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe recent updates in the Spook integration enhance translations for multiple languages, including Afrikaans, Greek, Finnish, Indonesian, Italian, Korean, Dutch, Polish, Swedish, and Chinese (Simplified and Traditional). The changes focus on refining error messages, improving clarity in component names, and expanding localization support. New translations fill existing gaps, while updates ensure precise translations and structured handling of user issues, resulting in a more intuitive experience across diverse languages. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- custom_components/spook/translations/el.json (5 hunks)
- custom_components/spook/translations/pl.json (1 hunks)
Additional comments not posted (2)
custom_components/spook/translations/pl.json (1)
174-175: New translation entry approved.The addition of the "homeassistant_number" translation entry is consistent with the existing structure and enhances localization support.
custom_components/spook/translations/el.json (1)
229-229: Translation updates approved.The updates to the Greek translations improve clarity and consistency, aligning well with the existing structure and tone.
Also applies to: 249-249, 253-253, 256-256, 287-287, 291-292, 295-295, 299-300, 303-304, 311-312, 323-324, 327-328
weblate
force-pushed
the
weblate-spook-integration
branch
from
0568c77 to
8282c89
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- custom_components/spook/translations/el.json (5 hunks)
- custom_components/spook/translations/pl.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- custom_components/spook/translations/el.json
Additional comments not posted (6)
custom_components/spook/translations/pl.json (6)
174-176: Translation approved for "homeassistant_number".The translation "Liczby" accurately reflects the English term "Numbers".
177-179: Translation approved for "homeassistant_cover".The translation "Osłony okienne" is an appropriate Polish term for "Window Covers".
180-182: Translation approved for "homeassistant_input_boolean".The translation "Wejścia logiczne" correctly conveys the meaning of "Input Booleans".
183-185: Translation approved for "homeassistant_input_button".The translation "Przyciski" accurately represents the English term "Buttons".
186-188: Translation approved for "homeassistant_siren".The translation "Syreny" correctly reflects the English term "Sirens".
189-190: Translation approved for "homeassistant_stt".The translation "Zamiana mowy na tekst" accurately conveys the concept of "Speech-to-Text".
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/ko.json (4 hunks)
Additional comments not posted (50)
custom_components/spook/translations/ko.json (50)
5-5: Translation for "homeassistant_siren" is accurate.The term "사이렌" correctly translates "siren" into Korean.
8-8: Translation for "homeassistant_water_heater" is accurate.The term "온수기" correctly translates "water heater" into Korean.
14-14: Translation for "homeassistant_light" is accurate.The term "조명" correctly translates "light" into Korean.
17-17: Translation for "homeassistant_input_number" is accurate.The term "숫자 입력" correctly translates "input number" into Korean.
23-23: Translation for "homeassistant_cover" is accurate.The term "차양" correctly translates "cover" into Korean.
26-26: Translation for "homeassistant_area" is accurate.The term "영역" correctly translates "area" into Korean.
32-32: Translation for "homeassistant_number" is accurate.The term "숫자" correctly translates "number" into Korean.
38-38: Translation for "homeassistant_tts" is accurate.The term "텍스트-음성 변환" correctly translates "text-to-speech" into Korean.
47-47: Translation for "homeassistant_input_boolean" is accurate.The term "참/거짓 입력" correctly translates "input boolean" into Korean.
53-53: Translation for "repairs_ignored_issues" is accurate.The term "무시된 문제" correctly translates "ignored issues" into Korean.
56-56: Translation for "homeassistant_humidifier" is accurate.The term "습도 조절기" correctly translates "humidifier" into Korean.
59-59: Translation for "homeassistant_update" is accurate.The term "업데이트" correctly translates "update" into Korean.
62-62: Translation for "homeassistant_persistent_notification" is accurate.The term "지속적인 알림" correctly translates "persistent notification" into Korean.
68-68: Translation for "homeassistant_input_datetime" is accurate.The term "날짜/시간 입력" correctly translates "input datetime" into Korean.
71-71: Translation for "homeassistant_weather" is accurate.The term "날씨" correctly translates "weather" into Korean.
74-74: Translation for "homeassistant_input_text" is accurate.The term "문자 입력" correctly translates "input text" into Korean.
77-77: Translation for "homeassistant_fan" is accurate.The term "팬" correctly translates "fan" into Korean.
80-80: Translation for "homeassistant_sun" is accurate.The term "태양" correctly translates "sun" into Korean.
83-83: Translation for "homeassistant_input_button" is accurate.The term "버튼 입력" correctly translates "input button" into Korean.
86-86: Translation for "homeassistant_climate" is accurate.The term "온도 조절기" correctly translates "climate" into Korean.
89-89: Translation for "homeassistant_person" is accurate.The term "사람" correctly translates "person" into Korean.
92-92: Translation for "homeassistant_stt" is accurate.The term "음성-텍스트 변환" correctly translates "speech-to-text" into Korean.
98-98: Translation for "homeassistant_date" is accurate.The term "날짜" correctly translates "date" into Korean.
101-101: Translation for "homeassistant_entities" is accurate.The term "구성요소" correctly translates "entities" into Korean.
104-104: Translation for "homeassistant_camera" is accurate.The term "카메라" correctly translates "camera" into Korean.
107-107: Translation for "homeassistant_input_select" is accurate.The term "선택 입력" correctly translates "input select" into Korean.
110-110: Translation for "homeassistant_select" is accurate.The term "선택" correctly translates "select" into Korean.
113-113: Translation for "repairs_active_issues" is accurate.The term "진행 중인 문제" correctly translates "active issues" into Korean.
116-116: Translation for "homeassistant_remote" is accurate.The term "리모트" correctly translates "remote" into Korean.
119-119: Translation for "homeassistant_device" is accurate.The term "장치" correctly translates "device" into Korean.
125-125: Translation for "homeassistant_air_quality" is accurate.The term "공기질" correctly translates "air quality" into Korean.
134-134: Translation for "homeassistant_lock" is accurate.The term "잠금장치" correctly translates "lock" into Korean.
137-137: Translation for "homeassistant_alarm_control_panel" is accurate.The term "알람 제어 패널" correctly translates "alarm control panel" into Korean.
140-140: Translation for "repairs_total_issues" is accurate.The term "총 문제" correctly translates "total issues" into Korean.
143-143: Translation for "homeassistant_calendar" is accurate.The term "일정" correctly translates "calendar" into Korean.
146-146: Translation for "homeassistant_vacuum" is accurate.The term "진공 청소기" correctly translates "vacuum" into Korean.
149-149: Translation for "homeassistant_scene" is accurate.The term "장면" correctly translates "scene" into Korean.
152-152: Translation for "homeassistant_integration" is accurate.The term "통합구성요소" correctly translates "integration" into Korean.
155-155: Translation for "homeassistant_time" is accurate.The term "시간" correctly translates "time" into Korean.
163-163: Translation for "cloud_alexa_report_state" is accurate.The term "Alexa 상태 보고" correctly translates "Alexa report state" into Korean.
169-169: Translation for "cloud_remote" is accurate.The term "리모트" correctly translates "remote" into Korean.
174-174: Translation for "repairs_ignore_all" is accurate.The term "모두 무시" correctly translates "ignore all" into Korean.
177-177: Translation for "homeassistant_reload" is accurate.The term "다시 로드하기" correctly translates "reload" into Korean.
180-180: Translation for "homeassistant_restart" is accurate.The term "재시작" correctly translates "restart" into Korean.
183-183: Translation for "repairs_unignore_all" is accurate.The term "모두 무시 해제" correctly translates "unignore all" into Korean.
191-191: Translations for "repairs_event" state attributes are accurate.The terms "문제 업데이트," "문제 생성," and "문제 제거" correctly translate "update," "create," and "remove" into Korean.
208-208: Translation for "abort.already_spooked" is appropriate.The phrase "음... 그래... 아니야. 고마워, 안녕!" captures the playful tone of the original message.
212-212: Translation for "step.user.description" is accurate.The phrase "README 파일을 읽으셨나요? 라이선스를 읽으셨나요? 정말 확실한가요?" accurately conveys the intended meaning.
216-217: Translations for "choice_restart.menu_options" are accurate.The terms "지금 재시작" and "나중에 재시작" correctly translate "restart now" and "restart later" into Korean.
219-219: Translation for "choice_restart.description" is accurate.The phrase "Spook을 설정 완료하려면 Home Assistant를 재시작해야 합니다 👻\n\n지금 Home Assistant를 재시작하시겠습니까?" accurately conveys the intended meaning.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/pl.json (2 hunks)
Additional comments not posted (6)
custom_components/spook/translations/pl.json (6)
174-175: Translation entry for "homeassistant_number" looks good.The translation "Liczby" correctly represents the term "Numbers" in Polish.
177-178: Translation entry for "homeassistant_cover" looks good.The translation "Osłony okienne" correctly represents the term "Window Covers" in Polish.
180-181: Translation entry for "homeassistant_input_boolean" looks good.The translation "Wejścia logiczne" correctly represents the term "Boolean Inputs" in Polish.
183-184: Translation entry for "homeassistant_input_button" looks good.The translation "Przyciski" correctly represents the term "Buttons" in Polish.
186-187: Translation entry for "homeassistant_siren" looks good.The translation "Syreny" correctly represents the term "Sirens" in Polish.
189-190: Translation entry for "homeassistant_stt" looks good.The translation "Zamiana mowy na tekst" correctly represents the term "Speech to Text" in Polish.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/fi.json (1 hunks)
Files skipped from review due to trivial changes (1)
- custom_components/spook/translations/fi.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/fi.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- custom_components/spook/translations/fi.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/nl.json (1 hunks)
Additional comments not posted (3)
custom_components/spook/translations/nl.json (3)
2-15: Reviewconfigsection translations.The translations in the
configsection appear accurate and contextually appropriate for guiding users through configuration steps and handling abort scenarios.
19-219: Reviewentitysection translations.The translations for Home Assistant entities are accurate and consistent with the application's terminology. They provide clear and concise names for each entity type.
223-328: Reviewissuessection translations.The translations in the
issuessection are well-structured and provide clear, actionable guidance for users encountering issues. The tone is consistent and appropriately informative.
weblate
force-pushed
the
weblate-spook-integration
branch
from
9081b13 to
e6e8cb6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- custom_components/spook/translations/el.json (5 hunks)
- custom_components/spook/translations/fi.json (1 hunks)
- custom_components/spook/translations/ko.json (4 hunks)
- custom_components/spook/translations/nl.json (1 hunks)
- custom_components/spook/translations/pl.json (2 hunks)
- custom_components/spook/translations/sv.json (9 hunks)
Files skipped from review due to trivial changes (2)
- custom_components/spook/translations/el.json
- custom_components/spook/translations/sv.json
Files skipped from review as they are similar to previous changes (1)
- custom_components/spook/translations/fi.json
Additional comments not posted (63)
custom_components/spook/translations/ko.json (53)
5-5: Translation forhomeassistant_sirenis accurate.The term "사이렌" correctly translates "siren" in Korean.
8-8: Translation forhomeassistant_water_heateris accurate.The term "온수기" correctly translates "water heater" in Korean.
14-14: Translation forhomeassistant_lightis accurate.The term "조명" correctly translates "light" in Korean.
17-17: Translation forhomeassistant_input_numberis accurate.The term "숫자 입력" correctly translates "input number" in Korean.
23-23: Translation forhomeassistant_coveris accurate.The term "차양" correctly translates "cover" in Korean.
26-26: Translation forhomeassistant_areais accurate.The term "영역" correctly translates "area" in Korean.
32-32: Translation forhomeassistant_numberis accurate.The term "숫자" correctly translates "number" in Korean.
38-38: Translation forhomeassistant_ttsis accurate.The term "텍스트-음성 변환" correctly translates "text-to-speech" in Korean.
41-41: Translation forhomeassistant_textis accurate.The term "텍스트" correctly translates "text" in Korean.
47-47: Translation forhomeassistant_input_booleanis accurate.The term "참/거짓 입력" correctly translates "input boolean" in Korean.
53-53: Translation forrepairs_ignored_issuesis accurate.The term "무시된 문제" correctly translates "ignored issues" in Korean.
56-56: Translation forhomeassistant_humidifieris accurate.The term "습도 조절기" correctly translates "humidifier" in Korean.
59-59: Translation forhomeassistant_updateis accurate.The term "업데이트" correctly translates "update" in Korean.
62-62: Translation forhomeassistant_persistent_notificationis accurate.The term "지속적인 알림" correctly translates "persistent notification" in Korean.
68-68: Translation forhomeassistant_input_datetimeis accurate.The term "날짜/시간 입력" correctly translates "input datetime" in Korean.
71-71: Translation forhomeassistant_weatheris accurate.The term "날씨" correctly translates "weather" in Korean.
74-74: Translation forhomeassistant_input_textis accurate.The term "문자 입력" correctly translates "input text" in Korean.
77-77: Translation forhomeassistant_fanis accurate.The term "팬" correctly translates "fan" in Korean.
80-80: Translation forhomeassistant_sunis accurate.The term "태양" correctly translates "sun" in Korean.
83-83: Translation forhomeassistant_input_buttonis accurate.The term "버튼 입력" correctly translates "input button" in Korean.
86-86: Translation forhomeassistant_climateis accurate.The term "온도 조절기" correctly translates "climate" in Korean.
89-89: Translation forhomeassistant_personis accurate.The term "사람" correctly translates "person" in Korean.
92-92: Translation forhomeassistant_sttis accurate.The term "음성-텍스트 변환" correctly translates "speech-to-text" in Korean.
98-98: Translation forhomeassistant_dateis accurate.The term "날짜" correctly translates "date" in Korean.
101-101: Translation forhomeassistant_entitiesis accurate.The term "구성요소" correctly translates "entities" in Korean.
104-104: Translation forhomeassistant_camerais accurate.The term "카메라" correctly translates "camera" in Korean.
107-107: Translation forhomeassistant_input_selectis accurate.The term "선택 입력" correctly translates "input select" in Korean.
110-110: Translation forhomeassistant_selectis accurate.The term "선택" correctly translates "select" in Korean.
113-113: Translation forrepairs_active_issuesis accurate.The term "진행 중인 문제" correctly translates "active issues" in Korean.
116-116: Translation forhomeassistant_remoteis accurate.The term "리모트" correctly translates "remote" in Korean.
119-119: Translation forhomeassistant_deviceis accurate.The term "장치" correctly translates "device" in Korean.
125-125: Translation forhomeassistant_air_qualityis accurate.The term "공기질" correctly translates "air quality" in Korean.
134-134: Translation forhomeassistant_lockis accurate.The term "잠금장치" correctly translates "lock" in Korean.
137-137: Translation forhomeassistant_alarm_control_panelis accurate.The term "알람 제어 패널" correctly translates "alarm control panel" in Korean.
140-140: Translation forrepairs_total_issuesis accurate.The term "총 문제" correctly translates "total issues" in Korean.
143-143: Translation forhomeassistant_calendaris accurate.The term "일정" correctly translates "calendar" in Korean.
146-146: Translation forhomeassistant_vacuumis accurate.The term "진공 청소기" correctly translates "vacuum" in Korean.
149-149: Translation forhomeassistant_sceneis accurate.The term "장면" correctly translates "scene" in Korean.
152-152: Translation forhomeassistant_integrationis accurate.The term "통합구성요소" correctly translates "integration" in Korean.
155-155: Translation forhomeassistant_timeis accurate.The term "시간" correctly translates "time" in Korean.
163-163: Translation forcloud_alexa_report_stateis accurate.The term "Alexa 상태 보고" correctly translates "Alexa report state" in Korean.
166-166: Translation forcloud_google_report_stateis accurate.The term "Google Assistant 상태 보고" correctly translates "Google Assistant report state" in Korean.
169-169: Translation forcloud_remoteis accurate.The term "리모트" correctly translates "remote" in Korean.
174-174: Translation forrepairs_ignore_allis accurate.The term "모두 무시" correctly translates "ignore all" in Korean.
177-177: Translation forhomeassistant_reloadis accurate.The term "다시 로드하기" correctly translates "reload" in Korean.
180-180: Translation forhomeassistant_restartis accurate.The term "재시작" correctly translates "restart" in Korean.
183-183: Translation forrepairs_unignore_allis accurate.The term "모두 무시 해제" correctly translates "unignore all" in Korean.
191-197: Translations forrepairs_eventstate attributes are accurate.The terms "문제 업데이트," "문제 생성," and "문제 제거" correctly translate "update," "create," and "remove" in Korean.
208-208: Translation foralready_spookedis accurate.The phrase "음... 그래... 아니야. 고마워, 안녕!" correctly captures the intended meaning.
212-212: Translation forconfig.step.user.descriptionis accurate.The description "README 파일을 읽으셨나요? 라이선스를 읽으셨나요? 정말 확실한가요?" correctly translates the intended message.
216-217: Translations forconfig.step.choice_restart.menu_optionsare accurate.The terms "지금 재시작" and "나중에 재시작" correctly translate "restart now" and "restart later" in Korean.
219-219: Translation forconfig.step.choice_restart.descriptionis accurate.The description "Spook을 설정 완료하려면 Home Assistant를 재시작해야 합니다 👻\n\n지금 Home Assistant를 재시작하시겠습니까?" correctly translates the intended message.
225-226: Translations forissues.lovelace_unknown_entity_referencesare accurate.The title "알 수 없는 구성요소 참조: {dashboard}" and the description correctly translate the intended message.
custom_components/spook/translations/pl.json (7)
174-175: Translation forhomeassistant_numberis accurate.The term "Liczby" correctly translates "number" in Polish.
177-178: Translation forhomeassistant_coveris accurate.The term "Osłony okienne" correctly translates "cover" in Polish.
180-181: Translation forhomeassistant_input_booleanis accurate.The term "Wejścia logiczne" correctly translates "input boolean" in Polish.
183-184: Translation forhomeassistant_input_buttonis accurate.The term "Przyciski" correctly translates "input button" in Polish.
186-187: Translation forhomeassistant_sirenis accurate.The term "Syreny" correctly translates "siren" in Polish.
189-190: Translation forhomeassistant_sttis accurate.The term "Zamiana mowy na tekst" correctly translates "speech-to-text" in Polish.
277-277: Translation forautomation_unknown_service_referencesis accurate.The updated description correctly translates and enhances clarity for "unknown service references" in Polish.
custom_components/spook/translations/nl.json (3)
2-15: Translations in theconfigsection look good.The translations for abort messages and user actions are clear and consistent.
19-202: Translations in theentitysection are well-structured.The translations accurately reflect the components and are consistent.
223-328: Translations in theissuessection are comprehensive and clear.The new entries provide detailed guidance for resolving issues, maintaining clarity and structure.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- custom_components/spook/translations/it.json (4 hunks)
Files skipped from review due to trivial changes (1)
- custom_components/spook/translations/it.json
weblate
force-pushed
the
weblate-spook-integration
branch
2 times, most recently
from
fdbf61d to
075e8de
Compare
weblate
force-pushed
the
weblate-spook-integration
branch
from
8a9855b to
b7ba9be
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (12)
custom_components/spook/translations/id.json (3)
285-287: LGTM! Consider adding a description for consistency.The new entry for
proximity_unknown_tracked_entitiesis correctly added and translated. Good job on expanding the localization support for this issue type.For consistency with other issue types, consider adding a
descriptionfield to provide more context about this issue. For example:"proximity_unknown_tracked_entities": { "title": "Entitas yang dilacak tidak diketahui: {name}", "description": "Spook telah menemukan entitas yang tidak diketahui dalam konfigurasi kedekatan Anda. Silakan periksa dan perbarui entitas yang dilacak untuk {name}." }
Line range hint
1-284: Review and correct entity name translationsThere are numerous instances where entity names have been translated to "Login" or "Sitemap", which seems incorrect and inconsistent. For example:
homeassistant_siren,homeassistant_light,homeassistant_button, etc., are all translated as "Login".homeassistant_datetime,homeassistant_tts,homeassistant_update, etc., are translated as "Sitemap".These translations don't accurately represent the entities and may confuse users. Consider reviewing and correcting these translations to more accurately describe each entity. For instance:
homeassistant_sirencould be "Sirene" instead of "Login"homeassistant_lightcould be "Lampu" instead of "Login"homeassistant_datetimecould be "Tanggal dan Waktu" instead of "Sitemap"Please review all entity name translations to ensure they accurately represent the entity's function in Indonesian.
Would you like assistance in generating more accurate translations for these entities?
Line range hint
210-226: Consider a more formal abort messageThe current abort message uses very informal language:
"abort": { "already_spooked": "Yeah ... baik ... tidak. K, thx, bye!" }While this aligns with the playful nature of Spook, it might not be suitable for all users or situations. Consider providing a more formal alternative that still maintains the spirit of Spook. For example:
"abort": { "already_spooked": "Maaf, Spook sudah diaktifkan. Tidak perlu mengaturnya lagi." }This maintains a friendly tone while being more informative and professional.
Would you like assistance in crafting a more suitable abort message that balances formality with Spook's playful nature?
custom_components/spook/translations/zh_Hans.json (2)
208-219: Improved configuration step translationsThe updates to the configuration step translations enhance the user experience for Chinese-speaking users. The language used is more natural and idiomatic. For example:
- "您确认吗？" (line 212) is a more natural way to ask for confirmation.
- The restart options (lines 216-217) are clearly presented.
However, there's a minor suggestion for improvement:
Consider changing line 219 from:
"description": "为了让Spook👻完成设置,Home Assistant需要被重启。\n\n您现在是否希望立即重启Home Assistant?"to:
"description": "为了让Spook👻完成设置，Home Assistant需要被重启。\n\n您现在是否希望立即重启Home Assistant？"This adds a space after the comma and a question mark at the end, which is more grammatically correct in Chinese.
Line range hint
1-328: Minor suggestions for consistencyThe translations are generally excellent, but here are a few minor suggestions for improvement:
Line 226: Consider adding a space before the opening parenthesis in "(
{entity_id})" for consistency with other similar occurrences.Lines 287, 291, 303, 307, 323: Consider adding a space after the colon in "未知动作被用于：" and similar phrases for consistency with other titles.
Throughout the file: Consider using full-width punctuation marks (such as "，" instead of ",") in Chinese text for better readability and consistency with Chinese typography conventions.
These minor adjustments would further enhance the overall consistency and readability of the translations.
custom_components/spook/translations/zh_Hant.json (1)
208-219: Config translations improved and expandedThe updates to the configuration translations are good. They maintain the playful tone of Spook while providing clear instructions in Traditional Chinese. The new translation for the restart choice (lines 216-219) is a valuable addition for user experience.
One minor suggestion:
Consider adding a space between "Spook" and "👻" in line 219 for consistency with other occurrences in the file:
-為了讓Spook👻完成設置,Home Assistant需要被重啟。 +為了讓Spook 👻完成設置,Home Assistant需要被重啟。This change would improve consistency throughout the translations.
custom_components/spook/translations/fi.json (2)
2-95: LGTM! Consider adding descriptions to all issues for consistency.The "issues" section is well-structured and provides clear Finnish translations for various error messages and notifications. The use of placeholders for dynamic content is appropriate and consistent.
For improved consistency, consider adding descriptions to all issues. For example, "group_unknown_members" (lines 38-40) and "proximity_unknown_ignored_zones" (lines 45-47) lack descriptions.
300-316: LGTM! Consider revising the abort message for clarity.The "config" section provides clear and accurate Finnish translations for configuration steps, user prompts, and menu options. The structure follows the expected format for Home Assistant configuration translations.
The abort message on line 314 ("Joo... no... en. JEP, kiitti moi!") has a humorous tone, which might be intentional. However, consider revising it to a more straightforward message for clarity, especially for users who might not appreciate the humor in a configuration context.
custom_components/spook/translations/pl.json (1)
174-193: LGTM! Consider minor reordering for consistency.The new sensor entity translations are well-structured and consistent with the existing entries. The Polish translations appear accurate and appropriate.
For improved maintainability, consider reordering the entries to maintain strict alphabetical order. Specifically, move
homeassistant_input_numberbeforehomeassistant_siren:"homeassistant_input_button": { "name": "Przyciski" }, +"homeassistant_input_number": { + "name": "Wprowadź liczby" +}, "homeassistant_siren": { "name": "Syreny" }, "homeassistant_stt": { "name": "Zamiana mowy na tekst" -}, -"homeassistant_input_number": { - "name": "Wprowadź liczby" }custom_components/spook/translations/it.json (1)
123-124: LGTM with suggestion: New/updated script_unknown_label_references sectionThe new/updated section for script_unknown_label_references is well-translated and consistent with the style of other sections. However, for consistency, consider localizing "Your homie" to "Il tuo amico" or "Il fantasma amico" as done in other sections.
Consider updating the last line to maintain consistency with other localized sections:
-Spook 👻 Your homie. +Spook 👻 Il tuo amico.custom_components/spook/translations/af.json (1)
232-233: Minor typo in "Sun" translationThere's a small typo in the translation for "Sun":
- "name": "Sonne" + "name": "Son"The correct Afrikaans word for "Sun" is "Son", not "Sonne" (which is German).
custom_components/spook/translations/nl.json (1)
223-328: LGTM: Comprehensive issue translations with a friendly toneThe issues section has been greatly expanded with detailed translations for various error messages and notifications. The use of the "Spook" character adds a friendly and unique tone to the messages, which is consistent throughout.
For consistency, consider adding the "Spook 👻 Your homie." signature to the messages that don't have it, such as the ones on lines 287-288 and 326-328.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
- custom_components/spook/translations/af.json (1 hunks)
- custom_components/spook/translations/el.json (5 hunks)
- custom_components/spook/translations/fi.json (1 hunks)
- custom_components/spook/translations/id.json (1 hunks)
- custom_components/spook/translations/it.json (4 hunks)
- custom_components/spook/translations/ko.json (4 hunks)
- custom_components/spook/translations/nl.json (1 hunks)
- custom_components/spook/translations/pl.json (2 hunks)
- custom_components/spook/translations/sk.json (1 hunks)
- custom_components/spook/translations/sv.json (9 hunks)
- custom_components/spook/translations/zh_Hans.json (6 hunks)
- custom_components/spook/translations/zh_Hant.json (2 hunks)
🧰 Additional context used
🔇 Additional comments (64)
custom_components/spook/translations/zh_Hans.json (2)
Line range hint
5-158: Improved entity name translationsThe updates to entity name translations significantly enhance the clarity and accuracy of the Chinese localization. Notable improvements include:
- "报警器" for "Sirens" (line 5)
- "设备跟踪器" for "Device Tracker" (line 11)
- "窗帘" for "Cover" (line 23)
- "空调" for "Climate" (line 86)
- "吸尘器" for "Vacuum" (line 146)
These changes better reflect the intended meaning of the original English terms and are more natural in Chinese.
Line range hint
225-328: Comprehensive update to issue descriptionsThe additions and updates to issue descriptions significantly enhance the user experience for Chinese-speaking users. Key improvements include:
- Consistent style and tone across all descriptions.
- Clear explanations of various issues, such as unknown entities, devices, and areas.
- Helpful instructions on how to fix each issue.
The translations maintain a friendly and approachable tone, consistently referring to Spook as "👻" and ending with "Spook 👻 您的伙伴。" This adds a touch of personality to the component.
custom_components/spook/translations/zh_Hant.json (3)
8-158: Improved entity translationsThe updates to the entity translations are generally good improvements. They provide more accurate and idiomatic Traditional Chinese translations. Some notable changes include:
- "熱水器" for water heater (line 8)
- "設備跟蹤器" for device tracker (line 11)
- "窗簾" for cover (line 23)
- "空調" for climate (line 86)
- "吸塵器" for vacuum (line 146)
These changes better reflect the actual meaning of the entities in Traditional Chinese.
Line range hint
225-328: Comprehensive update to issue translationsThe additions and updates to the issue translations are excellent. They provide clear, idiomatic explanations of various issues that Spook can detect, maintaining the playful "ghost" theme while conveying important information. Some notable improvements include:
- Consistent use of "Spook 👻" as a friendly guide (e.g., lines 226, 230, 234).
- Clear explanations of problems and their solutions (e.g., lines 249-250 for unknown sources in Switch as X helpers).
- New translations for previously untranslated issues (e.g., lines 290-328 for various unknown references in scripts, automations, and other components).
These changes significantly improve the user experience for Traditional Chinese speakers using the Spook integration.
Line range hint
1-328: Overall excellent update to Traditional Chinese translationsThis comprehensive update to the Traditional Chinese translations for the Spook integration is of high quality. The changes include:
- More accurate and idiomatic translations for entity names.
- Improved config-related translations that maintain Spook's playful tone.
- Extensive additions and updates to issue translations, providing clear explanations and solutions.
The consistency in style, tone, and terminology throughout the file is commendable. These changes will significantly enhance the user experience for Traditional Chinese speakers using the Spook integration.
custom_components/spook/translations/fi.json (2)
96-298: LGTM! Well-structured and comprehensive entity translations.The "entity" section provides accurate and consistent Finnish translations for various entity types, including sensors, buttons, events, and switches. The structure is well-organized, grouping similar entities together, which enhances readability and maintainability.
1-317: Excellent work on the Finnish translations! A few minor suggestions for consideration.This translation file for the Spook custom component is well-structured, comprehensive, and provides accurate Finnish translations throughout. The quality of the translations and the organization of the file will significantly enhance the user experience for Finnish-speaking users of Home Assistant.
To further improve the file:
- Consider adding descriptions to all issues in the "issues" section for consistency (e.g., "group_unknown_members" and "proximity_unknown_ignored_zones").
- Review the abort message in the "config" section (line 314) and consider replacing it with a more straightforward message for clarity in a configuration context.
Overall, great job on localizing the Spook component for Finnish users!
custom_components/spook/translations/sv.json (11)
4-4: Approved: Correct spelling of "hej då"The change from "hejdå!" to "hej då!" is correct. This is the proper Swedish spelling for "goodbye", with a space between the two words.
8-8: Approved: Improved clarity in user step descriptionThe change from "Läste du readme?" to "Läste du readme-filen?" is an improvement. It adds specificity by mentioning "filen" (file), which enhances clarity for users who might not be familiar with the term "readme".
12-13: Approved: Standardized restart terminologyThe changes from "Restart nu" to "Starta om nu" and from "Omstart senare" to "Starta om senare" are improvements. These updates standardize the terminology for restarting, using "Starta om" which is a more common and clear way to say "restart" in Swedish. This consistency will help users better understand the options.
25-25: Approved: Consistent use of "Starta om" for restartThe change from "Omstart" to "Starta om" for the restart button name is approved. This change maintains consistency with the earlier menu option updates, ensuring a uniform use of terminology throughout the interface for restart-related actions.
36-36: Approved: Improved clarity for "Areas" translationThe change from "Areor" to "Områden" for the areas sensor name is an improvement. "Områden" is a more common and easily understandable term for "areas" in Swedish, which will enhance clarity for users interacting with the interface.
75-75: Approved: Corrected spelling for "Remote controls"The change from "Rjärrkontroller" to "Fjärrkontroller" is approved. This corrects a typo in the Swedish word for "remote controls", with "Fjärrkontroller" being the correct spelling. This correction enhances the overall quality and professionalism of the translations.
117-117: Approved: Correct compound word formation for "Device trackers"The change from "Enhets spårare" to "Enhetsspårare" is approved. This correction adheres to Swedish grammar rules for compound words. In Swedish, compound words should be written as a single word, so "Enhetsspårare" is the correct form for "device trackers". This change improves the grammatical accuracy of the translation.
210-210: Approved: Improved clarity for issue removal stateThe change from "Issue bort" to "Issue borttagen" is approved. "Issue borttagen" translates to "Issue removed", which is more accurate and grammatically correct in Swedish. This change provides a clearer indication of the action taken, improving the user's understanding of the event state.
225-225: Approved: More concise issue titles for unknown referencesThe changes from "Okända [item] som används i:" to "Okända [item] används i:" across multiple issue titles are approved. The removal of "som" (which) simplifies the sentence structure without losing meaning. This results in more concise and direct issue titles, which can improve readability and understanding for users.
Also applies to: 229-229, 233-233, 264-264
280-280: Approved: Consistent terminology for restart required messagesThe changes from "Restart krävs" to "Omstart krävs" in both the confirmation step title and the general title are approved. These updates maintain consistency with the earlier changes to restart terminology throughout the interface. Using "Omstart" for "restart" is more common in Swedish and ensures a uniform user experience across all restart-related messages and actions.
Also applies to: 284-284
Line range hint
1-305: Overall improvement in Swedish translationsThe changes made to this file collectively enhance the quality of the Swedish localization for the Spook custom component. The updates improve clarity, consistency, and correctness across various aspects of the interface, including:
- Corrected spellings and typos
- More accurate and common Swedish terminology
- Improved grammatical structures
- Consistent use of terms, especially for restart-related actions
- More concise and clear issue titles
These changes align well with common Swedish language usage and grammatical rules, which will result in a more intuitive and professional user experience for Swedish-speaking users.
custom_components/spook/translations/ko.json (25)
5-8: Improved entity name translationsThe translations for "homeassistant_siren" and "homeassistant_water_heater" have been updated to more accurate and specific terms in Korean. This change enhances clarity for Korean users.
14-17: Improved entity name translationsThe translations for "homeassistant_light" and "homeassistant_input_number" have been updated to more accurate and descriptive terms in Korean. This change improves the user experience for Korean-speaking users.
23-32: Improved entity name translationsThe translations for "homeassistant_cover", "homeassistant_area", and "homeassistant_number" have been updated to more accurate and consistent terms in Korean. These changes align better with Home Assistant terminology and improve clarity for Korean users.
38-47: Improved entity name translations, especially for TTSThe translations have been updated to more accurate and descriptive terms:
- "homeassistant_tts" now correctly describes the text-to-speech functionality.
- "homeassistant_text" and "homeassistant_input_boolean" use more precise Korean terms.
These changes significantly improve clarity and accuracy for Korean users.
53-65: Improved entity name translations, particularly for custom componentsThe translations have been updated to more accurate and consistent terms:
- "repairs_ignored_issues", "homeassistant_humidifier", "homeassistant_update", and "homeassistant_persistent_notification" now use precise Korean terms.
- Notably, "homeassistant_custom_component" is now translated as "사용자 통합구성요소" (user integration component), which better conveys the concept of a custom integration.
These changes enhance clarity and accuracy for Korean users, especially in understanding custom components.
68-89: Improved entity name translations, with notable improvement for climate controlThe translations have been updated to more accurate and consistent terms across various entities. Notable improvements include:
- "homeassistant_input_datetime" now clearly indicates date/time input.
- "homeassistant_weather" uses a simpler, more common term for weather.
- "homeassistant_climate" is now translated as "온도 조절기" (temperature controller), which better describes its functionality.
These changes provide clearer and more intuitive descriptions for Korean users, especially for the climate control entity.
92-119: Improved entity name translations, with notable improvement for speech-to-textThe translations have been updated to more accurate and consistent terms across various entities. Notable improvements include:
- "homeassistant_stt" is now translated as "음성-텍스트 변환" (speech-to-text conversion), which accurately describes its functionality.
- "homeassistant_entities" is now more appropriately translated as "구성요소" (components).
- "repairs_active_issues" now clearly indicates "ongoing issues" in Korean.
These changes provide more precise and intuitive descriptions for Korean users, enhancing their understanding of Home Assistant entities and functionalities.
Line range hint
125-155: Improved entity name translations, with notable improvement for vacuum cleanerThe translations have been updated to more accurate and consistent terms across various entities. Notable improvements include:
- "homeassistant_vacuum" is now translated as "진공 청소기" (vacuum cleaner), which is a more common and easily understood term in Korean.
- "homeassistant_alarm_control_panel" now uses a more precise term that clearly indicates its function.
- "homeassistant_integration" is translated as "통합구성요소" (integration component), which better conveys its meaning in the context of Home Assistant.
These changes provide clearer and more intuitive descriptions for Korean users, enhancing their understanding of Home Assistant entities and functionalities.
163-169: Improved switch name translations, especially for Alexa state reportingThe translations for cloud-related switches have been updated to more accurate and descriptive terms:
- "cloud_alexa_report_state" is now translated as "Alexa 상태 보고" (Alexa state reporting), which clearly describes its functionality.
- "cloud_remote" is simply translated as "리모트" (remote), which is concise and easily understood.
These changes provide clearer descriptions for Korean users, particularly for the Alexa integration feature.
174-183: Improved button name translationsThe translations for various button names have been updated to accurate and concise terms in Korean:
- "repairs_ignore_all" and "repairs_unignore_all" now clearly indicate the actions of ignoring and unignoring all items.
- "homeassistant_reload" and "homeassistant_restart" use common Korean terms for reload and restart actions.
These translations provide clear and intuitive descriptions of button functions for Korean users.
191-197: Improved translations for event state attributesThe translations for event state attributes have been updated to provide clear and accurate descriptions in Korean:
- Event types are now precisely translated to reflect issue updates, creation, and removal.
- The domain is appropriately translated as "문제 발행자" (issue issuer).
These changes enhance the understanding of issue-related events for Korean users in Home Assistant.
208-219: Improved configuration messages with maintained friendly toneThe translations for configuration messages have been updated to natural and friendly Korean:
- The abort message now has a casual and humorous tone, matching the style of the Spook integration.
- The restart options and description are clearly translated, maintaining the friendly tone and including the ghost emoji (👻) to keep the playful nature of the integration.
These translations effectively convey the messages while preserving the unique style of the Spook integration for Korean users.
225-230: Improved issue descriptions with maintained themeThe translations for issue descriptions have been updated to provide detailed and accurate information in Korean:
- The descriptions for unknown entity references in Lovelace dashboards and unknown sources in integration helpers are clearly explained.
- The translations maintain the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issues are provided in Korean.
These translations effectively communicate the nature of the issues and how to resolve them, while preserving the unique style of the Spook integration for Korean users.
233-234: Improved automation issue descriptionThe translation for the unknown device references issue in automations has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown device references in automations.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the automation are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
248-249: Improved switch as x unknown source issue descriptionThe translation for the unknown source issue in switch as x helpers has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown component sources in switch type change helpers.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the helper or removing it are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
252-253: Improved script unknown device references issue descriptionThe translation for the unknown device references issue in scripts has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown device references in scripts.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the script are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
256-257: Improved script unknown area references issue descriptionThe translation for the unknown area references issue in scripts has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown area references in scripts.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the script are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
260-261: Improved automation unknown area references issue descriptionThe translation for the unknown area references issue in automations has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown area references in automations.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the automation are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
267-268: Improved restart required issue descriptionThe translation for the restart required issue has been updated to provide clear and concise information in Korean:
- The title "재시작 필요" (Restart required) is simple and to the point.
- The description accurately explains the need to restart Home Assistant to complete the Spook configuration.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for restarting Home Assistant are provided in Korean.
This translation effectively communicates the need for a restart and how to proceed, while preserving the unique style of the Spook integration for Korean users.
Also applies to: 272-272
275-276: Improved script unknown entity references issue descriptionThe translation for the unknown entity references issue in scripts has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown entity references in scripts.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the script are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
279-280: Improved automation unknown entity references issue descriptionThe translation for the unknown entity references issue in automations has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown entity references in automations.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the automation are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
283-285: Improved group unknown members issue descriptionThe translation for the unknown members issue in groups has been updated to provide clear and detailed information in Korean:
- The description accurately explains the problem of unknown members in groups.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the group and restarting Home Assistant are provided in Korean.
This translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users.
286-289: New automation unknown floor references issue descriptionA new issue description for unknown floor references in automations has been added in Korean:
- The description accurately explains the problem of unknown floor references in automations.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the automation are provided in Korean.
This new translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users. It's a valuable addition to the Korean localization.
290-293: New automation unknown label references issue descriptionA new issue description for unknown label references in automations has been added in Korean:
- The description accurately explains the problem of unknown label references in automations.
- The translation maintains the ghost theme of the Spook integration, using the ghost emoji (👻) and keeping the friendly tone.
- Clear instructions for resolving the issue by editing the automation are provided in Korean.
This new translation effectively communicates the nature of the issue and how to resolve it, while preserving the unique style of the Spook integration for Korean users. It's a valuable addition to the Korean localization.
294-297: New proximity unknown tracked entities issue descriptionA new issue description for unknown tracked entities in the proximity integration has been added in Korean:
- The description accurately explains the problem of unknown tracked entities (people or device trackers) in the proximity integration settings.
- The
custom_components/spook/translations/pl.json (2)
277-277: LGTM! Improved clarity in translation.The minor rewording in the
automation_unknown_service_referencesdescription enhances clarity while maintaining consistency with the overall tone and style of the translations.
Line range hint
1-324: Overall LGTM! Enhanced Polish translations for Spook component.The changes in this file significantly improve the Polish localization of the Spook component for Home Assistant. The additions of new sensor entity translations and the minor clarification in the automation description contribute to a more comprehensive and user-friendly experience for Polish-speaking users.
Key improvements:
- Added translations for 6 new sensor entities.
- Enhanced clarity in the
automation_unknown_service_referencesdescription.- Maintained consistency with existing translations and structure.
These updates will positively impact the usability of the Spook component for Polish users of Home Assistant.
custom_components/spook/translations/sk.json (2)
291-292: LGTM: Translation update for unknown service references in automations.The changes in these lines update the Slovak translations for the "automation_unknown_service_references" issue. The modifications appear to be correct and consistent with the overall structure and style of the translation file.
Line 291: The title has been updated to "Neznáme akcie používané v: {automation}", which translates to "Unknown actions used in: {automation}". This is an appropriate translation for the context.
Line 292: The description has been updated with a more detailed explanation in Slovak. The translation maintains the ghost theme consistent with other Spook messages and provides clear instructions for the user to fix the issue.
These changes improve the Slovak localization of the Spook component and should help Slovak-speaking users better understand and resolve issues related to unknown service references in their automations.
Line range hint
1-368: Overall assessment: LGTM - Minor translation updates.This review focused on the changes made to the Slovak translation file for the Spook custom component. The modifications were limited to updating the translation for the "automation_unknown_service_references" issue. These changes improve the clarity and consistency of the Slovak localization.
No other alterations were observed in the file, and the overall structure of the JSON remains intact. The updates align well with the existing translation style and maintain the playful ghost theme characteristic of the Spook component.
custom_components/spook/translations/it.json (4)
42-42: LGTM: Improved translation for script_unknown_area_referencesThe updated translation maintains the thematic consistency and improves the clarity of the message. The grammar and structure of the Italian sentence are correct.
69-69: LGTM: Improved localization for switch_as_x_unknown_sourceThe updated translation enhances clarity while maintaining thematic consistency. Notably, the phrase "Your homie" has been localized to "Il fantasma amico" (The friendly ghost), which is a great adaptation for the Italian audience.
95-96: LGTM: Consistent terminology update in automation_unknown_service_referencesThe changes in both the description and title reflect a shift in terminology from "servizi" (services) to "azioni" (actions). This update improves consistency and potentially clarifies the concept for Italian users. The translation maintains its thematic consistency and grammatical correctness.
Line range hint
1-274: Overall: Improved Italian translations with minor consistency suggestionThe changes in this file generally improve the clarity and consistency of the Italian translations for the Spook component. The updates maintain thematic consistency and introduce more precise terminology (e.g., "azioni" instead of "servizi").
One minor point of improvement would be to ensure consistent localization of the phrase "Your homie" across all sections, preferably to "Il tuo amico" or "Il fantasma amico" as seen in some updated parts.
These refinements enhance the user experience for Italian-speaking users of the Spook component.
custom_components/spook/translations/el.json (6)
Line range hint
229-249: LGTM! Improved issue descriptions.The updated translations for "integration_unknown_source" and "switch_as_x_unknown_source" provide more context and clearer instructions for users. These changes will help users better understand and resolve the issues.
253-256: LGTM! Enhanced script issue description.The updated translation for "script_unknown_device_references" provides more context and clearer instructions for users. This change will help users better understand and resolve issues related to unknown devices in scripts.
Line range hint
276-292: LGTM! Improved descriptions for script and utility meter issues.The updated translations for "script_unknown_entity_references" and "utility_meter_unknown_source" provide more context and clearer instructions for users. These changes will help users better understand and resolve issues related to unknown entities in scripts and unknown sources in utility meters.
295-304: LGTM! Enhanced proximity configuration issue descriptions.The updated translations for "proximity_unknown_ignored_zones" and "proximity_unknown_tracked_entities" provide more context and clearer instructions for users. These changes will help users better understand and resolve issues related to unknown zones and entities in proximity configurations.
Line range hint
311-328: LGTM! Improved descriptions for trend and script issues.The updated translations for "trend_unknown_source", "script_unknown_floor_references", and "script_unknown_label_references" provide more context and clearer instructions for users. These changes will help users better understand and resolve issues related to unknown sources in trend helpers, and unknown floors and labels in scripts.
Line range hint
1-330: Excellent improvements to Greek translations!The changes made to this file consistently enhance the clarity and helpfulness of issue descriptions across various components of the Spook integration. These updates will significantly improve the user experience for Greek-speaking users by providing more context, clearer instructions, and better guidance for resolving issues.
Key improvements include:
- More detailed explanations of issues in various components (scripts, automations, utility meters, etc.).
- Clearer instructions on how to resolve each issue.
- Consistent use of terminology and formatting throughout the file.
These changes will help users better understand and resolve issues, ultimately leading to a smoother experience with the Spook integration.
custom_components/spook/translations/af.json (4)
2-108: LGTM: "Issues" section well-structured and properly translatedThe "issues" section is well-organized and contains appropriate Afrikaans translations for various error messages and notifications. The translations maintain a consistent style and friendly tone, aligning with the Spook component's theme. The JSON structure is correct, and there are no apparent issues with the translations or formatting.
110-126: LGTM: "Config" section properly translated and structuredThe "config" section contains appropriate Afrikaans translations for configuration steps, including restart options and user confirmation. The translations are consistent with the style of the rest of the file, and the JSON structure is correct. There are no apparent issues with the translations or formatting.
127-330: LGTM: "Entity" section comprehensive and well-translatedThe "entity" section provides a comprehensive list of Afrikaans translations for various Home Assistant entities, including buttons, events, sensors, and switches. The translations are consistent and appear to be correct. The JSON structure is proper and follows the expected format for entity translations.
1-331: Overall: Excellent Afrikaans translation file for Spook componentThis new translation file for the Spook component in Afrikaans is well-structured, comprehensive, and accurately translated. It covers a wide range of scenarios including error messages, configuration steps, and entity names. The translations maintain a consistent style and friendly tone, aligning well with the Spook component's theme.
Only one minor typo was found in the "Sun" translation, which can be easily corrected. The JSON structure is correct throughout the file, ensuring proper integration with Home Assistant.
Great job on providing a high-quality localization for Afrikaans-speaking users!
custom_components/spook/translations/nl.json (3)
2-17: LGTM: Config section updates look goodThe changes in the config section, including the new "choice_restart" option, are well-structured and provide clear translations for the configuration process.
19-220: LGTM: Comprehensive entity translations addedThe entity section has been significantly expanded with translations for a wide range of Home Assistant components. The translations are consistent and use appropriate terminology.
1-329: Overall: Excellent expansion of Dutch translations for SpookThis update significantly enhances the Dutch localization of the Spook component. The additions cover a wide range of entities and provide detailed, user-friendly translations for various issues that users might encounter. The consistent use of the "Spook" character adds a unique and engaging touch to the error messages.
The changes will greatly improve the user experience for Dutch-speaking users of the Spook component in Home Assistant.
weblate
force-pushed
the
weblate-spook-integration
branch
from
b7ba9be to
be8292b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (6)
custom_components/spook/translations/id.json (1)
Inconsistent Entity Naming Detected
There are 25 occurrences of "Login" and 13 of "Sitemap" in entity names, which are generic and may cause confusion. Please consider using more descriptive and accurate translations that reflect each entity's function.
🔗 Analysis chain
Line range hint
1-284: Inconsistent entity naming may cause user confusion.Many entity names have been changed to either "Login" or "Sitemap", which doesn't accurately reflect their functions. For example:
"homeassistant_siren": { "name": "Login" }, "homeassistant_light": { "name": "Login" }, "homeassistant_datetime": { "name": "Sitemap" }These translations don't provide meaningful information about the entities they represent. Consider using more descriptive Indonesian terms that accurately reflect each entity's purpose.
To verify the extent of this issue, you can run the following script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Count occurrences of "Login" and "Sitemap" in entity names login_count=$(jq '.entity.sensor | map(select(.name == "Login")) | length' custom_components/spook/translations/id.json) sitemap_count=$(jq '.entity.sensor | map(select(.name == "Sitemap")) | length' custom_components/spook/translations/id.json) echo "Number of 'Login' occurrences: $login_count" echo "Number of 'Sitemap' occurrences: $sitemap_count"Length of output: 425
custom_components/spook/translations/zh_Hant.json (1)
Line range hint
225-328: Comprehensive updates to issue descriptions with a minor inconsistencyThe "issues" section has been greatly expanded with accurate and detailed translations for various issue types that Spook can detect. The translations maintain a consistent style and the friendly "ghost" theme of Spook, which enhances the user experience.
However, there's a minor inconsistency in the translation of "Spook" in one place:
In line 284, "Spook 👻 您的夥伴" is used, which is consistent with other occurrences. However, in lines 291 and 295, it's translated as "Spook 👻 你的老鄉". Consider changing these to "Spook 👻 您的夥伴" for consistency.
custom_components/spook/translations/fi.json (3)
2-95: LGTM! Consider adding descriptions to all issues for consistency.The "issues" section provides comprehensive and well-structured Finnish translations for various error messages. The use of placeholders for dynamic content is consistent and appropriate.
For improved consistency, consider adding descriptions to issues that currently only have titles, such as "group_unknown_members" (line 38-40) and "script_unknown_area_references" (line 48-50).
96-299: LGTM! Consider refining some translations for clarity.The "entity" section provides comprehensive Finnish translations for various entity types and their subtypes. The structure is well-organized and consistent.
Consider refining the following translations for improved clarity:
- Line 204: "Laite seuraimet" could be "Laiteseuraimet" (compound word) or "Laitteiden seuranta" for better fluency.
- Line 219, 222, 225, 228, 231, 237: Consider using "Syöttö-" instead of "Syöte" for input types to better reflect the action of inputting.
- Line 249: "Pysyvät ilmoitukset" could be "Pysyvät huomautukset" to distinguish from regular notifications.
300-316: LGTM! Consider revising the abort message tone.The "config" section provides clear and accurate Finnish translations for configuration steps and restart options. The structure and content are well-organized and user-friendly.
The abort message on line 314 uses a casual, humorous tone: "Joo... no... en. JEP, kiitti moi!". While this aligns with the playful nature of the "Spook" theme, consider providing an alternative, more formal translation option. This would allow implementers to choose between a casual or professional tone based on their target audience.
custom_components/spook/translations/it.json (1)
123-124: New issue added for unknown label references in scriptsThe addition of the "script_unknown_label_references" issue expands the localization support for error handling in scripts. This is a valuable addition that aligns with the overall update goals.
However, there's a minor inconsistency in the description:
In the description, "{areas}" is used instead of "{labels}". Consider updating this for consistency:
-"Lo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{areas}\n\n\n\n" +"Lo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{labels}\n\n\n\n"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
- custom_components/spook/translations/af.json (1 hunks)
- custom_components/spook/translations/el.json (5 hunks)
- custom_components/spook/translations/fi.json (1 hunks)
- custom_components/spook/translations/id.json (1 hunks)
- custom_components/spook/translations/it.json (4 hunks)
- custom_components/spook/translations/ko.json (4 hunks)
- custom_components/spook/translations/nl.json (1 hunks)
- custom_components/spook/translations/pl.json (2 hunks)
- custom_components/spook/translations/sk.json (1 hunks)
- custom_components/spook/translations/sv.json (9 hunks)
- custom_components/spook/translations/zh_Hans.json (6 hunks)
- custom_components/spook/translations/zh_Hant.json (2 hunks)
🧰 Additional context used
🔇 Additional comments (64)
custom_components/spook/translations/id.json (3)
Line range hint
285-305: Config translations are well-maintained and on-theme.The config section translations are appropriate and maintain the playful tone consistent with the Spook theme. For example:
"abort": { "already_spooked": "Yeah ... baik ... tidak. K, thx, bye!" }, "step": { "user": { "description": "Apakah Anda membaca readme? Apakah Anda membaca lisensi? Apakah Anda benar-benar yakin?" } }These translations effectively convey the necessary information while keeping the ghostly humor intact.
285-287: New entry forproximity_unknown_tracked_entitiesadded successfully.The addition of the
proximity_unknown_tracked_entitiesentry is appropriate and consistent with updates in other language files:"proximity_unknown_tracked_entities": { "title": "Entitas yang dilacak tidak diketahui: {name}" }This new translation will help Indonesian users better understand proximity-related issues in their Home Assistant setup.
Line range hint
1-289: Overall translation quality is good, with some areas for improvement.The Indonesian translations for the Spook component are generally well-maintained and consistent with the component's theme. However, there are a few areas that require attention:
- Many entity names have been changed to generic terms like "Login" or "Sitemap", which may confuse users.
- There's an untranslated English section in the "automation_unknown_area_references" description.
On the positive side:
- The config translations effectively maintain the playful Spook theme.
- The addition of the
proximity_unknown_tracked_entitiesentry enhances the translation coverage.Addressing these issues will significantly improve the quality and consistency of the Indonesian translations for the Spook component.
custom_components/spook/translations/zh_Hans.json (11)
Line range hint
5-158: LGTM: Entity name translations improvedThe updates to entity names provide more accurate and natural-sounding translations in Chinese. These changes enhance the user experience for Chinese-speaking users of the Spook component.
163-169: LGTM: Switch name translations updatedThe translations for Alexa and Google Assistant state reporting switches have been improved, and a translation for "Remote" has been added. These changes are consistent and enhance the clarity for Chinese users.
174-183: LGTM: Button name translations improvedThe translations for various buttons have been updated or added, providing more accurate and clear Chinese translations. These changes enhance the user interface for Chinese-speaking users.
191-200: LGTM: Event state attribute translations improvedThe translations for event types and attributes have been updated to provide more natural and accurate Chinese translations. These changes improve the clarity of event-related information for Chinese users.
208-219: LGTM: Configuration step translations improvedThe abort message and configuration step descriptions have been updated to provide more natural and clear Chinese translations. These changes enhance the setup process for Chinese-speaking users of the Spook component.
Line range hint
225-280: LGTM: Issue description translations improved and expandedMultiple issue descriptions have been updated or added, providing more detailed and clear explanations in Chinese. These changes significantly improve the ability of Chinese-speaking users to understand and resolve issues within the Spook component.
283-285: LGTM: New group-related issue description addedA new issue description for unknown group members has been added. The translation provides a clear explanation of the problem and instructions on how to resolve it, maintaining consistency with other issue descriptions.
286-293: LGTM: New automation-related issue descriptions addedNew issue descriptions for unknown service and label references in automations have been added. These translations provide clear explanations and resolution steps, enhancing the troubleshooting capabilities for Chinese-speaking users working with automations in the Spook component.
294-301: LGTM: New utility meter and script-related issue descriptions addedNew issue descriptions for unknown utility meter sources and unknown floor references in scripts have been added. These translations provide clear explanations and resolution steps, consistent with other issue descriptions. They improve the overall error handling and user guidance for Chinese-speaking users of the Spook component.
302-328: LGTM: Comprehensive expansion of issue descriptionsMultiple new issue descriptions have been added, covering a wide range of topics including:
- Unknown floor references in automations
- Unknown entity references in scenes
- Issues with proximity sensors
- Unknown label references in scripts
- Unknown sources in trend helpers
These additions significantly expand the range of issues that can be effectively communicated to Chinese-speaking users. The translations are consistent in style and provide valuable guidance for troubleshooting various aspects of the Spook component.
Overall, the changes in this file represent a substantial improvement in the Chinese localization of the Spook component. They enhance clarity, provide more accurate translations, and offer comprehensive guidance for users encountering various issues.
Line range hint
1-328: Excellent improvements to Chinese localizationThe changes in this file represent a significant enhancement to the Chinese localization of the Spook component. Key improvements include:
- More accurate and natural-sounding translations for entity names, buttons, and configuration steps.
- Expanded and clarified issue descriptions, covering a wide range of scenarios.
- Consistent style and tone throughout the translations.
- Improved guidance for troubleshooting and resolving various issues.
These updates will greatly improve the user experience for Chinese-speaking users, making the Spook component more accessible and easier to use.
custom_components/spook/translations/zh_Hant.json (4)
8-158: Improved accuracy and consistency in entity translationsThe updates to entity names in Traditional Chinese are more accurate and consistent. For example, "熱水器" for water heater, "設備跟蹤器" for device tracker, and "燈" for light are more precise translations. These changes enhance the user experience for Traditional Chinese speakers.
163-183: Accurate translations for switch and button labelsThe translations for switch and button labels have been improved. For instance, "Alexa狀態報告" for Alexa state report and "重載" for reload are accurate and natural in Traditional Chinese. These updates contribute to a more intuitive interface for users.
191-200: Enhanced event and issue-related translationsThe event section now includes accurate translations for event types and issue-related terms. For example, "已更新Issue" for updated issue and "Issue 提出者" for issue raiser are clear and consistent translations. These additions improve the overall localization of the component.
208-219: Improved configuration and restart option translationsThe configuration section now includes clear and friendly translations for setup steps and restart options. The translations maintain a consistent tone and provide clear instructions to the user. For example, the question "您是否已閱讀說明文檔？您是否已閱讀許可證？您確認嗎？" effectively asks if the user has read the documentation and license.
custom_components/spook/translations/fi.json (1)
1-317: Excellent Finnish translations with minor suggestions for refinement.The Finnish translation file for the Spook component is comprehensive, well-structured, and provides accurate translations that will greatly enhance the user experience for Finnish-speaking users. The use of placeholders for dynamic content is consistent, and the translations maintain a good balance between technical accuracy and natural language flow.
To further refine the translations:
- Consider adding descriptions to all issues in the "issues" section for consistency.
- Refine some entity type translations for improved clarity and fluency.
- Consider providing an alternative, more formal translation for the abort message to cater to different user preferences.
These minor improvements will help polish an already high-quality translation file.
custom_components/spook/translations/sv.json (12)
4-4: Approved: Improved grammatical accuracyThe change from "hejdå!" to "hej då!" correctly adds a space between the two words, which is the proper spelling in Swedish.
8-8: Approved: Enhanced clarity in user instructionsThe addition of "-filen" (the file) to "Läste du readme-filen?" provides more specificity, clearly indicating that the user should read the readme file.
12-13: Approved: More idiomatic restart optionsThe changes to "Starta om nu" and "Starta om senare" use more natural Swedish phrases for restarting. These updates improve consistency and are more commonly used in Swedish.
25-25: Approved: Consistent terminology for restartThe change from "Omstart" to "Starta om" aligns with the previous updates to restart terminology, ensuring consistency throughout the interface.
36-36: Approved: Improved terminology for areasThe change from "Areor" to "Områden" uses a more common and natural Swedish word for "areas", improving clarity and aligning with standard terminology.
75-75: Approved: Corrected typo in remote controlsThe change from "Rjärrkontroller" to "Fjärrkontroller" corrects a typo, providing the correct Swedish word for "remote controls".
117-117: Approved: Corrected compound word formationThe change from "Enhets spårare" to "Enhetsspårare" removes the space between the words, correctly forming a compound word. This aligns with Swedish grammar rules for compound words and improves accuracy.
210-210: Approved: Clearer indication of issue removalThe change from "Issue bort" to "Issue borttagen" provides a more accurate and clear indication that an issue has been removed. This improves user understanding of the action taken.
225-226: Approved: Improved issue titles and descriptionsThe changes in issue titles from "Okända områden som används i" to "Okända områden används i" improve grammatical correctness in Swedish. The updated descriptions provide more detailed information about the issues and clearer instructions for resolution. These changes enhance clarity and maintain consistency across different issue types.
Also applies to: 229-230, 233-234
280-280: Approved: Consistent terminology for restart requirementThe changes from "Restart krävs" to "Omstart krävs" in both the title and message use a more natural Swedish word for "restart". This update aligns with previous changes to restart terminology in the file, maintaining consistency throughout the interface.
Also applies to: 284-284
264-264: Approved: Consistent and grammatically correct issue titleThe change from "Okända enheter som används i" to "Okända enheter används i" for Lovelace dashboard issues improves grammatical correctness in Swedish. This update is consistent with earlier changes to issue titles, maintaining uniformity across different types of issues in the file.
Line range hint
1-304: Overall: Significant improvements in Swedish translationsThe changes in this file consistently enhance the quality of Swedish translations for the Spook component. Key improvements include:
- Better grammatical accuracy and idiomatic expressions
- Increased clarity in user instructions and error messages
- Correction of typos and compound word formations
- Consistent terminology usage, especially for concepts like "restart" and "areas"
- More informative and actionable issue descriptions
These updates will provide Swedish users with a more natural and understandable interface.
custom_components/spook/translations/ko.json (7)
5-77: Improved entity name translationsThe updates to entity names enhance clarity and accuracy in Korean. These changes will provide a better user experience for Korean-speaking users of Home Assistant.
163-183: Refined switch and button translationsThe updates to switch and button translations, particularly for cloud-related features and repair actions, improve clarity in Korean.
208-219: Enhanced configuration steps and restart optionsThe configuration process has been improved with:
- An updated abort message
- A clearer user step description
- New options for restarting Home Assistant
These changes will provide a smoother setup experience for Korean users.
Line range hint
225-284: Greatly improved issue descriptions and resolution guidanceThe updates to issue descriptions are excellent:
- More detailed and user-friendly explanations
- Specific instructions on how to resolve each issue
- Consistent use of the friendly "Spook" character in messages
These improvements will significantly enhance the troubleshooting experience for Korean users.
286-292: New entries for floor and label reference issuesNew translations have been added for:
- Unknown floor references in automations
- Unknown label references in automations
These additions improve consistency in error handling across different types of references in Home Assistant.
294-305: Expanded coverage of proximity and scene-related issuesNew translations have been added for:
- Unknown tracked entities in proximity integrations
- Unknown zones in proximity integrations
- Unknown entity references in scenes
These additions provide more comprehensive error handling and user guidance for specific Home Assistant features.
306-328: Comprehensive expansion of issue coverageThe final set of additions includes translations for:
- Unknown floor and label references in scripts
- Unknown sources in utility meters and trend helpers
- Unknown ignored zones in proximity integrations
- Unknown service references in automations
These additions, along with all the previous changes, significantly enhance the Korean localization of the Spook component. The translations now cover a wide range of potential issues, maintaining a consistent, friendly tone and providing specific guidance for resolution throughout.
Overall, this update greatly improves the user experience for Korean-speaking Home Assistant users, offering more comprehensive and helpful error messages and instructions.
custom_components/spook/translations/pl.json (3)
174-193: LGTM! New sensor entities added consistently.The new sensor entities have been added with appropriate Polish translations. The naming conventions are consistent with the existing translations in the file.
277-277: Minor wording adjustment in Polish translation.The description for "automation_unknown_service_references" has been slightly modified. While the meaning remains the same, this change might improve the natural flow of the Polish translation.
Line range hint
1-314: Overall assessment: Translations successfully updated.The changes in this file successfully add new sensor entities and make a minor improvement to an existing translation. These updates enhance the Polish localization of the Spook component, aligning with the objectives stated in the PR summary.
custom_components/spook/translations/sk.json (7)
Line range hint
2-186: LGTM: Comprehensive entity translations addedThe "entity" section has been significantly expanded with new translations for various Home Assistant components. The translations appear accurate and consistent, greatly enhancing the localization support for Slovak users.
Line range hint
187-198: LGTM: Cloud-related switch translations addedThe "switch" section now includes translations for cloud-related switches, consistent with the overall improvement in localization support.
Line range hint
199-213: LGTM: Button translations addedThe "button" section now includes translations for important actions such as "Ignore all", "Reload", "Restart", and "Unignore all". These additions will improve the user interface for Slovak users.
Line range hint
214-234: LGTM: Repair event translations addedThe "event" section now includes translations for repair event types and attributes. These additions provide clear Slovak descriptions for different event types, enhancing the user experience for Slovak users.
Line range hint
235-253: LGTM: Configuration messages translated with Spook themeThe "config" section now includes Slovak translations for configuration steps and abort messages. The translations maintain the playful "Spook" theme, providing a consistent and engaging user experience for Slovak users.
Line range hint
254-292: LGTM: Comprehensive issue translations added with terminology improvementThe "issues" section has been extensively updated with Slovak translations for various issue types. These translations provide detailed descriptions and clear instructions for resolving issues, greatly enhancing the user experience for Slovak users.
Notable improvement:
- The terminology for automation issues has been changed from "Unknown services" to "Unknown actions" (lines 291-292), which may provide a more accurate description of the issue.
Line range hint
1-354: LGTM: Comprehensive Slovak translation update for Spook componentThis update significantly enhances the localization support for Slovak users of the Spook custom component. Key improvements include:
- Extensive entity translations covering various Home Assistant components.
- Translations for cloud-related switches and important button actions.
- Localized descriptions for repair events and their attributes.
- Translated configuration messages maintaining the playful "Spook" theme.
- Comprehensive translations for various issue types with detailed resolution instructions.
These changes provide a more intuitive and engaging experience for Slovak-speaking users, consistent with the localization efforts observed in other language files within this pull request.
custom_components/spook/translations/it.json (4)
42-43: Improved clarity in error messageThe refinement in the Italian translation for the "script_unknown_area_references" issue enhances clarity and precision. This change aligns well with the overall goal of improving user communication.
69-70: Enhanced explanation for switch helper issueThe updated Italian translation for the "switch_as_x_unknown_source" issue provides a clearer explanation of the problem and how to resolve it. This improvement in clarity is in line with the overall translation update goals.
95-96: Improved consistency in automation error messageThe change from "servizi" (services) to "azioni" (actions) in the "automation_unknown_service_references" issue improves consistency with other language files and provides a more accurate description of the problem. This update aligns well with the overall goal of refining error messages across multiple languages.
Line range hint
125-265: Comprehensive update to entity and helper translationsThe numerous additions and refinements to sensor names, entity types, and helper translations throughout the file significantly enhance the Italian localization of the Spook component. These changes provide a more complete and accurate representation of Home Assistant entities and features in Italian, improving the overall user experience for Italian-speaking users.
custom_components/spook/translations/el.json (4)
229-229: LGTM! Improved clarity in the issue description.The updated translation for the "integration_unknown_source" issue provides a more detailed and user-friendly explanation. It maintains consistency with the playful "Spook" character while clearly conveying the technical issue and resolution steps.
249-249: LGTM! Enhanced specificity in the switch helper issue description.The updated translation for the "switch_as_x_unknown_source" issue provides a more detailed and specific explanation for switch type change helpers. It maintains the consistent style while clearly explaining the technical issue and resolution steps.
Line range hint
253-328: LGTM! Comprehensive coverage of new issue translations.The newly added translations for various issues (unknown device references, area references, entity references, etc.) in scripts, automations, and other components are well-implemented. They maintain consistency in style and terminology while providing clear explanations and resolution steps for each issue.
Line range hint
229-328: Excellent translation updates for the Spook component.The changes to this file significantly improve the Greek translations for the Spook component. The updates maintain a consistent style, use appropriate terminology, and provide clear explanations for various issues. The expanded coverage of new issues enhances the overall user experience for Greek-speaking users of the Spook component.
custom_components/spook/translations/af.json (4)
2-108: LGTM: Well-structured and comprehensive error messagesThe "issues" section provides clear and detailed Afrikaans translations for various error messages. The structure is consistent, and the language used is appropriate for the target audience.
110-126: LGTM: Clear configuration steps with a touch of humorThe "config" section provides clear Afrikaans translations for configuration steps and abort messages. The inclusion of restart options is well-handled, and the humorous tone in the abort message adds a nice touch, aligning with the Spook component's style.
127-329: LGTM: Comprehensive entity translationsThe "entity" section provides a wide-ranging set of Afrikaans translations for various Home Assistant entities. The translations are concise, descriptive, and consistent. The comprehensive coverage ensures that Afrikaans-speaking users will have a well-localized experience across different aspects of Home Assistant.
1-331: Excellent addition: Comprehensive Afrikaans translations for SpookThis new translation file provides a thorough and well-structured set of Afrikaans translations for the Spook component. The translations cover error messages, configuration steps, and a wide range of Home Assistant entities. The language is consistent, appropriate, and maintains the playful spirit of Spook where relevant. This addition will significantly enhance the user experience for Afrikaans-speaking users of Home Assistant and the Spook component.
custom_components/spook/translations/nl.json (4)
2-17: LGTM: Config section updatesThe changes in the config section improve clarity and maintain proper structure. The Dutch translations are accurate and natural-sounding.
19-220: Excellent expansion of entity translationsThe entity section has been significantly enhanced with comprehensive translations for a wide range of entity types. The structure is consistent, and the Dutch translations are accurate and natural. This update greatly improves the user experience for Dutch-speaking users.
223-328: Comprehensive update to error handling and user guidanceThe issues section has been extensively expanded with detailed error messages and descriptions for various scenarios. The translations are accurate, maintain a consistent style, and use the "Spook" character effectively to provide user-friendly guidance. This update significantly enhances the error handling experience for Dutch users.
1-329: Overall excellent update to Dutch translationsThis update to the Dutch translations for the Spook component is comprehensive and high-quality. The file now provides extensive coverage for config options, entity types, and error messages. The translations are accurate, natural-sounding, and maintain a consistent style throughout. The use of the "Spook" character in error messages adds a friendly tone to the user experience. These changes significantly enhance the usability of the Spook component for Dutch-speaking users.
weblate
force-pushed
the
weblate-spook-integration
branch
from
be8292b to
88f60b1
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (6)
custom_components/spook/translations/zh_Hans.json (2)
219-219: Consider maintaining consistent spacing around emojiFor better readability and consistency, consider standardizing the spacing around the ghost emoji (👻).
-为了让Spook👻完成设置,Home Assistant需要被重启。\n\n您现在是否希望立即重启Home Assistant? +为了让 Spook 👻 完成设置，Home Assistant 需要被重启。\n\n您现在是否希望立即重启 Home Assistant？
Line range hint
225-328: Consider improving readability of technical termsThe translations are accurate and maintain a consistent style. However, consider adding spaces around technical terms and entity IDs for better readability in Chinese text.
Example from line 249:
-此助手有一个 Home Assistant 未知的源开关实体：\n\n`{source}` +此助手有一个 Home Assistant 未知的源开关实体：\n\n`{source}`\nThis pattern could be applied consistently throughout the error messages to improve readability while maintaining technical accuracy.
custom_components/spook/translations/zh_Hant.json (1)
Line range hint
225-328: Issue translations are well done, but there's a minor formatting issue.The translations are accurate and maintain consistency throughout, but there's a formatting issue in line 284 where some characters appear to use incorrect encoding (e.g., "小組" instead of the consistent style used elsewhere).
Fix the formatting in line 284:
- "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。" + "description": "Spook 在你的群組中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 與以下群組相遇：\n\n{group} (`{entity_id}`)\n\n此群組包含以下未知成員：\n\n{entities}\n\n要修復此錯誤，請編輯群組並移除這些不存在的實體，然後重新啟動 Home Assistant。\n\nSpook 👻 您的夥伴。"custom_components/spook/translations/fi.json (1)
2-95: Standardize placeholder naming convention across messagesWhile the translations are well-structured and maintain the ghost theme consistently, there are inconsistencies in placeholder naming:
- Some placeholders use Finnish terms:
{nimike},{skripti},{kojelauta},{alue}- Others retain English terms:
{edit},{automation},{dashboard}Consider standardizing all placeholders to use either Finnish or English terms consistently.
custom_components/spook/translations/af.json (1)
8-8: Maintain consistent spacing around placeholdersThe placeholder
{titel}has inconsistent spacing compared to other placeholders in the file. Consider adding spaces around it for consistency with other translations.- "title": "{titel}" + "title": "{ titel }"custom_components/spook/translations/nl.json (1)
125-126: Consider revising the translation for "Persistent notifications"The current translation "Aanhoudende meldingen" is technically correct but could be more precise. Consider using "Permanente meldingen" which is more commonly used in Dutch software interfaces.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
custom_components/spook/translations/af.json(1 hunks)custom_components/spook/translations/el.json(5 hunks)custom_components/spook/translations/fi.json(1 hunks)custom_components/spook/translations/id.json(1 hunks)custom_components/spook/translations/it.json(4 hunks)custom_components/spook/translations/ko.json(4 hunks)custom_components/spook/translations/nl.json(1 hunks)custom_components/spook/translations/pl.json(2 hunks)custom_components/spook/translations/sk.json(2 hunks)custom_components/spook/translations/sv.json(9 hunks)custom_components/spook/translations/zh_Hans.json(6 hunks)custom_components/spook/translations/zh_Hant.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (6)
- custom_components/spook/translations/el.json
- custom_components/spook/translations/id.json
- custom_components/spook/translations/it.json
- custom_components/spook/translations/pl.json
- custom_components/spook/translations/sk.json
- custom_components/spook/translations/sv.json
🔇 Additional comments (22)
custom_components/spook/translations/zh_Hans.json (4)
Line range hint 5-158: Entity translations look good!
The translations are accurate, consistent, and use appropriate Chinese terminology for Home Assistant entities.
163-169: Switch translations are well done!
The translations maintain proper branding while providing clear Chinese descriptions.
174-183: Button translations are clear and accurate!
The translations use appropriate Chinese action verbs that clearly convey the button's purpose.
191-201: Event translations are technically accurate!
The translations effectively convey the technical concepts while maintaining natural Chinese language flow.
custom_components/spook/translations/zh_Hant.json (5)
8-158: Entity translations look good!
The translations are accurate and consistently use proper Traditional Chinese characters. The terminology is appropriate for the target locale (zh_Hant).
163-169: Switch translations are accurate!
The cloud-related terminology is properly translated and maintains consistency with standard Traditional Chinese terms.
174-183: Button translations are well-crafted!
The action terms are accurately translated and maintain consistency with system terminology in Traditional Chinese.
191-201: Event translations are precise!
The event states and technical terms are accurately translated while maintaining consistency with the system's terminology.
208-219: Configuration messages maintain the right tone!
The translations successfully preserve the playful ghost theme while remaining culturally appropriate and clear in Traditional Chinese.
custom_components/spook/translations/fi.json (2)
96-299: LGTM! Comprehensive and well-structured entity translations
The entity translations are thorough, maintaining consistency in Finnish terminology while preserving technical accuracy. The hierarchical organization makes it easy to locate specific entity types.
300-316: LGTM! Well-crafted configuration messages
The configuration messages effectively combine:
- Clear user instructions
- Consistent ghost-themed messaging
- Natural Finnish language with appropriate humor
custom_components/spook/translations/ko.json (5)
Line range hint 5-155: Entity name translations look great!
The translations are accurate, natural, and consistent with Korean technical terminology. The changes improve clarity while maintaining brevity.
163-183: Switch and button translations are well done!
The translations effectively convey the technical meaning while maintaining natural Korean language flow.
Line range hint 191-203: Event translations are accurate and clear!
The translations effectively convey the technical states and attributes in natural Korean.
208-219: Configuration messages maintain the perfect balance!
The translations successfully preserve the playful ghost theme while providing clear instructions in natural Korean.
Line range hint 225-328: Issue messages are excellently translated!
The translations maintain consistency in error reporting while preserving the friendly ghost theme. New translations for automation, script, and proximity issues are well-integrated and follow the established pattern.
custom_components/spook/translations/af.json (3)
1-331: JSON structure looks good!
The file follows the standard Home Assistant translation format with proper nesting and consistent structure.
1-331: Overall translation quality is good!
The translations maintain a consistent and friendly tone, properly handle technical terms, and follow Home Assistant's translation standards. The identified issues are minor and can be easily fixed.
Great job on providing comprehensive Afrikaans translations for the Spook integration! 👻
233-233:
Fix incorrect word: "Sonne" should be "Son"
The word "Sonne" appears to be German. In Afrikaans, the correct word for "Sun" is "Son".
- "name": "Sonne"
+ "name": "Son"Likely invalid or redundant comment.
custom_components/spook/translations/nl.json (3)
2-18: Configuration section translations look good!
The translations maintain a consistent casual tone while accurately conveying technical concepts. The restart confirmation dialog is well-structured and clear.
223-329: Issue messages are well-translated and maintain the theme!
The translations effectively:
- Preserve all placeholders for dynamic content
- Maintain the ghost/spook theme consistently
- Provide clear, actionable error messages
- Accurately translate technical terms
1-329: Overall translation quality is excellent!
The Dutch translations are consistent, accurate, and maintain the playful ghost theme while properly conveying technical information. The file structure is well-maintained, and all placeholders are correctly preserved.
| "homeassistant_input_boolean": { | ||
| "name": "Syöte booleanit" | ||
| }, | ||
| "homeassistant_input_button": { | ||
| "name": "Syötepainikkeet" | ||
| }, | ||
| "homeassistant_input_datetime": { | ||
| "name": "Syöte päivämäärä/ajat" | ||
| }, | ||
| "homeassistant_input_number": { | ||
| "name": "Syöte numerot" | ||
| }, | ||
| "homeassistant_input_select": { | ||
| "name": "Syöte valinnat" | ||
| }, | ||
| "homeassistant_integration": { | ||
| "name": "Integraatiot" | ||
| }, | ||
| "homeassistant_input_text": { | ||
| "name": "Syötetekstit" | ||
| }, | ||
| "homeassistant_lock": { | ||
| "name": "Lukot" | ||
| }, | ||
| "homeassistant_media_player": { | ||
| "name": "Mediatoistimet" | ||
| }, | ||
| "homeassistant_number": { | ||
| "name": "Numerot" | ||
| }, | ||
| "homeassistant_persistent_notification": { | ||
| "name": "Pysyvät ilmoitukset" | ||
| }, | ||
| "homeassistant_person": { | ||
| "name": "Henkilöt" | ||
| } | ||
| }, | ||
| "button": { | ||
| "repairs_ignore_all": { | ||
| "name": "Sivuuta kaikki" | ||
| }, | ||
| "homeassistant_reload": { | ||
| "name": "Uudelleenlataa" | ||
| }, | ||
| "homeassistant_restart": { | ||
| "name": "Uudelleenkäynnistä" | ||
| }, | ||
| "repairs_unignore_all": { | ||
| "name": "Ota takaisin näkyviin kaikki" | ||
| } | ||
| }, | ||
| "event": { | ||
| "repairs_event": { | ||
| "state_attributes": { | ||
| "event_type": { | ||
| "state": { | ||
| "create": "Ongelma luotu", | ||
| "remove": "Ongelma poistettu", | ||
| "update": "Ongelma päivitetty" | ||
| } | ||
| }, | ||
| "issue_id": { | ||
| "name": "Ongelma ID" | ||
| }, | ||
| "domain": { | ||
| "name": "Ongelman luoja" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "switch": { | ||
| "cloud_alexa_report_state": { | ||
| "name": "Alexa tilan raportointi" | ||
| }, | ||
| "cloud_remote": { | ||
| "name": "Kaukosäädin" | ||
| }, | ||
| "cloud_google_report_state": { | ||
| "name": "Google Assistant tilan raportointi" | ||
| } | ||
| } | ||
| }, | ||
| "config": { | ||
| "step": { | ||
| "user": { | ||
| "description": "Luitko readme:n? Luitko lisenssin? Oletko aivan varma?" | ||
| }, | ||
| "choice_restart": { | ||
| "description": "Jotta Spook pystyy viimeistelemään käyttöönoton, Home Assistantin pitää käynnistyä uudelleen.\n\nHaluatko käynnistää Home Assistantin uudelleen nyt?", | ||
| "menu_options": { | ||
| "restart_later": "Käynnistä uudelleen myöhemmin", | ||
| "restart_now": "Käynnistä uudelleen nyt" | ||
| } | ||
| } | ||
| }, | ||
| "abort": { | ||
| "already_spooked": "Joo... no... en. JEP, kiitti moi!" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
💡 Codebase verification
Missing description fields in Finnish translations
The Finnish translation file (fi.json) is missing description fields for several issue types. Here are the missing translations:
issues.group_unknown_members.descriptionissues.integration_unknown_source.descriptionissues.proximity_unknown_ignored_zones.descriptionissues.proximity_unknown_tracked_entities.descriptionissues.proximity_unknown_zone.descriptionissues.scene_unknown_entity_references.descriptionissues.script_unknown_area_references.descriptionissues.script_unknown_device_references.descriptionissues.script_unknown_entity_references.descriptionissues.script_unknown_floor_references.descriptionissues.script_unknown_label_references.descriptionissues.switch_as_x_unknown_source.descriptionissues.trend_unknown_source.descriptionissues.utility_meter_unknown_source.description
🔗 Analysis chain
Verify translation completeness against other language files
While the translations are well-structured, let's ensure no keys are missing compared to other language files.
Let me analyze the output from comparing translation keys across all language files. The Finnish translation file (fi.json) appears to be missing some description fields for certain issues, while having all the title fields. Let me verify this with a more focused check.
Let me try a different approach to compare the translations more effectively.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare translation keys across language files to ensure completeness
# Find all translation files
echo "Comparing translation files..."
for file in $(fd -e json . custom_components/spook/translations/); do
echo "=== Keys in $file ==="
# Extract and sort all keys (including nested ones)
jq -r 'path(..|select(type=="string")) | join(".")' "$file" | sort
done
Length of output: 167031
Script:
#!/bin/bash
# Compare description fields between en.json (reference) and fi.json
echo "=== Missing descriptions in fi.json compared to en.json ==="
jq -r 'paths(select(.[(-1)] == "description")) | join(".")' custom_components/spook/translations/en.json | sort > /tmp/en_desc.txt
jq -r 'paths(select(.[(-1)] == "description")) | join(".")' custom_components/spook/translations/fi.json | sort > /tmp/fi_desc.txt
diff /tmp/en_desc.txt /tmp/fi_desc.txt | grep '^<' || echo "No missing descriptions found"
Length of output: 672
Script:
#!/bin/bash
# Compare translation keys between en.json and fi.json
echo "=== Comparing fi.json with en.json ==="
jq -r 'paths | join(".")' custom_components/spook/translations/en.json | sort > /tmp/en_keys.txt
jq -r 'paths | join(".")' custom_components/spook/translations/fi.json | sort > /tmp/fi_keys.txt
echo "Keys in en.json but missing in fi.json:"
diff /tmp/en_keys.txt /tmp/fi_keys.txt | grep '^<' || echo "No missing keys found"
Length of output: 1091
weblate
force-pushed
the
weblate-spook-integration
branch
from
88f60b1 to
1b152d0
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (4)
custom_components/spook/translations/fi.json (1)
96-299: Refine entity type translationsConsider these translation improvements:
"Laite seuraimet"→"Laiteseuraimet"(line 204) - Remove space to follow Finnish compound word rules"Syöte booleanit"→"Syötevalitsimet"or"Syötekytkimet"(line 219) - Consider using a Finnish term instead of "boolean"These changes would make the translations more idiomatic Finnish.
custom_components/spook/translations/pl.json (1)
174-193: Consider refining some translations for better clarityWhile the translations are generally good, consider these improvements for better distinction and consistency:
homeassistant_number("Liczby") andhomeassistant_input_number("Wprowadź liczby") are too similar and might confuse users. Consider:
- "Liczby systemowe" for
homeassistant_number- "Pole liczbowe" for
homeassistant_input_number
homeassistant_input_button("Przyciski") duplicates the translation used for regular buttons. Consider:
- "Przyciski wprowadzania" or "Przyciski pomocnicze" to better distinguish from regular buttons
custom_components/spook/translations/af.json (1)
1-108: Improve text consistency in issues sectionThere are several consistency issues in the text:
- Inconsistent spacing after punctuation (e.g., multiple spaces after periods)
- Inconsistent message endings (some with periods, some without)
- Inconsistent use of quotation marks
custom_components/spook/translations/nl.json (1)
314-328: Maintain consistency in the signature lineThere's an inconsistency in the signature line:
- Most messages use "Your homie" (English)
- Recent additions use "Je homie" (Dutch)
Consider standardizing to either English or Dutch for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
custom_components/spook/translations/af.json(1 hunks)custom_components/spook/translations/el.json(5 hunks)custom_components/spook/translations/fi.json(1 hunks)custom_components/spook/translations/id.json(1 hunks)custom_components/spook/translations/it.json(4 hunks)custom_components/spook/translations/ko.json(4 hunks)custom_components/spook/translations/nl.json(1 hunks)custom_components/spook/translations/pl.json(2 hunks)custom_components/spook/translations/sk.json(2 hunks)custom_components/spook/translations/sv.json(11 hunks)custom_components/spook/translations/zh_Hans.json(6 hunks)custom_components/spook/translations/zh_Hant.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- custom_components/spook/translations/el.json
- custom_components/spook/translations/id.json
- custom_components/spook/translations/it.json
- custom_components/spook/translations/sk.json
🔇 Additional comments (31)
custom_components/spook/translations/zh_Hans.json (6)
Line range hint 5-158: Entity translations look good!
The translations are accurate, consistent, and use appropriate Chinese terminology for both technical and UI elements.
163-169: Switch translations are well done!
The translations appropriately preserve brand names while providing clear Chinese translations for the functional aspects.
174-183: Button translations are clear and appropriate!
The translations use standard Chinese UI terminology for actions.
191-201: Event translations are accurate!
The translations effectively convey technical states and terms in natural Chinese.
208-219: Configuration messages maintain the right tone!
The translations successfully preserve both the playful character (including emoji) and the professional clarity of the messages.
Line range hint 225-328: Issue messages are well translated!
The translations:
- Correctly preserve all placeholders and variables
- Maintain consistent terminology and tone
- Successfully adapt the ghost theme for Chinese users
custom_components/spook/translations/zh_Hant.json (6)
8-158: Entity translations look good!
The translations use proper Traditional Chinese characters and maintain consistent terminology throughout the entity names. The translations are semantically accurate and culturally appropriate.
163-169: Switch translations are well done!
The translations maintain consistency in terminology, particularly with "狀態報告" for "report state" across different services.
174-183: Button translations are accurate!
Good consistency in terminology, particularly with the "重" prefix for restart/reload-related actions.
191-201: Event translations are well structured!
Good consistency in terminology for issue-related terms and proper use of Traditional Chinese characters.
208-219: Config translations maintain the right tone!
The translations preserve the playful tone of the original text while maintaining proper Traditional Chinese usage. Good preservation of emoji and formatting.
Line range hint 225-328: Remaining issue translations are well done!
The translations maintain consistency in terminology and formatting throughout the issues section, with proper Traditional Chinese character usage and appropriate preservation of placeholders.
custom_components/spook/translations/fi.json (2)
300-317: LGTM! Config section translations are well done
The translations maintain the playful ghost theme while providing clear setup instructions.
1-317: LGTM! JSON structure is valid
The file is well-formatted and properly structured.
custom_components/spook/translations/ko.json (6)
Line range hint 5-155: LGTM! Entity translations are accurate and consistent.
The translations for entity names maintain consistency in terminology and follow Korean naming conventions. Technical terms are appropriately translated:
- "사이렌" (siren)
- "온수기" (water heater)
- "조명" (light)
- etc.
163-169: LGTM! Switch translations maintain brand consistency.
The translations appropriately preserve brand names (Alexa, Google Assistant) while translating the functional terms.
174-183: LGTM! Button translations are clear and action-oriented.
The translations effectively convey the actions:
- "모두 무시" (ignore all)
- "다시 로드하기" (reload)
- "재시작" (restart)
Line range hint 191-203: LGTM! Event translations maintain technical accuracy.
The translations accurately preserve the technical meaning of event states while maintaining natural Korean language flow.
208-219: LGTM! Configuration prompts maintain the playful ghost theme.
The translations effectively preserve the playful "ghost" (👻) theme while maintaining clarity in the setup instructions. The use of honorifics in Korean ("~셨나요?") adds appropriate politeness.
Line range hint 225-328: LGTM! Issue messages maintain consistency and technical accuracy.
The translations for error messages and issues:
- Maintain consistent terminology (e.g., "알 수 없는" for "unknown")
- Preserve the ghost theme ("Spook이 유령을 발견했습니다 👻")
- Keep technical terms accurate (e.g., "구성요소" for "component", "참조" for "reference")
- Maintain proper formatting with placeholders (e.g.,
{entity_id},{automation})
custom_components/spook/translations/pl.json (1)
277-277: LGTM! Translation maintains consistency and clarity
The error message translation is well-crafted, maintaining the friendly ghost theme while clearly conveying the technical information. All placeholders are correctly preserved, and the grammar is accurate.
custom_components/spook/translations/sv.json (5)
4-4: LGTM! Improved Swedish language accuracy
The changes improve the natural flow of Swedish text:
- Correct spacing in "hej då"
- More idiomatic expressions for restart options ("Starta om" instead of "Restart")
Also applies to: 8-8, 12-13
25-25: LGTM! Entity names are now more accurate
The changes improve terminology and fix language issues:
- More natural terms (e.g., "Områden" instead of "Areor")
- Fixed typo in "Fjärrkontroller"
- Correct compound word formation in "Enhetsspårare"
Also applies to: 36-36, 60-60, 75-75, 117-117
210-210: LGTM! More grammatically correct state message
Changed to proper past participle form "borttagen" which is more grammatically correct in Swedish.
Line range hint 225-288: LGTM! Improved clarity in error messages
The updates provide clearer and more natural Swedish translations for error messages while maintaining consistency in terminology throughout the file.
299-315: LGTM! Well-structured new translations
The newly added translations for floor references, label references, scene references, and trend sources:
- Maintain consistent style and tone
- Correctly preserve all placeholders
- Use proper Swedish grammar and terminology
custom_components/spook/translations/af.json (2)
1-331: Well-maintained ghost theme and technical accuracy
The translations effectively maintain the playful ghost/spook theme while accurately conveying technical concepts. The consistent use of the 👻 emoji and friendly tone ("Spook 👻 Jou maatjie") adds personality to the interface.
15-15:
Fix remaining typos in translations
Several typos need to be corrected:
- Line 15: "Sppok" should be "Spook"
- Line 40: "WTerwyl" should be "Terwyl" and "rodgehang" should be "rondgehang"
- Line 80: "rodgehang" should be "rondgehang"
Also applies to: 40-40, 80-80
custom_components/spook/translations/nl.json (3)
2-18: Configuration translations look good!
The Dutch translations in the configuration section are accurate, maintain a consistent tone, and properly handle the UI flow for setup and restart options.
19-222: Entity translations are well-structured and accurate!
The translations for entity names are consistent, use proper Dutch terminology, and maintain clear naming conventions across all Home Assistant components.
223-313: Issue descriptions are well-translated and maintain theme consistency!
The translations effectively communicate technical issues while maintaining the ghost theme. The messages are clear, properly formatted, and include all necessary placeholders for dynamic content.
| "title": "未知团体成员:{小组}", | ||
| "description": "诗歌在你的团体中发现了一个幽灵。\n\n环绕漂浮, 穿透与以下群体的道路:\n\n{group} (`{entity_id}`)\n\n该团体的成员身份不明:\n\n{entities}\n\n\n\n为了纠正这一错误,小组将注意力放在一边,取消对这些非现有实体的使用,并重新启用家庭助理。\n\n页: 1." | ||
| "title": "未知團體成員:{小組}", | ||
| "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。" |
There was a problem hiding this comment.
Fix character consistency and formatting issues
The line has the following issues:
- Uses simplified Chinese character "组" instead of traditional "組"
- Inconsistent spacing and punctuation
- Formatting differs from other similar messages
Apply this fix:
- "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。"
+ "description": "Spook 在您的群組中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 與以下群組相遇：\n\n{group} (`{entity_id}`)\n\n此群組包含以下未知成員：\n\n{entities}\n\n要修復此錯誤，請編輯群組並刪除這些不存在的成員，然後重新啟動 Home Assistant。\n\nSpook 👻 您的夥伴。"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。" | |
| "description": "Spook 在您的群組中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 與以下群組相遇：\n\n{group} (`{entity_id}`)\n\n此群組包含以下未知成員：\n\n{entities}\n\n要修復此錯誤，請編輯群組並刪除這些不存在的成員，然後重新啟動 Home Assistant。\n\nSpook 👻 您的夥伴。" |
| "issues": { | ||
| "user_issue": { | ||
| "fix_flow": { | ||
| "step": { | ||
| "confirm": { | ||
| "description": "{description}", | ||
| "title": "{nimike}" | ||
| } | ||
| } | ||
| }, | ||
| "title": "{nimike}" | ||
| }, | ||
| "automation_unknown_area_references": { | ||
| "title": "Tuntemattomia alueita käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin alueisiin, jotka ovat Home Assistantille tuntemattomia:\n\n{alueet}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat alueet.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "automation_unknown_device_references": { | ||
| "title": "Tuntemattomia laitteita käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin laitteisiin, jotka ovat Home Assistantille tuntemattomia:\n\n{laitteet}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat laitteet.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "automation_unknown_entity_references": { | ||
| "title": "Tuntemattomia entiteettejä käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin entiteetteihin, jotka ovat Home Assistantille tuntemattomia:\n\n{entiteetit}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat entiteetit.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "automation_unknown_floor_references": { | ||
| "title": "Tuntemattomia kerroksia käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin kerroksiin, jotka ovat Home Assistantille tuntemattomia:\n\n{kerrokset}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat kerrokset.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "automation_unknown_label_references": { | ||
| "title": "Tuntemattomia nimikkeitä käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin nimikkeisiin, jotka ovat Home Assistantille tuntemattomia:\n\n{nimikkeet}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat nimikkeet.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "automation_unknown_service_references": { | ||
| "title": "Tuntemattomia toimintoja käytetty: {automaatio}", | ||
| "description": "Spook on löytänyt kummituksen automaatioistasi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavan automaation kanssa:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTämä automaatio viittaa seuraaviin toimintoihin, jotka ovat Home Assistantille tuntemattomia:\n\n{palvelut}\n\n\n\nKorjataksesi tämän vian [edit the automation]({edit}) ja poista nämä tuntemattomat toiminnot.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "group_unknown_members": { | ||
| "title": "Tuntemattomia ryhmänjäseniä: {ryhmä}" | ||
| }, | ||
| "lovelace_unknown_entity_references": { | ||
| "title": "Tuntemattomia entiteettejä käytetty: {kojelauta}", | ||
| "description": "Spook on löytänyt kummituksen kojelaudoistasi👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavaan kojelautaan:\n\n[{dashboard}]({edit})\n\nTämä automaatio viittaa seuraaviin entiteetteihin, jotka ovat Home Assistantille tuntemattomia:\n\n{entiteetit}\n\n\n\nKorjataksesi tämän vian [edit the dashboard]({edit}) ja poista nämä tuntemattomat entiteetit.\n\nSpook 👻 Kamusi." | ||
| }, | ||
| "proximity_unknown_ignored_zones": { | ||
| "title": "Tuntemattomia sivuutettuja alueita: {nimi}" | ||
| }, | ||
| "script_unknown_area_references": { | ||
| "title": "Tuntemattomia alueita käytetty: {skripti}" | ||
| }, | ||
| "restart_required": { | ||
| "title": "Uudelleenkäynnistys vaaditaan", | ||
| "fix_flow": { | ||
| "step": { | ||
| "confirm_restart": { | ||
| "title": "Uudelleenkäynnistys vaaditaan", | ||
| "description": "Jotta Spook👻 pystyy suorittamaan käyttöönoton loppuun, tulee Home Assistant käynnistää uudelleen.\n\nValitse lähetä, jotta Home Assistant käynnistyy uudelleen nyt." | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "script_unknown_device_references": { | ||
| "title": "Tuntemattomia laitteita käytetty: {skripti}" | ||
| }, | ||
| "script_unknown_entity_references": { | ||
| "title": "Tuntemattomia entiteettejä käytetty: {skripti}" | ||
| }, | ||
| "scene_unknown_entity_references": { | ||
| "title": "Tuntemattomia entiteettejä käytetty: {tilanne}" | ||
| }, | ||
| "switch_as_x_unknown_source": { | ||
| "title": "Tuntematon lähde: {apuri}" | ||
| }, | ||
| "script_unknown_floor_references": { | ||
| "title": "Tuntemattomia kerroksia käytetty: {skripti}" | ||
| }, | ||
| "script_unknown_label_references": { | ||
| "title": "Tuntemattomia nimikkeitä käytetty: {skripti}" | ||
| }, | ||
| "integration_unknown_source": { | ||
| "title": "Tuntematon lähde: {apuri}" | ||
| }, | ||
| "proximity_unknown_tracked_entities": { | ||
| "title": "Tuntemattomia seurattuja entiteettejä: {nimi}" | ||
| }, | ||
| "proximity_unknown_zone": { | ||
| "title": "Tuntematon alue: {alue}" | ||
| }, | ||
| "utility_meter_unknown_source": { | ||
| "title": "Tuntematon lähde: {apuri}" | ||
| }, | ||
| "trend_unknown_source": { | ||
| "title": "Tuntematon lähde: {apuri}" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Add missing description fields and standardize placeholders
- Several issue types are missing description fields:
group_unknown_members(lines 38-40)proximity_unknown_ignored_zones(lines 45-47)script_unknown_area_references(lines 48-50)script_unknown_device_references(lines 62-64)script_unknown_entity_references(lines 65-67)scene_unknown_entity_references(lines 68-70)- And others...
- Placeholders are inconsistently named:
- Some use Finnish:
{nimike},{skripti},{tilanne} - Others use English:
{automation},{dashboard},{edit}
Please:
- Add description fields for all issue types to maintain consistency with other languages
- Standardize placeholder names to either all Finnish or all English to prevent potential runtime issues
weblate
force-pushed
the
weblate-spook-integration
branch
from
30541ce to
3b1043f
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (4)
custom_components/spook/translations/sk.json (1)
291-292: Fix typo in description while terminology improvement is goodThe change from "služby" (services) to "akcie" (actions) is a good terminology improvement. However, there's a typo in the description:
ententity_idshould beentity_id.- "description": "Spook našiel ducha vo vašich automatizáciách 👻\n\nZatiaľ čo plával okolo, Spook prekročil cestu s nasledujúcou automatizáciou:\n\n[{automation}]({edit}) (ententity_id)`)\n\nToto automatizácia odkazuje na nasledujúce služby, ktoré nie sú známe pre Home Assistant:\n\n{services}\n\n\n\nAk chcete opraviť túto chybu, [edit automatizáciu]({edit}) a odstrániť používanie týchto neexistujúcich služieb.\n\nSpook 👻 Váš homie." + "description": "Spook našiel ducha vo vašich automatizáciách 👻\n\nZatiaľ čo plával okolo, Spook prekročil cestu s nasledujúcou automatizáciou:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nToto automatizácia odkazuje na nasledujúce služby, ktoré nie sú známe pre Home Assistant:\n\n{services}\n\n\n\nAk chcete opraviť túto chybu, [edit automatizáciu]({edit}) a odstrániť používanie týchto neexistujúcich služieb.\n\nSpook 👻 Váš homie."custom_components/spook/translations/zh_Hant.json (1)
219-219: Improve formatting consistency in descriptionsThe descriptions contain inconsistent spacing around punctuation marks and line breaks. Some use single newlines while others use double newlines.
Apply this formatting:
-為了讓Spook👻完成設置,Home Assistant需要被重啟。\n\n您現在是否希望立即重啟Home Assistant? +為了讓 Spook 👻 完成設置，Home Assistant 需要被重啟。\n\n您現在是否希望立即重啟 Home Assistant？Also applies to: 267-267
custom_components/spook/translations/pl.json (1)
Line range hint
223-276: Consider translating remaining English phrasesThere are some English phrases remaining in the Polish error messages, for example:
"[edit the script]"in script-related messages"[edit the scene]"in scene-related messages"[edit the automation]"in automation-related messagesConsider translating these to Polish for consistency.
- "[edit the script]" + "[edytuj skrypt]" - "[edit the scene]" + "[edytuj scenę]" - "[edit the automation]" + "[edytuj automatyzację]"custom_components/spook/translations/de.json (1)
324-324: Fix English text in German translationThe line contains English text "[edit the script]" within the German translation.
- "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Etagen, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Etagen.\n\nSpook 👻 Dein homie." + "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Etagen, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Etagen.\n\nSpook 👻 Dein homie."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (14)
custom_components/spook/translations/af.json(1 hunks)custom_components/spook/translations/de.json(1 hunks)custom_components/spook/translations/el.json(5 hunks)custom_components/spook/translations/fi.json(1 hunks)custom_components/spook/translations/id.json(1 hunks)custom_components/spook/translations/it.json(4 hunks)custom_components/spook/translations/ko.json(4 hunks)custom_components/spook/translations/nb_NO.json(5 hunks)custom_components/spook/translations/nl.json(1 hunks)custom_components/spook/translations/pl.json(2 hunks)custom_components/spook/translations/sk.json(2 hunks)custom_components/spook/translations/sv.json(11 hunks)custom_components/spook/translations/zh_Hans.json(6 hunks)custom_components/spook/translations/zh_Hant.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- custom_components/spook/translations/id.json
- custom_components/spook/translations/nb_NO.json
- custom_components/spook/translations/el.json
- custom_components/spook/translations/it.json
🔇 Additional comments (16)
custom_components/spook/translations/sk.json (1)
212-212: LGTM! Good tone adjustment
The change to informal address ("Si" instead of "Ste") better matches Spook's friendly ghost personality and casual communication style.
custom_components/spook/translations/sv.json (4)
4-4: LGTM! Improved clarity and grammar
The changes enhance readability and correctness:
- Proper spacing in "hej då!"
- More specific reference to "readme-filen"
- Clearer restart options and description
Also applies to: 8-8, 12-15
25-25: LGTM! Improved terminology and fixed typos
The entity name changes enhance consistency and correctness:
- More accurate Swedish terms (e.g., "Områden" instead of "Areor")
- Fixed compound word writing ("Enhetsspårare")
- Corrected typo ("Fjärrkontroller")
Also applies to: 36-36, 60-60, 75-75, 117-117, 171-171
208-210: LGTM! Well-structured error messages
The issue descriptions are well-crafted:
- Consistent friendly tone with the ghost theme
- Clear instructions with proper formatting
- Helpful links to edit pages
Also applies to: 225-234, 264-273, 279-284
301-326: LGTM! Consistent new translations
The new translations for floor, label, scene, and utility meter messages:
- Follow the established pattern and friendly tone
- Maintain consistency with existing translations
- Properly preserve all placeholders
custom_components/spook/translations/zh_Hant.json (3)
284-284: Fix character consistency and formatting issues
307-316: LGTM: Well-structured proximity sensor related translations
The proximity sensor related translations are well-structured and use consistent terminology. The translations maintain the ghost theme while being technically accurate.
322-328: LGTM: Consistent helper-related translations
The translations for utility meter and trend helpers maintain consistency in terminology and structure. The ghost theme is well-maintained while keeping technical accuracy.
custom_components/spook/translations/zh_Hans.json (1)
Line range hint 1-328: Well-structured and consistent translations!
The Chinese translations are professionally done with:
- Consistent terminology across all entity names and messages
- Natural language flow in error descriptions
- Correctly preserved placeholders and formatting
- Maintained thematic elements (ghost personality)
custom_components/spook/translations/ko.json (1)
Line range hint 1-328: Professional and consistent Korean translations!
The Korean translations demonstrate high quality with:
- Consistent terminology across all sections
- Natural Korean language patterns
- Correctly preserved technical elements and placeholders
- Maintained thematic elements
custom_components/spook/translations/pl.json (1)
174-193: Well-structured new entity translations!
The new entity translations are clear and consistent with Polish terminology.
custom_components/spook/translations/fi.json (1)
1-108: 🛠️ Refactor suggestion
Standardize placeholder usage
The translations inconsistently use Finnish and English placeholders:
- Finnish: {nimike}, {skripti}, {tilanne}
- English: {automation}, {dashboard}, {edit}
This inconsistency could cause confusion and potential runtime issues.
Standardize all placeholders to use either Finnish or English consistently throughout the file. For example, if choosing Finnish:
- {automation} -> {automaatio}
- {dashboard} -> {kojelauta}
- {edit} -> {muokkaa}Likely invalid or redundant comment.
custom_components/spook/translations/af.json (1)
268-268:
Fix entity translation typo
Line 268: "Toetsel" appears to be a typo and should be "Toestel" (device)
Apply this correction:
- "name": "Toetsel naspeurder"
+ "name": "Toestel naspeurder"Likely invalid or redundant comment.
custom_components/spook/translations/nl.json (1)
1-330: LGTM!
The Dutch translations are complete, consistent, and accurate. No issues found.
custom_components/spook/translations/de.json (2)
2-18: LGTM! Configuration section is well structured and maintains theme consistency.
The translations effectively maintain the ghost/spook theme while providing clear user guidance for configuration steps and restart options.
1-329: Overall translation quality is excellent!
The German translations are comprehensive and maintain a consistent ghost/spook theme throughout the file. The translations are clear, professional, and effectively convey both technical information and error messages while maintaining the playful ghost personality.
| "title": "未知動作被用於：{automation}" | ||
| }, | ||
| "script_unknown_floor_references": { | ||
| "description": "Spook 在你的腳本中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 遇到了以下腳本：\n\n[{script}]({edit}) (`{entity_id}`)\n\n此腳本引用了以下 Home Assistant 未知的樓層：\n\n{floors}\n\n要修復此錯誤，請[編輯腳本]({edit})並刪除這些不存在的樓層。\n\nSpook 👻 你的老鄉。", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Inconsistent usage of "夥伴" vs "老鄉"
The translations inconsistently use "夥伴" and "老鄉" for the same English term. This should be standardized across all messages.
Standardize to use "夥伴" throughout:
-Spook 👻 你的老鄉。
+Spook 👻 你的夥伴。Also applies to: 295-295, 319-319
| "name": "輸入按鈕" | ||
| }, | ||
| "homeassistant_climate": { | ||
| "name": "气候" | ||
| "name": "空調" | ||
| }, | ||
| "homeassistant_person": { | ||
| "name": "人员" | ||
| "name": "人員" | ||
| }, | ||
| "homeassistant_stt": { | ||
| "name": "演讲到文字" | ||
| "name": "語音轉文字" | ||
| }, | ||
| "homeassistant_image": { | ||
| "name": "形象" | ||
| "name": "圖像" | ||
| }, | ||
| "homeassistant_date": { | ||
| "name": "日期" | ||
| }, | ||
| "homeassistant_entities": { | ||
| "name": "实体" | ||
| "name": "實體" | ||
| }, | ||
| "homeassistant_camera": { | ||
| "name": "摄像机" | ||
| "name": "攝像機" | ||
| }, | ||
| "homeassistant_input_select": { | ||
| "name": "产出选择" | ||
| "name": "輸入選擇" | ||
| }, | ||
| "homeassistant_select": { | ||
| "name": "选择" | ||
| "name": "選擇" | ||
| }, | ||
| "repairs_active_issues": { | ||
| "name": "活跃" | ||
| "name": "活躍" | ||
| }, | ||
| "homeassistant_remote": { | ||
| "name": "边远地区" | ||
| "name": "遠程" | ||
| }, | ||
| "homeassistant_device": { | ||
| "name": "装置" | ||
| "name": "設備" | ||
| }, | ||
| "homeassistant_zone": { | ||
| "name": "地区" | ||
| "name": "區域" | ||
| }, | ||
| "homeassistant_air_quality": { | ||
| "name": "空气质量" | ||
| "name": "空氣質量" | ||
| }, | ||
| "homeassistant_automation": { | ||
| "name": "自动化" | ||
| "name": "自動化" | ||
| }, | ||
| "homeassistant_binary_sensor": { | ||
| "name": "1. 原始传感器" | ||
| "name": "二進製傳感器" | ||
| }, | ||
| "homeassistant_lock": { | ||
| "name": "洛克" | ||
| "name": "鎖" | ||
| }, | ||
| "homeassistant_alarm_control_panel": { | ||
| "name": "大型控制小组" | ||
| "name": "報警控製面板" | ||
| }, | ||
| "repairs_total_issues": { | ||
| "name": "共计" | ||
| "name": "共計" | ||
| }, | ||
| "homeassistant_calendar": { | ||
| "name": "日历" | ||
| "name": "日歷" | ||
| }, | ||
| "homeassistant_vacuum": { | ||
| "name": "瓦库姆" | ||
| "name": "吸塵器" | ||
| }, | ||
| "homeassistant_scene": { | ||
| "name": "胎盘" | ||
| "name": "場景" | ||
| }, | ||
| "homeassistant_integration": { | ||
| "name": "一体化" | ||
| "name": "集成" | ||
| }, | ||
| "homeassistant_time": { | ||
| "name": "时间" | ||
| "name": "時間" | ||
| }, | ||
| "homeassistant_media_player": { | ||
| "name": "媒体行为者" | ||
| "name": "媒體播放器" |
There was a problem hiding this comment.
💡 Codebase verification
Traditional Chinese character improvements needed for binary sensor
The translation uses simplified Chinese characters (進製) in "二進製傳感器" where it should use traditional Chinese characters. The correct translation should be "二進位感應器" which is both the proper traditional Chinese form and the more commonly used technical term in Taiwan.
custom_components/spook/translations/zh_Hant.json: Replace "二進製傳感器" with "二進位感應器"
🔗 Analysis chain
Verify consistency of Traditional Chinese characters in entity translations
The translations use proper Traditional Chinese characters, which is correct for zh_Hant. However, there are a few technical terms that could be improved:
- "傳感器" (sensor) is technically correct but "感應器" is more commonly used in Taiwan
- "二進製傳感器" (binary sensor) would be better as "二進位感應器"
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any remaining Simplified Chinese characters in the translations
rg -l "[\x{7b80}\x{7b97}\x{8f6f}\x{56fe}\x{5236}\x{4e8c}\x{8fdb}\x{5236}]" custom_components/spook/translations/zh_Hant.json
Length of output: 176
Script:
#!/bin/bash
# Let's see the actual matches with context to identify specific simplified characters
rg "[\x{7b80}\x{7b97}\x{8f6f}\x{56fe}\x{5236}\x{4e8c}\x{8fdb}\x{5236}]" -A 1 -B 1 custom_components/spook/translations/zh_Hant.json
Length of output: 226
| "group_unknown_members": { | ||
| "title": "Tuntemattomia ryhmänjäseniä: {ryhmä}" | ||
| }, |
There was a problem hiding this comment.
Add missing description field
The group_unknown_members issue is missing a description field, which is present in other language files.
Add the missing description field following the same structure as other issues:
"group_unknown_members": {
"title": "Tuntemattomia ryhmänjäseniä: {ryhmä}"
+ "description": "Spook on löytänyt kummituksen ryhmistäsi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavaan ryhmään:\n\n{group} (`{entity_id}`)\n\nTämä ryhmä sisältää jäseniä, jotka ovat Home Assistantille tuntemattomia:\n\n{entities}\n\n\n\nKorjataksesi tämän vian muokkaa ryhmää, poista tuntemattomat entiteetit ja käynnistä Home Assistant uudelleen.\n\nSpook 👻 Kamusi."
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "group_unknown_members": { | |
| "title": "Tuntemattomia ryhmänjäseniä: {ryhmä}" | |
| }, | |
| "group_unknown_members": { | |
| "title": "Tuntemattomia ryhmänjäseniä: {ryhmä}", | |
| "description": "Spook on löytänyt kummituksen ryhmistäsi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavaan ryhmään:\n\n{group} (`{entity_id}`)\n\nTämä ryhmä sisältää jäseniä, jotka ovat Home Assistantille tuntemattomia:\n\n{entities}\n\n\n\nKorjataksesi tämän vian muokkaa ryhmää, poista tuntemattomat entiteetit ja käynnistä Home Assistant uudelleen.\n\nSpook 👻 Kamusi." | |
| }, |
| }, | ||
| "script_unknown_label_references": { | ||
| "title": "Unbekannte Labels genutzt in: {script}", | ||
| "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie." |
There was a problem hiding this comment.
Fix incorrect placeholder in description
The description uses {floors} placeholder when it should be using {labels} to match the context of label references.
- "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie."
+ "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{labels}\n\n\n\nUm diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie." | |
| "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{labels}\n\n\n\nUm diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie." |
weblate
force-pushed
the
weblate-spook-integration
branch
from
3b1043f to
2f20f45
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
custom_components/spook/translations/fr.json (1)
84-84: Fix spacing in scene error titleThere's inconsistent spacing and a missing space after the colon.
- "title": "Entités inconnues utilisées dans :{scene}" + "title": "Entités inconnues utilisées dans : {scene}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (15)
custom_components/spook/translations/af.json(1 hunks)custom_components/spook/translations/de.json(1 hunks)custom_components/spook/translations/el.json(5 hunks)custom_components/spook/translations/fi.json(1 hunks)custom_components/spook/translations/fr.json(1 hunks)custom_components/spook/translations/id.json(1 hunks)custom_components/spook/translations/it.json(4 hunks)custom_components/spook/translations/ko.json(4 hunks)custom_components/spook/translations/nb_NO.json(5 hunks)custom_components/spook/translations/nl.json(1 hunks)custom_components/spook/translations/pl.json(2 hunks)custom_components/spook/translations/sk.json(2 hunks)custom_components/spook/translations/sv.json(11 hunks)custom_components/spook/translations/zh_Hans.json(6 hunks)custom_components/spook/translations/zh_Hant.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
- custom_components/spook/translations/nb_NO.json
- custom_components/spook/translations/id.json
- custom_components/spook/translations/el.json
- custom_components/spook/translations/sk.json
- custom_components/spook/translations/pl.json
🔇 Additional comments (25)
custom_components/spook/translations/zh_Hant.json (6)
8-158: Entity translations look good
The entity translations are accurate and use proper Traditional Chinese characters. The technical terms are appropriate and consistent with common usage in Taiwan.
208-219: Configuration messages look good
The configuration messages are well-translated and maintain a consistent style with the ghost theme of Spook.
286-328: New issue messages look good
The newly added issue messages for automation, script, proximity, and scene references maintain consistent formatting and proper Traditional Chinese usage.
131-131: 🛠️ Refactor suggestion
Improve Traditional Chinese translation for binary sensor
The current translation "二進製傳感器" uses simplified Chinese characters and terminology. Use "二進位感應器" instead, which is the proper Traditional Chinese term commonly used in Taiwan.
- "name": "二進製傳感器"
+ "name": "二進位感應器"291-291: 🛠️ Refactor suggestion
Standardize the closing signature term
The translations inconsistently use "老鄉" and "夥伴" as the closing signature. Standardize to use "夥伴" throughout to maintain consistency with other messages.
-Spook 👻 你的老鄉。
+Spook 👻 你的夥伴。Also applies to: 295-295
283-284: 🛠️ Refactor suggestion
Improve formatting and clarity of group message
The group message has several issues:
- Inconsistent spacing and punctuation
- Unclear and awkward phrasing
- Formatting differs from other similar messages
- "title": "未知團體成員:{小組}",
- "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。"
+ "title": "未知群組成員：{group}",
+ "description": "Spook 在您的群組中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 與以下群組相遇：\n\n{group} (`{entity_id}`)\n\n此群組包含以下未知成員：\n\n{entities}\n\n要修復此錯誤，請編輯群組並刪除這些不存在的成員，然後重新啟動 Home Assistant。\n\nSpook 👻 您的夥伴。"custom_components/spook/translations/ko.json (5)
Line range hint 5-169: LGTM! Entity translations are accurate and consistent.
The translations maintain consistency in terminology, particularly for:
- Input components (e.g., "숫자 입력", "문자 입력")
- Device-related terms (e.g., "장치 추적기", "온수기")
- Technical terms (e.g., "통합구성요소", "이진 센서")
174-183: LGTM! Action-related translations are clear and intuitive.
The translations effectively convey the actions in Korean while maintaining technical accuracy:
- "모두 무시" (Ignore all)
- "다시 로드하기" (Reload)
- "재시작" (Restart)
Line range hint 191-201: LGTM! Event translations maintain technical accuracy.
The event state translations are clear and technically accurate:
- "문제 업데이트" (Issue update)
- "생성된 문제" (Issue created)
- "문제 제거" (Issue removed)
208-219: LGTM! Configuration messages maintain the project's personality.
The translations effectively preserve the playful ghost theme while providing clear instructions in Korean. The restart options are particularly well-translated:
- "지금 재시작" (Restart now)
- "나중에 재시작" (Restart later)
Line range hint 225-328: LGTM! Issue messages are comprehensive and well-structured.
The translations excel in several aspects:
- Maintain consistent structure across different types of issues
- Preserve technical accuracy in error descriptions
- Successfully adapt the ghost theme for Korean users
- Provide clear actionable steps to resolve issues
Particularly well-done translations include:
- Unknown reference messages (e.g., "알 수 없는 구성요소 참조")
- Service-related errors (e.g., "알 수 없는 서비스 참조")
- Zone-related issues (e.g., "알 수 없는 지역")
custom_components/spook/translations/sv.json (4)
4-4: Verify configuration message consistency
The configuration messages have been updated with improved clarity:
- "hej då!" is now properly spaced (line 4)
- "readme-filen" is more specific than just "readme" (line 8)
- Restart options are more naturally phrased (lines 12-13)
- The restart description is well-structured with proper line breaks (line 15)
The translations are accurate and maintain a consistent tone.
Also applies to: 8-8, 12-13, 15-15
25-25: Entity name translations follow Swedish conventions
The entity names have been updated to be more idiomatic:
- "Starta om" instead of "Omstart" (line 25)
- "Områden" instead of "Areor" (line 36)
- "Entiteter" instead of "Enheter" (line 60)
- "Fjärrkontroller" instead of "Rjärrkontroller" (line 75)
- "Enhetsspårare" instead of "Enhets spårare" (line 117)
- "Skripts" instead of "Script" (line 171)
The translations are accurate and follow Swedish naming conventions.
Also applies to: 36-36, 60-60, 75-75, 117-117, 171-171, 183-183, 189-189
301-324: New translations maintain consistent style and formatting
The newly added translations for automation, scene, and script issues (lines 301-324) follow the established pattern:
- Consistent use of "Spook 👻" signature
- Proper string interpolation placeholders
- Well-structured error descriptions
- Consistent use of markdown links for edit actions
The translations are well-formatted and maintain consistency with the existing messages.
Line range hint 225-326: Verify string interpolation placeholders
The issue messages use various placeholders that need to be preserved exactly as they appear in the source language:
{automation}{edit}{entity_id}{script}{helper}{scene}- etc.
✅ Verification successful
All string interpolation placeholders are correctly preserved in the Swedish translation
Based on the comparison of both English and Swedish translations, all placeholders like {automation}, {edit}, {entity_id}, {script}, {helper}, {scene}, {areas}, {devices}, {entities}, etc. are consistently maintained in the Swedish translation. The placeholders appear in the same positions and serve the same purpose in both language versions, ensuring proper string interpolation will work as expected.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that all placeholders in the Swedish translation match the source
# Get the source (en.json) placeholders
rg -o "\{[a-zA-Z_]+\}" custom_components/spook/translations/en.json | sort -u > /tmp/en_placeholders.txt
# Get the Swedish translation placeholders
rg -o "\{[a-zA-Z_]+\}" custom_components/spook/translations/sv.json | sort -u > /tmp/sv_placeholders.txt
# Compare the placeholders
diff /tmp/en_placeholders.txt /tmp/sv_placeholders.txt
Length of output: 216
Script:
#!/bin/bash
# Let's try a different approach to verify placeholders
# First, let's check if both files exist and show their content structure
echo "=== Checking English translation strings ==="
rg -A 1 '"title":' custom_components/spook/translations/en.json
echo -e "\n=== Checking Swedish translation strings ==="
rg -A 1 '"title":' custom_components/spook/translations/sv.json
# Let's also check specific sections that use placeholders
echo -e "\n=== Comparing specific messages with placeholders ==="
echo "English version of automation_unknown_area_references:"
rg -A 3 '"automation_unknown_area_references"' custom_components/spook/translations/en.json
echo -e "\nSwedish version of automation_unknown_area_references:"
rg -A 3 '"automation_unknown_area_references"' custom_components/spook/translations/sv.json
Length of output: 8592
custom_components/spook/translations/zh_Hans.json (1)
Line range hint 1-328: Chinese translations look good!
The translations are comprehensive, well-structured, and maintain consistency in terminology and placeholder usage throughout the file.
custom_components/spook/translations/fi.json (2)
38-40:
Add missing description for group_unknown_members
The description field is missing, which is required for consistency with other translations.
Add the missing description field:
"group_unknown_members": {
"title": "Tuntemattomia ryhmänjäseniä: {ryhmä}"
+ "description": "Spook on löytänyt kummituksen ryhmistäsi 👻\n\nLeijuessaan ympäriinsä, Spook törmäsi seuraavaan ryhmään:\n\n{ryhmä} (`{entity_id}`)\n\nTämä ryhmä sisältää jäseniä, jotka ovat Home Assistantille tuntemattomia:\n\n{entiteetit}\n\n\n\nKorjataksesi tämän vian muokkaa ryhmää, poista tuntemattomat entiteetit ja käynnistä Home Assistant uudelleen.\n\nSpook 👻 Kamusi."
}15-16:
Standardize placeholder names across translations
Found inconsistent use of Finnish and English placeholders for the same concepts:
- Automation references:
{automaatio}in titles but{automation}in descriptions
- Dashboard references:
{kojelauta}in titles but{dashboard}in descriptions
- Script references:
{skripti}in titles but{script}in descriptions
- Scene references:
{tilanne}in titles but{scene}in descriptions
This inconsistency could cause runtime issues if the code expects specific placeholder names.
Choose one language (preferably Finnish for consistency) and standardize all placeholders. For example:
-"[{automation}]({edit})"
+"[{automaatio}]({muokkaa})"
-"[{dashboard}]({edit})"
+"[{kojelauta}]({muokkaa})"
-"[{script}]({edit})"
+"[{skripti}]({muokkaa})"
-"[{scene}]({edit})"
+"[{tilanne}]({muokkaa})"Also applies to: 42-43, 69-70, 73-74
custom_components/spook/translations/af.json (3)
268-268:
Fix device tracker translation
The word "Toetsel" should be "Toestel" (device).
- "name": "Toetsel naspeurder"
+ "name": "Toestel naspeurder"Likely invalid or redundant comment.
15-16:
Fix typos in automation error message
Several typos found in the error message:
- "Terwyk" should be "Terwyl"
- "Sppok" should be "Spook"
- "description": "Spook het 'n spook gekry in jou outomatiserings 👻\n\nTerwyk hy rondgehang het, het Sppok die volgende automatisasies teegekom:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nHierdie automatisasie verwys na die volgende areas, wat onbekend is aan Home Assistant\n\n{areas}\n\n\n\nOm hiedie probleem reg te maak, [edit the automation]({edit}) en haal ongebruikte areas uit.\n\nSpook 👻 Jou maatjie."
+ "description": "Spook het 'n spook gekry in jou outomatiserings 👻\n\nTerwyl hy rondgehang het, het Spook die volgende automatisasies teegekom:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nHierdie automatisasie verwys na die volgende areas, wat onbekend is aan Home Assistant\n\n{areas}\n\n\n\nOm hierdie probleem reg te maak, [edit the automation]({edit}) en haal ongebruikte areas uit.\n\nSpook 👻 Jou maatjie."Likely invalid or redundant comment.
40-40:
Fix typos in dashboard error message
Found typos:
- "WTerwyl" should be "Terwyl"
- "rodgehang" should be "rondgehang"
- "description": "Spook het 'n gees gevind in jou paneelborde (dashboards) 👻\n\nWTerwyl hy rodgehang het, het Spook die volgende paneelbord teegekom:\n\n[{dashboard}]({edit})\n\nDie paneelbord verwys nsa die volgende entiteite wat onbekend is aan Home Assistant:\n\n{entities}\n\n\n\nOm heirde probleem op te los [edit the dashboard]({edit}) en haal die onbekende entiteite uit.\n\nSpook 👻 Jou vriend.."
+ "description": "Spook het 'n gees gevind in jou paneelborde (dashboards) 👻\n\nTerwyl hy rondgehang het, het Spook die volgende paneelbord teegekom:\n\n[{dashboard}]({edit})\n\nDie paneelbord verwys na die volgende entiteite wat onbekend is aan Home Assistant:\n\n{entities}\n\n\n\nOm hierdie probleem op te los [edit the dashboard]({edit}) en haal die onbekende entiteite uit.\n\nSpook 👻 Jou vriend."Likely invalid or redundant comment.
custom_components/spook/translations/nl.json (1)
1-329: LGTM! Dutch translations are accurate and well-structured
The translations maintain proper grammar, preserve all placeholders, and follow a consistent style.
custom_components/spook/translations/de.json (3)
2-18: LGTM! Configuration section is well structured.
The configuration messages are properly translated and maintain a consistent tone with the ghost theme of Spook.
19-222: LGTM! Entity translations are comprehensive and accurate.
The entity section provides clear and consistent German translations for all entity types, maintaining Home Assistant's naming conventions.
328-328:
Fix incorrect placeholder in description
The description uses {floors} placeholder when it should be using {labels} to match the context of label references.
- "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie."
+ "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{labels}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label.\n\nSpook 👻 Dein homie."| "update": "Problem uppdaterat", | ||
| "create": "Problem skapad", | ||
| "remove": "Issue borttagen" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Event state attributes use consistent terminology
The event state attributes have been updated with proper Swedish terms:
- "Problem uppdaterat" (line 208)
- "Problem skapad" (line 209)
- "Issue borttagen" (line 210)
Note: There's an inconsistency in line 210 where "Issue" is in English while the rest is in Swedish.
- "remove": "Issue borttagen"
+ "remove": "Problem borttagen"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "update": "Problem uppdaterat", | |
| "create": "Problem skapad", | |
| "remove": "Issue borttagen" | |
| "update": "Problem uppdaterat", | |
| "create": "Problem skapad", | |
| "remove": "Problem borttagen" |
| "title": "Etichette sconosciute usate in: {script}", | ||
| "description": "Spook ha trovato un fantasma nei tuoi script 👻\n\nMentre fluttuava, Spook ha incrociato nel suo percorso lo script:\n\n[{script}]({edit}) (`{entity_id}`)\n\nLo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{areas}\n\n\n\nPer correggere questo errore, [modifica lo script]({edit}) e rimuovi l'uso di queste etichette inesistenti.\n\nSpook 👻 Your homie." |
There was a problem hiding this comment.
Fix incorrect placeholder in script_unknown_label_references description
The description uses {areas} placeholder but should use {labels} to match the context and other translations.
Apply this diff to fix the placeholder:
- "description": "Spook ha trovato un fantasma nei tuoi script 👻\n\nMentre fluttuava, Spook ha incrociato nel suo percorso lo script:\n\n[{script}]({edit}) (`{entity_id}`)\n\nLo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{areas}\n\n\n\nPer correggere questo errore, [modifica lo script]({edit}) e rimuovi l'uso di queste etichette inesistenti.\n\nSpook 👻 Your homie."
+ "description": "Spook ha trovato un fantasma nei tuoi script 👻\n\nMentre fluttuava, Spook ha incrociato nel suo percorso lo script:\n\n[{script}]({edit}) (`{entity_id}`)\n\nLo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{labels}\n\n\n\nPer correggere questo errore, [modifica lo script]({edit}) e rimuovi l'uso di queste etichette inesistenti.\n\nSpook 👻 Your homie."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "Etichette sconosciute usate in: {script}", | |
| "description": "Spook ha trovato un fantasma nei tuoi script 👻\n\nMentre fluttuava, Spook ha incrociato nel suo percorso lo script:\n\n[{script}]({edit}) (`{entity_id}`)\n\nLo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{areas}\n\n\n\nPer correggere questo errore, [modifica lo script]({edit}) e rimuovi l'uso di queste etichette inesistenti.\n\nSpook 👻 Your homie." | |
| "title": "Etichette sconosciute usate in: {script}", | |
| "description": "Spook ha trovato un fantasma nei tuoi script 👻\n\nMentre fluttuava, Spook ha incrociato nel suo percorso lo script:\n\n[{script}]({edit}) (`{entity_id}`)\n\nLo script fa riferimento alle seguenti etichette, che sono sconosciute ad Home Assistant:\n\n{labels}\n\n\n\nPer correggere questo errore, [modifica lo script]({edit}) e rimuovi l'uso di queste etichette inesistenti.\n\nSpook 👻 Your homie." |
| }, | ||
| "script_unknown_floor_references": { | ||
| "title": "Unbekannte Stockwerke genutzt in: {script}", | ||
| "description": "Spook hat einen Geist in deinen Scripts gefunden👻\n\nBeim Herumgeistern hat Spook folgende Scripts gefunden:\n\n[{script}]({edit}) (`{entity_id}`)\n\nDieses Script beinhaltet folgende Etagen, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Etagen.\n\nSpook 👻 Dein homie." |
There was a problem hiding this comment.
Translate remaining English text to German
There are some English phrases that should be translated to German:
- "description": "...Um diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Etagen..."
+ "description": "...Um diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Etagen..."- "description": "...Um diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label..."
+ "description": "...Um diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Label..."Also applies to: 328-328
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/el/
Currently translated at 79.4% (93 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/pl/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/el/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/it/
Currently translated at 74.3% (87 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/id/
Currently translated at 0.8% (1 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/af/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/af/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/zh_Hans/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/zh_Hans/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/zh_Hant/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sk/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/ko/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/nl/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sk/
Currently translated at 78.6% (92 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sv/
Currently translated at 78.6% (92 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sv/
Currently translated at 78.6% (92 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sv/
Currently translated at 95.7% (112 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sv/
Currently translated at 86.3% (101 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/nb_NO/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/de/
Currently translated at 99.1% (116 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/fi/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/fr/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/fi/
weblate
force-pushed
the
weblate-spook-integration
branch
from
2f20f45 to
9f25179
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (1)
custom_components/spook/translations/fr.json (1)
84-84: Fix inconsistent spacing around placeholdersThere are inconsistent spaces around placeholders:
- Line 84: No space after colon in
"dans :{scene}"- Line 87-88: Inconsistent spacing around colons
Apply these formatting fixes:
- "title": "Entités inconnues utilisées dans :{scene}" + "title": "Entités inconnues utilisées dans : {scene}" - "title": "Actions inconnues utilisées dans: {automation}", + "title": "Actions inconnues utilisées dans : {automation}",Also applies to: 87-88
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
custom_components/spook/translations/af.json(1 hunks)custom_components/spook/translations/de.json(1 hunks)custom_components/spook/translations/el.json(5 hunks)custom_components/spook/translations/fi.json(1 hunks)custom_components/spook/translations/fr.json(1 hunks)custom_components/spook/translations/id.json(1 hunks)custom_components/spook/translations/it.json(4 hunks)custom_components/spook/translations/ko.json(4 hunks)custom_components/spook/translations/nb_NO.json(5 hunks)custom_components/spook/translations/nl.json(1 hunks)custom_components/spook/translations/pl.json(2 hunks)custom_components/spook/translations/sk.json(2 hunks)custom_components/spook/translations/sv.json(11 hunks)custom_components/spook/translations/zh_Hans.json(6 hunks)custom_components/spook/translations/zh_Hant.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- custom_components/spook/translations/el.json
- custom_components/spook/translations/id.json
- custom_components/spook/translations/nb_NO.json
- custom_components/spook/translations/sk.json
🔇 Additional comments (18)
custom_components/spook/translations/nl.json (4)
2-18: LGTM! Configuration section translations are clear and consistent.
The Dutch translations in the configuration section are grammatically correct and maintain a consistent, friendly tone while clearly explaining the setup requirements.
19-222: LGTM! Entity translations are comprehensive and accurate.
The Dutch translations for all entity types are consistent, follow Home Assistant naming conventions, and accurately represent their English counterparts.
223-329: LGTM! Error messages are well-structured and maintain the theme.
The Dutch translations for error messages:
- Maintain the playful "Spook" (ghost) theme consistently
- Provide clear problem descriptions and actionable solutions
- Properly preserve all dynamic content placeholders
- Follow a consistent structure throughout
1-329: Excellent translation work! 🎉
The Dutch translations are of high quality, maintaining consistency throughout while preserving the unique ghost theme. The file successfully achieves the PR objective of updating translations for the Spook project.
custom_components/spook/translations/de.json (4)
324-324: Translate remaining English text to German
The description contains English text that should be translated to German.
- "description": "...Um diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Etagen..."
+ "description": "...Um diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Etagen..."2-18: Configuration section looks good!
The translations are consistent and properly formatted in German.
19-222: Entity translations are well-structured and accurate!
The translations maintain consistency in terminology and proper German language usage throughout all entity types.
328-328:
Fix incorrect placeholder and English text
There are two issues in this description:
- The placeholder
{floors}should be{labels}to match the context - The English phrase "edit the script" should be translated to German
- "description": "...Dieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{floors}\n\n\n\nUm diesen Fehler zu beheben, [edit the script]({edit}) und entferne die unbekannten Label..."
+ "description": "...Dieses Script beinhaltet folgende Label, welche Home Assistant unbekannt sind:\n\n{labels}\n\n\n\nUm diesen Fehler zu beheben, [bearbeite das Script]({edit}) und entferne die unbekannten Label..."Likely invalid or redundant comment.
custom_components/spook/translations/zh_Hans.json (1)
Line range hint 1-328: LGTM! Simplified Chinese translations are accurate and consistent.
The translations use proper Simplified Chinese characters and maintain consistency in technical terminology throughout the file.
custom_components/spook/translations/zh_Hant.json (3)
291-291: Standardize the translation of "friend"
The translations inconsistently use "老鄉" and "夥伴" for the same English term "friend". This should be standardized.
- "description": "...Spook 👻 你的老鄉。"
+ "description": "...Spook 👻 你的夥伴。"Also applies to: 295-295, 319-319
283-284: Improve group message formatting and terminology
The group message uses inconsistent formatting and some Simplified Chinese characters.
- "title": "未知團體成員:{小組}",
- "description": "Spook 在你的團體中發現了一個幽靈。\n\n環繞漂浮, 穿透與以下群體的道路:\n\n{group} (`{entity_id}`)\n\n該團體的成員身份不明:\n\n{entities}\n\n\n\n為了糾正這一錯誤,小組將註意力放在一邊,取消對這些非現有實體的使用,並重新啟用家庭助理。"
+ "title": "未知群組成員：{group}",
+ "description": "Spook 在您的群組中發現了一個幽靈 👻\n\n在四處遊蕩時，Spook 與以下群組相遇：\n\n{group} (`{entity_id}`)\n\n此群組包含以下未知成員：\n\n{entities}\n\n要修復此錯誤，請編輯群組並刪除這些不存在的成員，然後重新啟動 Home Assistant。\n\nSpook 👻 您的夥伴。"131-131: 🛠️ Refactor suggestion
Improve technical terminology for binary sensor
The translation "二進製傳感器" should be changed to "二進位感應器" which is the proper Traditional Chinese technical term.
- "name": "二進製傳感器"
+ "name": "二進位感應器"Likely invalid or redundant comment.
custom_components/spook/translations/ko.json (1)
Line range hint 1-328: LGTM! Korean translations are accurate and consistent.
The translations use proper Korean characters and maintain consistency in technical terminology throughout the file.
custom_components/spook/translations/pl.json (1)
174-193: LGTM! New sensor entity translations added correctly
The Polish translations for new sensor entities are accurate and maintain consistency with the existing translation style.
custom_components/spook/translations/sv.json (2)
208-210: Maintain consistent Swedish terminology
The event state attributes should use consistent Swedish terminology. Currently, line 210 uses "Issue" in English while other terms are translated.
301-324: LGTM! New translations for floor and label references
The Swedish translations for floor and label references are well-structured and maintain consistency with existing translations.
custom_components/spook/translations/it.json (2)
123-124: Fix incorrect placeholder in script_unknown_label_references description
The description uses {areas} placeholder but should use {labels} to match the context and other translations.
95-96: LGTM! Consistent terminology update
The change from "servizi" (services) to "azioni" (actions) improves clarity and maintains consistency across the translations.
| }, | ||
| "automation_unknown_label_references": { | ||
| "title": "Unbekannte Labels genutzt in: {automation}", | ||
| "description": "Spook hat einen Geist in deinen Automatisierungen gefunden 👻\n\nBeim Herumschweben traf Spook auf folgende Automatisierung:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nThe Automatisierung referenziert folgendes Label, das Home Assistant nicht bekannt ist:\n\n{labels}\n\n\n\nUm den Fehler zu beheben, [editiere die Automatisierung]({edit}) und entferne alle Referenzen auf nicht-existierende Labels.\n\nSpook 👻 Dein homie." |
There was a problem hiding this comment.
Fix English article in German text
The description contains an English article "The" in a German sentence.
- "description": "...The Automatisierung referenziert folgendes Label..."
+ "description": "...Die Automatisierung referenziert folgendes Label..."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description": "Spook hat einen Geist in deinen Automatisierungen gefunden 👻\n\nBeim Herumschweben traf Spook auf folgende Automatisierung:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nThe Automatisierung referenziert folgendes Label, das Home Assistant nicht bekannt ist:\n\n{labels}\n\n\n\nUm den Fehler zu beheben, [editiere die Automatisierung]({edit}) und entferne alle Referenzen auf nicht-existierende Labels.\n\nSpook 👻 Dein homie." | |
| "description": "Spook hat einen Geist in deinen Automatisierungen gefunden 👻\n\nBeim Herumschweben traf Spook auf folgende Automatisierung:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nDie Automatisierung referenziert folgendes Label, das Home Assistant nicht bekannt ist:\n\n{labels}\n\n\n\nUm den Fehler zu beheben, [editiere die Automatisierung]({edit}) und entferne alle Referenzen auf nicht-existierende Labels.\n\nSpook 👻 Dein homie." |
| "title": "{titel}" | ||
| }, | ||
| "automation_unknown_area_references": { | ||
| "title": "Onbekende areas gebruik in: {automation}", |
There was a problem hiding this comment.
Fix typos in automation messages
There are several typos in the Afrikaans translations:
- Line 15: "Sppok" should be "Spook"
- Line 40: "WTerwyl" should be "Terwyl" and "rodgehang" should be "rondgehang"
- Line 80: "ht rodgehang" should be "hy rondgehang"
Apply these corrections:
- "Terwyk hy rondgehang het, het Sppok die volgende automatisasies teegekom:"
+ "Terwyl hy rondgehang het, het Spook die volgende automatisasies teegekom:"
- "WTerwyl hy rodgehang het, het Spook die volgende paneelbord teegekom:"
+ "Terwyl hy rondgehang het, het Spook die volgende paneelbord teegekom:"
- "Terwyl ht rodgehang het, het Spook die volgende helper teegekom:"
+ "Terwyl hy rondgehang het, het Spook die volgende helper teegekom:"Also applies to: 40-40, 80-80
| "name": "Datums" | ||
| }, | ||
| "homeassistant_device_tracker": { | ||
| "name": "Toetsel naspeurder" |
There was a problem hiding this comment.
Fix typos in entity translations
Found the following typos:
- Line 268: "Toetsel" should be "Toestel" (device)
- Line 304: "Tekse" should be "Tekste" (texts)
Apply these corrections:
- "name": "Toetsel naspeurder"
+ "name": "Toestel naspeurder"
- "name": "Tekse"
+ "name": "Tekste"Also applies to: 304-304
| "title": "Tuntemattomia entiteettejä käytetty: {tilanne}", | ||
| "description": "Spook on löytänyt aaveen kohtauksistasi 👻\n\nKelluessaan ympäriinsä Spook ristesi seuraavan kohtauksen kanssa:\n\n[{kohtaus}]({muokkaa})\n\nTämä kohtaus viittaa seuraaviin entiteeteihin, joita Home Assistant ei tunne:\n\n{entities}\n\n\n\nKorjaa tämä virhe [muokkaa kohtausta]({muokkaa}) ja poista näiden ei-olemassa olevien entiteettien käyttö.\n\nSpook 👻 Sinun kamusi." |
There was a problem hiding this comment.
Standardize placeholder names
There are inconsistencies in placeholder naming between English and Finnish:
- Line 74-75: Uses
{kohtaus}and{muokkaa}in description but{scene}and{edit}in title - Line 82-84: Similar inconsistency with
{scene}vs{tilanne}
This could cause runtime issues. Please standardize all placeholders to use either Finnish or English names consistently.
Example fix for scene_unknown_entity_references:
"scene_unknown_entity_references": {
- "description": "...{kohtaus}]({muokkaa})...",
+ "description": "...{scene}]({edit})...",
"title": "Tuntemattomia entiteettejä käytetty: {scene}"
}Also applies to: 82-84
Currently translated at 97.4% (114 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/sv/
Currently translated at 0.8% (1 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/mt/
Currently translated at 5.9% (7 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/mt/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/cs/
|
| "title": "Neznámá činnost použitá v: {automatizaci}", | ||
| "description": "Spook našel ducha ve tvých automatizacích 👻\n\nZatímco poletoval kolem, Spook narazil na následující automatizaci:\n\n[{automatizace}]({upravit}) (`{entity_id}`)\n\nTato automatizace odkazuje na následující služby, které Home Assistant nezná:\n\n\n{služby}\n\n\nAbys opravil tuto chybu, [uprav automatizaci]({upravit}) a zamez použití těchto neexistujících služeb.\n\nSpook 👻 Your homie." |
There was a problem hiding this comment.
💡 Codebase verification
Inconsistent placeholders and terminology need to be aligned with the rest of the file
Based on the search results, I can confirm that throughout the file:
- The automation placeholder is consistently used as
{automation}in all other messages - The edit link placeholder is consistently used as
{edit}in all other messages - The term "služby" (services) is used correctly in the description as it refers to Home Assistant services
The current message should be updated to maintain consistency with the rest of the translations:
- "title": "Neznámá činnost použitá v: {automatizaci}",
- "description": "Spook našel ducha ve tvých automatizacích 👻\n\nZatímco poletoval kolem, Spook narazil na následující automatizaci:\n\n[{automatizace}]({upravit}) (`{entity_id}`)\n\nTato automatizace odkazuje na následující služby, které Home Assistant nezná:\n\n\n{služby}\n\n\nAbys opravil tuto chybu, [uprav automatizaci]({upravit}) a zamez použití těchto neexistujících služeb.\n\nSpook 👻 Your homie."
+ "title": "Neznámá služba použitá v: {automation}",
+ "description": "Spook našel ducha ve tvých automatizacích 👻\n\nZatímco poletoval kolem, Spook narazil na následující automatizaci:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTato automatizace odkazuje na následující služby, které Home Assistant nezná:\n\n\n{služby}\n\n\nAbys opravil tuto chybu, [uprav automatizaci]({edit}) a zamez použití těchto neexistujících služeb.\n\nSpook 👻 Your homie."🔗 Analysis chain
Inconsistent terminology and placeholders need attention
There are two issues that need to be addressed:
- Terminology inconsistency: The title uses "činnost" (activity) while the description uses "služby" (services). These terms should be consistent.
- Placeholder inconsistency: The placeholders vary between:
{automatizaci}in title vs{automatizace}in description{upravit}in description vs{edit}in other similar messages throughout the file
Apply this diff to fix the inconsistencies:
- "title": "Neznámá činnost použitá v: {automatizaci}",
- "description": "Spook našel ducha ve tvých automatizacích 👻\n\nZatímco poletoval kolem, Spook narazil na následující automatizaci:\n\n[{automatizace}]({upravit}) (`{entity_id}`)\n\nTato automatizace odkazuje na následující služby, které Home Assistant nezná:\n\n\n{služby}\n\n\nAbys opravil tuto chybu, [uprav automatizaci]({upravit}) a zamez použití těchto neexistujících služeb.\n\nSpook 👻 Your homie."
+ "title": "Neznámá služba použitá v: {automation}",
+ "description": "Spook našel ducha ve tvých automatizacích 👻\n\nZatímco poletoval kolem, Spook narazil na následující automatizaci:\n\n[{automation}]({edit}) (`{entity_id}`)\n\nTato automatizace odkazuje na následující služby, které Home Assistant nezná:\n\n\n{služby}\n\n\nAbys opravil tuto chybu, [uprav automatizaci]({edit}) a zamez použití těchto neexistujících služeb.\n\nSpook 👻 Your homie."Let's verify the placeholder usage across the file:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for inconsistent placeholder usage across the file
# Expected: All similar messages should use consistent placeholders
# Check for automation-related placeholders
echo "Checking automation-related placeholders..."
rg -U "automatiz|{automation}|{edit}|{upravit}" custom_components/spook/translations/cs.json
Length of output: 316
Script:
#!/bin/bash
# Let's fix the regex and try again
echo "Checking automation-related placeholders..."
rg -U "automatiz|\\{automation\\}|\\{edit\\}|\\{upravit\\}" custom_components/spook/translations/cs.json
Length of output: 6099
Translations update from Hosted Weblate for Spook/Integration.
Current translation status: