Add validation for domain-name
of custom dhcp options used in VPCs
#615
Labels
area/ops-productivity
Operator productivity related (how to improve operations)
area/quality
Output qualification (tests, checks, scans, automation in general, etc.) related
kind/bug
Bug
platform/aws
Amazon web services platform/infrastructure
status/closed
Issue is closed (either delivered or triaged)
How to categorize this issue?
/area ops-productivity
/area quality
/kind bug
/platform aws
What would you like to be added:
Extend the infrastructure config validator so that it also checks if a VPC's dhcp options set
domain-name
key has the correct value corresponding to the region where the nodes are created. The correct value for thedomain-name
for theus-east-1
is ec2.internalWhy is this needed:
When users specify a VPC ID in the shoot spec, the referenced VPC can use custom dhcp options. The
domain-name
value inside these options could be missing which leads to the following problem: kubernetes/cloud-provider-aws#384An incorrect dhcp options would look like this:
A correct one would look like this:
Additionally, when setting the
domain-name
key field to some non-default value (e.g.compute.custom
) a similar problem appears - the nodes will be created in the cluster with names likeip-10-180-25-59.custom.domain
, however thePrivate IP DNS
name in the instance resource on AWS side will still be with a default value -ip-10-180-29-19.eu-west-2.compute.internal
and the machines will again fail to join the cluster.The dhcp options id can be retrieved from the VPC's
DhcpOptionsId
field.The validation that we introduce could be only temporary depending on whether/how/if kubernetes/cloud-provider-aws#384 will be fixed
The text was updated successfully, but these errors were encountered: