Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for domain-name of custom dhcp options used in VPCs. #644

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Add validation for domain-name of custom dhcp options used in VPCs. #644

merged 5 commits into from
Dec 12, 2022

Conversation

AleksandarSavchev
Copy link
Member

How to categorize this PR?

/area ops-productivity
/area quality
/kind bug
/platform aws

What this PR does / why we need it:
This PR adds validation for domain-name of custom dhcp options used in VPCs.

Which issue(s) this PR fixes:
Fixes #615

Special notes for your reviewer:

Release note:

Added validation for `domain-name` of custom dhcp options used in VPCs

@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/aws Amazon web services platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 23, 2022
@plkokanov
Copy link

/assign

plkokanov
plkokanov requested changes Nov 24, 2022
View reviewed changes
pkg/aws/client/client.go Outdated Show resolved Hide resolved
pkg/aws/client/client.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator_test.go Outdated Show resolved Hide resolved
pkg/aws/client/client.go Show resolved Hide resolved
pkg/aws/client/client.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator_test.go Outdated Show resolved Hide resolved
pkg/controller/infrastructure/configvalidator_test.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 24, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2022
@AleksandarSavchev AleksandarSavchev marked this pull request as ready for review November 28, 2022 13:27
@AleksandarSavchev AleksandarSavchev requested review from a team as code owners November 28, 2022 13:27
plkokanov
plkokanov requested changes Dec 7, 2022
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit left.

pkg/aws/client/client.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 7, 2022
@plkokanov
Copy link

/lgtm on my side @kon-angelo @dkistner could you also have a look.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/changes Needs (more) changes and removed needs/changes Needs (more) changes needs/review Needs review labels Dec 12, 2022
@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Dec 12, 2022
MartinWeindel
MartinWeindel approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Dec 12, 2022
kon-angelo
kon-angelo approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit a45dfbd into gardener:master Dec 12, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 12, 2022
@MartinWeindel MartinWeindel mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@plkokanov plkokanov plkokanov approved these changes

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees

@plkokanov plkokanov

Labels
area/ops-productivity Operator productivity related (how to improve operations) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation for domain-name of custom dhcp options used in VPCs
8 participants
@AleksandarSavchev @plkokanov @MartinWeindel @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot