Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated team.py code file. #1485

Open
wants to merge 3 commits into
base: v0.8-release
Choose a base branch
from

Conversation

vignesh1507
Copy link

Key changes that i have made to the code are as follows:

  1. Exception Handling.
  2. Deprecation Warning.
  3. Logging.
  4. Auto-Archiving.

This updated version includes more robust handling for running out of funds and provides better logging for project execution.

Key changes that i have made to the code are as follows:

1. Exception Handling.
2. Deprecation Warning.
3. Logging.
4. Auto-Archiving.
Fixed few typos and translated few type hints to english so that a large audience could understand the code much better.
Changes Made:

1. Added Optional[str] to the name argument in define_log_level to indicate that the argument can be None.

2. Used Callable[[str], None] as the type hint for functions that take a string and return None (such as the log function).

3. Provided return type hints where applicable, such as None for functions that do not return any value and _logger for functions returning the logger instance.
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.28%. Comparing base (c036574) to head (e43095c).

Files with missing lines Patch % Lines
metagpt/team.py 69.23% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           v0.8-release    #1485      +/-   ##
================================================
- Coverage         82.40%   82.28%   -0.13%     
================================================
  Files               249      245       -4     
  Lines             13839    13698     -141     
================================================
- Hits              11404    11271     -133     
+ Misses             2435     2427       -8     
Flag Coverage Δ
82.28% <77.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geekan geekan requested a review from better629 October 11, 2024 05:32
@better629
Copy link
Collaborator

@vignesh1507 some code is new( type declaration/ en annotation ) and others are already existed in main branch. So, suggest commit this to main branch.

@geekan
Copy link
Owner

geekan commented Oct 20, 2024

Can you merge into main branch?

@vignesh1507
Copy link
Author

Sure @geekan, i'll merge the changes to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants