-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated team.py code file. #1485
base: v0.8-release
Are you sure you want to change the base?
Conversation
Key changes that i have made to the code are as follows: 1. Exception Handling. 2. Deprecation Warning. 3. Logging. 4. Auto-Archiving.
Fixed few typos and translated few type hints to english so that a large audience could understand the code much better.
Changes Made: 1. Added Optional[str] to the name argument in define_log_level to indicate that the argument can be None. 2. Used Callable[[str], None] as the type hint for functions that take a string and return None (such as the log function). 3. Provided return type hints where applicable, such as None for functions that do not return any value and _logger for functions returning the logger instance.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v0.8-release #1485 +/- ##
================================================
- Coverage 82.40% 82.28% -0.13%
================================================
Files 249 245 -4
Lines 13839 13698 -141
================================================
- Hits 11404 11271 -133
+ Misses 2435 2427 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vignesh1507 some code is new( type declaration/ en annotation ) and others are already existed in main branch. So, suggest commit this to main branch. |
Can you merge into main branch? |
Sure @geekan, i'll merge the changes to the main branch. |
Key changes that i have made to the code are as follows:
This updated version includes more robust handling for running out of funds and provides better logging for project execution.