Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Color Space #88

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change Color Space #88

wants to merge 4 commits into from

Conversation

Dhanush2612
Copy link

Change Color Space BGR<->HSV using opencv.

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dhanush2612, amazing work.
Please go through the Contributing Guidelines. We are accepting implementations only in a .ipython notebook. Please make the necessary changes.

@Dhanush2612
Copy link
Author

@geekquad
You want this to be in .ipynb format right?

@Dhanush2612
Copy link
Author

@geekquad
I have converted all python files to .ipynb notebook format except for one which should be python format.

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dhanush2612, amazing work.
I can see there are two files with the name:

  1. BGR2HSV/BGR2HSV.ipynb
  2. BGR2HSV/BGR_to_HSV.ipynb
    What is its purpose?

Secondly, I would really appreciate it if you can add sample input and output in the notebook itself. It would really help us to know the end result and will be easy to understand for anyone visiting for the first time. Thankyou.

@Dhanush2612
Copy link
Author

@geekquad
I have made the changes and included videos of output.

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dhanush2612, amazing work.
Everything looks super good.
Path is wrong. Please add BGR2HSV in ChangeColorSpace folder.

Change Color Space BGR<->HSV using opencv.
@Dhanush2612
Copy link
Author

@geekquad
Sure, I have changed the path and pushed it again.

May I know if there is any issue with my PR #100 and #110.
I have made the changes that you had asked like adding readme files and videos and images of outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants